Rework "--tab" and "--window" behavior (Issue #13)
Changes the behavior to the one described in the issue which is more consistent (except for the behavior of "--tab" when there is an active window, since that change might interfere with existing workflows and it would remove functionality).
Additionally, "--tab" no longer needs to be the first option for a new tab to be added in an existing window.
MR !25 (merged) Issue #13 (closed)
Merge request reports
Activity
assigned to @SKefalidis
unassigned @SKefalidis
Test cases used:
- xfce4-terminal --drop-down --tab --window --tab --tab
- xfce4-terminal --tab --tab --tab --window --tab --window
- xfce4-terminal --tab --tab --tab --window
- xfce4-terminal --tab --tab --tab
- xfce4-terminal --window --tab
- xfce4-terminal --tab
- xfce4-terminal --window --window
Something that must be made clear in the documentation at https://docs.xfce.org/apps/xfce4-terminal/command-line
- xfce4-terminal --tab --drop-down --tab
is different from
- xfce4-terminal --tab --window --drop-down --tab --tab
Thank you, much more consistent behavior now. Don't forget to update the documentation (or ping @kevinbowen for access).
mentioned in merge request !27 (merged)
@SKefalidis does it make sense for
xfce4-terminal --tab
to open a window with two tabs when no window is already open?Yes, it does.
-
xfce4-terminal
is treated as, "get me a window". If there is no open window, that means creating a new window, if there is one then that window is used. -
--window
means, "create a new window and get me that one". -
--tab
means, "add an additional tab to the last specified window, whether that is a new window or an existing one, I don't care".
This seems both simple to understand and easy to code to me. In addition, if
xfce4-terminal --tab
and... --window --tab
opened a window with a single tab, the--tab
argument is essentially useless.Edited by Sergios - Anestis Kefalidis-
Ok, thanks for the explanation and the MR as a whole.
With regards to documentation, since @kevinbowen is MIA, please send me a draft of what should be clarified and I'll update that page.
By the way, what do you think of becoming terminal's maintainer? @skunnyk are you okay with that?
@andreldm I will send you a draft either in the evening or tomorrow morning :-)
As for becoming terminal's maintainer, I am very interested. It's been a lot of fun contributing to both Thunar and Terminal and I'm planning to continue doing so for a long while.
@andreldm for the documentation see this: https://pastebin.com/MRtGfsiS
Thanks, documentation updated. cc @kevinbowen
I also promoted you to maintainer ("with great power comes great responsibility"), feel free to ping me or other dev core if need anything. cc @ochosi @f2404
Happy hacking!
added 6 commits
-
09dbb927...6952df5f - 5 commits from branch
apps:master
- 22c4e643 - Rework "--tab" and "--window" behavior (Issue #13 (closed))
-
09dbb927...6952df5f - 5 commits from branch
mentioned in issue #13 (closed)
changed milestone to %0.9.0