Skip to content

Use symbolic window picker icon in toolbar

newhoa requested to merge newhoa/xfce4-taskmanager:window-picker-icon-symbolic into master

I'd like to replace the crosshairs icon with a symbolic icon to match the others, and possibly something that better shows the action. Currently in this PR using a window with a mouse pointing at it. Another option I tried was similar to the former crosshairs (similar to what Adwaita uses for the Gtk Inspector window picker icon). I think I like the window with mouse better so I went with that.

Edit: Oh, another option was to not provide an icon, and choose an icon name more widely provided by icon themes (preferably in the FreeDesktop.Org icon naming spec). I had a hard time finding something that universally made sense when switching themes, so I just stuck with providing an icon. But if this option is preferred, maybe we can find one that makes sense.

tasmanager-window-pick-prop1

tasmanager-window-pick-prop2

If the current icon looks okay, should the icon name be changed to something more appropriate?

Any other feedback would be appreciated! Thanks!

Git log: Switch to providing a symbolic icon for the window picker action. This should be more consistent with the other symbolic toolbar icons, look better in light and dark themes, and should look better with window scaling.

Edited by newhoa

Merge request reports