Skip to content

prefs-dialog: Fix string leak

correctmost requested to merge correctmost/xfce4-screensaver:cm/fix-separator-leak into master

Leak report

12 bytes in 1 blocks are definitely lost in loss record 819 of 16,668
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5A68661: g_malloc (gmem.c:100)
   by 0x5A81DD3: g_strdup (gstrfuncs.c:323)
   by 0x59EAA26: g_strdup_inline (gstrfuncs.h:321)
   by 0x59EAA26: value_lcopy_string (gvaluetypes.c:315)
   by 0x4CAFAF8: gtk_tree_model_get_valist (gtktreemodel.c:1812)
   by 0x4CAFCE4: gtk_tree_model_get (gtktreemodel.c:1774)
   by 0x10F28E: separator_func (xfce4-screensaver-preferences.c:965)
   by 0x4CC6A61: row_is_separator (gtktreeview.c:3113)
   by 0x4CC6A61: validate_row (gtktreeview.c:6368)
   by 0x4CC8F00: validate_visible_area (gtktreeview.c:6783)
   by 0x4CC8F00: do_presize_handler (gtktreeview.c:7102)
   by 0x4CC9318: presize_handler_callback (gtktreeview.c:7133)
[...snip...]

Testing

  • No issues were detected with Valgrind when testing the patch

Merge request reports