Skip to content

Fix string leaks in xfce_bg_load_from_xfconf

correctmost requested to merge correctmost/xfce4-screensaver:cm/fix-bg-load-leaks into master

Leak report

128 bytes in 1 blocks are definitely lost in loss record 10,252 of 11,788
   at 0x484BE40: realloc (vg_replace_malloc.c:1800)
   by 0x5366701: g_realloc (gmem.c:171)
   by 0x5382857: g_string_expand (gstring.c:82)
   by 0x53828CB: g_string_sized_new (gstring.c:113)
   by 0x5382E5B: g_string_new (gstring.c:134)
   by 0x5349B34: g_build_path_va (gfileutils.c:1914)
   by 0x534AF88: g_build_path (gfileutils.c:2077)
   by 0x119E02: find_system_backgrounds (xfce-bg.c:296)
   by 0x119E02: xfce_bg_load_from_xfconf (xfce-bg.c:442)
   by 0x119E02: xfce_bg_load_from_preferences (xfce-bg.c:314)
[...snip...]

128 bytes in 1 blocks are definitely lost in loss record 10,253 of 11,788
   at 0x484BE40: realloc (vg_replace_malloc.c:1800)
   by 0x5366701: g_realloc (gmem.c:171)
   by 0x5382857: g_string_expand (gstring.c:82)
   by 0x53828CB: g_string_sized_new (gstring.c:113)
   by 0x5382E5B: g_string_new (gstring.c:134)
   by 0x5349B34: g_build_path_va (gfileutils.c:1914)
   by 0x534B0DC: g_build_filename_va (gfileutils.c:2207)
   by 0x534B0DC: g_build_filename (gfileutils.c:2301)
   by 0x119E45: xfce_bg_load_from_xfconf (xfce-bg.c:442)
   by 0x119E45: xfce_bg_load_from_preferences (xfce-bg.c:314)
[...snip...]

Testing

  • No issues were detected with Valgrind when testing the patch

Merge request reports