Skip to content

Fix string leak in get_themes_menu

correctmost requested to merge correctmost/xfce4-screensaver:cm/fix-theme-menus-leak into master

Leak report

245 bytes in 5 blocks are definitely lost in loss record 7,999 of 8,470
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5366661: g_malloc (gmem.c:100)
   by 0x5380111: g_strconcat (gstrfuncs.c:585)
   by 0x11FA7B: get_themes_menu (gs-theme-manager.c:311)
   by 0x11FA7B: gs_theme_manager_init (gs-theme-manager.c:329)
   by 0x547C768: g_type_create_instance (gtype.c:1951)
   by 0x545EF87: g_object_new_internal (gobject.c:2606)
   by 0x546082D: g_object_new_with_properties (gobject.c:2769)
   by 0x546166E: g_object_new (gobject.c:2415)
   by 0x1201CB: gs_theme_manager_new (gs-theme-manager.c:355)
   by 0x120260: gs_job_init (gs-job.c:94)
[...snip...]

Testing

  • No issues were detected with Valgrind when testing the patch

Merge request reports