Skip to content

Fix string leak in xfce_bg_load_from_xfconf

correctmost requested to merge correctmost/xfce4-screensaver:cm/fix-string-leak into master

Leak report

46 bytes in 1 blocks are definitely lost in loss record 5,785 of 11,633
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5366661: g_malloc (gmem.c:100)
   by 0x5380111: g_strconcat (gstrfuncs.c:585)
   by 0x119D32: xfce_bg_get_property_prefix (xfce-bg.c:376)
   by 0x119D32: xfce_bg_load_from_xfconf (xfce-bg.c:427)
   by 0x119D32: xfce_bg_load_from_preferences (xfce-bg.c:314)
   by 0x113576: get_draw_dimensions (gs-lock-plug.c:1476)
   by 0x113576: redraw_background (gs-lock-plug.c:1493)
   by 0x113576: gs_lock_plug_constructed (gs-lock-plug.c:1702)
[...snip...]

Testing

  • No issues were detected with Valgrind when testing the patch

Merge request reports