OlivierDuchateau authored 5 years ago and Sean Davis committed 4 years ago

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

This reverts commit 378c7881.

This reverts commit 37b96373.

O H authored 4 years ago and Sean Davis committed 4 years ago

Similar code to prevent a crash exits elsewhere.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

This reverts commit f596f888.

Fixes #66

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

g_timeout_add_seconds expects a guint as first argument.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

g_idle_add expects a GSourceFunc as first argument.
Remove the casts and add proper prototype to affected functions.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

g_timeout_add_full expects a GSourceFunc as third argument.
Remove the casts and add proper prototype to affected functions.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

g_timeout_add_seconds expects a GSourceFunc as second argument.
Remove the casts and add proper prototype to affected functions.

Remove unneeded prototype for activate_dpms_timeout and deepsleep_idle.
Remove suffix from response_cancel_idle.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

date_time_update is called repeately by a timer.
To keep the timer active it has to return TRUE.

Handle OOM while being here.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

idle_time and lock_time are unsigned values.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Each call to get_x11_idle_info was allocating a new XScreenSaverInfo.

Adjust the function to check the result, print the raw value in debug mode,
and let the caller know about potential failures.

Keep the timer active in case of OOM.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

The used API g_timer_elapsed() returns a double instead of a struct timespec,
convert the result prior comparison.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Change all callers with large milliseond values to use seconds instead.
This is supposed to make it clearer how long the interval is.

No change in behavior intented.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

In cases where the dbus connection fails, gs_listener_dbus_init
will fail and return FALSE. Previously, this status code was not
checked in the gs_listener constructor, resulting in a silent failure
that eventually resulted in a Segmentation Fault when the listener's
system_connection pointer gets used.

Add a g_assert to ensure gs_listener_dbus_init succeeds, or bail out
gracefully on failures.

- exo-csource is deprecated and moved to xdt-csource
- Bump minimal xdt version
- Clean autohell variables: we already require automake 1.11+ from
  configure.ac, not need to add useless AUTOMAKE_OPTION

Rebuild windows on monitor reconfiguration, draw overlays during reconstruction to protect screen contents

OlivierDuchateau authored 5 years ago and Sean Davis committed 5 years ago

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Gusti Ridhoni Syahputera authored 5 years ago and Sean Davis committed 5 years ago

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Michael Weiser authored 5 years ago and Sean Davis committed 5 years ago

When inhibiting the screensaver using e.g. xfce4-screensaver-command -q,
xfce4-screensaver would report an error:

org.freedesktop.DBus.Error.ServiceUnknown raised: The name
org.freedesktop.login1 was not provided by any .service files

Consequently, no inhibitor was added to logind. This was due
to the fact that the wrong connection was used for the dbus message and
thus logind expected on the session bus.

Switching to the system connection to correctly relay the inhibitor to
logind.

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Michael Weiser authored 5 years ago and Sean Davis committed 5 years ago

The command would not reflect inhibited status and would not show the
inhibitors. This was due to the fact that unref'ing the reply gobject
also invalidates the body extracted from it and the iterator was set up
with the wrong format string.

Also, the body is a container and always contains the inhibitor array
element, even if it's empty. Therefore we have to check the number of
children of the actual array variant and not the body.

Change both to get inhibitors listed and inhibition status shown when
querying status.

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>