Skip to content
Snippets Groups Projects

Add icons at missing sizes, clean up SVG metadata

Merged newhoa requested to merge newhoa/xfce4-dict:add-icons into master
1 unresolved thread

@Tamaranch Should all icons/rDNS names be lowercase? I've noticed there are only a few that aren't (like Dictionary here) and I've seen a few MRs merged in other projects where they have been lowered. If so I can submit additional MRs to address that while I'm at these. Also, sorry if all these icon MRs are annoying, but I figured I'd just go ahead and start going down the line and try to get them all done. I know it's pretty superficial/trivial I guess but hopefully it'll help in some cases (esp HiDPI).

Thanks!


Adds app icon at 64px, 96px. This should give a cleaner look in system menus like App Finder, Whisker Menu.

Removes export path strings from SVGs, metadata which Inkscape added on export.

Note: Inkscape recently changed to save export paths as relative paths so this shouldn't be an issue in the future.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Should all icons/rDNS names be lowercase?

    No, that's not necessary. In fact, I think that historically (following D-Bus conventions) the convention was that they shouldn't be: https://docs.flatpak.org/en/latest/conventions.html#application-ids. But there's no imperative in the other direction either, which is why I kept everything in lower case when I packaged Mousepad and Ristretto in flatpak.

    Also, sorry if all these icon MRs are annoying, but I figured I'd just go ahead and start going down the line and try to get them all done.

    They're not annoying at all, on the contrary they're welcome, especially as you say for HiDPI :) I'll take care of merging most of them probably, that is, except for projects that currently have an active maintainer.

    • Thanks for polishing icons everywhere!

      Just a question, can't we get rid of svgs for specific sizes? As I understand only scalable needs to be svg, later we can generate pngs from it.

    • The icon in scalable is generally not exactly the same as the one for sizes other than 128x128 (particularly for smaller sizes, but not only; margins in particular are not necessarily to scale, see e.g. discussion in xfce/xfce4-panel!115 (comment 73186)). Better to keep the svg in general in my opinion (only in the repository, it's not installed), to be sure of the reference.

    • Got it, thanks. Then, let's merge.

    • Please register or sign in to reply
  • merged

  • Gaël Bonithon changed milestone to %0.8.6

    changed milestone to %0.8.6

Please register or sign in to reply
Loading