Co-authored-by: Gaël Bonithon <gael@xfce.org>

It used to mean 150 pixels when the app was written in gtk2
Now that 150 means 150 characters that's way too long

The GSList head changes when buttons are added to the group, so it
should not be used that way. This avoids a segfault when closing the
prefs dialog:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  gtk_radio_button_destroy (widget=0x5a4874b6d730) at ../gtk/gtk/gtkradiobutton.c:609
609	      tmp_button->priv->group = priv->group;

For getaddrinfo(3).  There should be no user action required, the
settings GUI still defaults to 2628 as port.

Technically, one can now specify "dict" as port, assuming a respective
services(5) entry points to, e.g. 2628/tcp.

Replace harcoded AF_INET/old-style gethostnyname(3) with its modern,
address-family agnostic replacement.

Now all of "dict.org", "127.0.0.1", "::1" and "localhost" just work.

getaddrinfo(3) takes both host and service/port as string, so a follow-up
commit will deal with the internal int -> char* conversion.

Improves consistency with other components and ensures that the icon is
properly scaled and sharp when UI scale > 1.

Closes #6

Closes #5

Also set 10 as the minimal size

Closes #4

Convert the callback into a real GSourceFunc.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Andre Miranda committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

pango_font_description_get_size is in points (or device units), not
pixels.

The workaround proposed by gtk authors is not only
complicated, it also add a very ugly left padding that's
impossible to remove AFAICT.
So let's keep the deprecated widget while it's around.

I'm going to revert part of this code in the next commit.
The reason I'm pushing this is because it can useful for gtk4.