Fix build warnings
Fixes #55 (closed), although the cases GDK_SCROLL_SMOOTH
remain TODOs.
Merge request reports
Activity
mentioned in merge request !17 (closed)
mentioned in issue #55 (closed)
- Resolved by Gaël Bonithon
You are doing an incredible job with those fixes. However, some parts of Xfce do not have an active maintainer, so it will take quite some time until MRs are being looked at.
Would you be interested in getting developer permissions for other components (Plugins, Apps, maybe Xfce core)?
If yes, please join our IRC channel
#xfce-dev
so that this can be discussed with the admins.
LGTM, @skunnyk wanna review before merge and maybe the next release?
added 20 commits
-
7d422ae4...a1fdccc0 - 17 commits from branch
apps:master
- 8446041a - autoconf: Some updates
- d7ffa760 - Fix compilation warnings
- 0224bd19 - Enable `HAVE_MAGIC_H`-delimited code
Toggle commit list-
7d422ae4...a1fdccc0 - 17 commits from branch
added 7 commits
-
0224bd19...4a51c9a1 - 4 commits from branch
apps:master
- 79f1ef7c - autoconf: Some updates
- 27aadb57 - Fix compilation warnings
- c157a713 - Enable `HAVE_MAGIC_H`-delimited code
Toggle commit list-
0224bd19...4a51c9a1 - 4 commits from branch
- Resolved by Gaël Bonithon
@skunnyk We could also replace
AC_CHECK_LIBM
withLT_LIB_M
to finish removing autotools warnings, but I can't find the info to know when this deprecation dates. Do you think it's ok?
905 906 area.width = icon_bar->priv->item_width; 906 907 area.height = icon_bar->priv->item_height; 907 908 908 // TODO: fix me 909 /*if (gdk_region_rect_in (expose->region, &area) != GDK_OVERLAP_RECTANGLE_OUT) 909 if (gdk_region_rect_in (expose->region, &area) != GDK_OVERLAP_RECTANGLE_OUT) 910 910 { 911 911 rstto_icon_bar_paint_item (icon_bar, item, &expose->area);*/ changed milestone to %0.11.0