The thumbnail background uses a fixed color

Submitted by Roland Pfeifer

Assigned to Igor @f2404

Link to original bug (#16718)

Description

Created attachment 9756 patch that adds setting to choose thumbnail background color behaviour

The added patch allows choosing if the default behaviour shoud be retained, or if the theme background color or the choosen background color shoud be used.

Patch 9756, "patch that adds setting to choose thumbnail background color behaviour":
ristrettoThumbnailBackground.patch

Version: 0.10.0

Theo Linkspfeifer said:

The patch works. However, applying it gives the following warnings:

Applying: allow unified background for thumbnails .git/rebase-apply/patch:11: trailing whitespace. GObject *settings, .git/rebase-apply/patch:12: trailing whitespace. GParamSpec *pspec, .git/rebase-apply/patch:17: trailing whitespace. RsttoIconBar *icon_bar, .git/rebase-apply/patch:26: trailing whitespace.

.git/rebase-apply/patch:39: trailing whitespace. icon_bar->priv->settings);
warning: squelched 26 whitespace errors warning: 31 lines add whitespace errors.

Roland Pfeifer submitted a patch:

Patch 9760, "corrected trailing whitespace, naming, free":
ristrettoThumbnailBackground.patch

Roland Pfeifer submitted a patch:

Patch 9769, "minor correction":
ristrettoThumbnailBackground.patch

This is a pretty significant fix, I stumbled across it and decided to patch this onto my own box. I notice the newest version doesn't have this option built in though.

Thanks a lot for this patch. This is what I would like to see in the new version.

added 2. Feature Patch labels

unassigned @f2404

Since I usually use Adwaita, I didn't really notice the difference in color between the background of the image and the background of the thumbnails. But it is true that with other darker themes, the difference is striking and even shocking.

So much so that I wonder if we should bother with an additional preference here. I'm tempted to just replace the current behavior with the patch.

So far I've only noticed as a side effect a dotted boundary between the image and the thumbnails, which appears with Greybird only when the thumbnail bar is placed at the bottom.

If people (@ryandward? @82d?) who use this patch have noticed other side effects, please report them. I still need to review the code and test further, but I think I'll merge it soon.

So far I've only noticed as a side effect a dotted boundary between the image and the thumbnails, which appears with Greybird only when the thumbnail bar is placed at the bottom.

It seems we can get rid of it with this: https://askubuntu.com/questions/1071005/xubuntu-18-04-lts-ugly-lines-when-scrollbar-active#1071108

This is actually not a side effect of this change. These underflow indications already appear in the current state as soon as the image is zoomed in enough to trigger them.

So it's better to let the users of the concerned themes manage this on their side as indicated in the link above, and not to force anything at CSS level on our side.

assigned to @Tamaranch

Version of the patch applicable on current git master for who would like to test: 0001-allow-unified-background-for-thumbnails.patch

mentioned in merge request !23 (merged)

After some simplifications and the removal of the additional preference, the change comes down to something very simple: see !23 (merged).

If anyone is opposed to the disappearance of the current look (white background for thumbnails), and would like to see an option added as proposed in the patch above, please come forward by the end of the week. Thanks!

See also !24 (merged), which will be merged in the same time frame.

closed with commit add59713

mentioned in issue #17 (closed)

changed milestone to %0.12.0