Skip to content

Fix build warnings 3: Clang static analyzer

Gaël Bonithon requested to merge Tamaranch/orage:fix-build-warnings-3 into master

Ping @andreldm @erxus

I left out three warnings. The first one is in my opinion wrong: scan-build can't see that the structure is initialized, but it is:

ical-code.c:2167:21: warning: 2nd function call argument is an uninitialized value [core.CallAndMessage]
        appt->uid = g_strconcat(file_type, appt->uid, NULL);

The other two are about potential memory leaks. While they may not be justified as such, they do highlight a shaky and unclear memory management, which should be reviewed. But that's beyond the scope of this MR, and, in doubt, I'd rather not risk a double free.

reminder.c:915:1: warning: Potential leak of memory pointed to by 'n_alarm' [unix.Malloc]
}
tz_convert.c:1067:9: warning: Potential leak of memory pointed to by 'rdate_data_std' [unix.Malloc]
    if (dst_init_done)
Edited by Gaël Bonithon

Merge request reports