Search bar issues

• pressing Ctrl + V does not paste the clipboard content in the focused entry field of the search bar, but in the document
• opening a new document triggers the search routine which should only happen when initiated by the user

Version: 0.5.1

Grrr… Rolling release should be the norm!

The easiest and most efficient thing to do at the moment for Ctrl+V is to disable this keybinding in ~/.config/Mousepad/accels.scm: replace

; (gtk_accel_path "<Actions>/win.edit.paste" "<Primary>v")

with

(gtk_accel_path "<Actions>/win.edit.paste" "")

This will actually make it work properly again.

Regarding the search routine triggered when opening a new document, that is desired behavior: trigger a search when switching tab (either with the search bar or the replace dialog).

My impression was that a document should be opened at the very top. An active search term breaks this expectation. However, saving the term per document or even hiding the bar is probably not an ideal solution either.

Before !58 (merged), only the replace dialog was connected to the "switch-page" signal, we can return to this behavior. By the way, when both search widgets are open, the connection of the search bar is disabled (to avoid conflicts).

I guess we can keep the current behavior.

My reference was Gedit which does not have a shared search bar across all documents and also does not immediately start searching when you type in the replace dialog.

mentioned in merge request !66 (merged)

mentioned in issue #85 (closed)

closed

The "Wrap Around" setting from the replace dialog affects the search bar too.

Source: https://forum.xfce.org/viewtopic.php?id=14610

Yes, I removed its "always enabled" state in !58 (merged), considering that there was no reason for the search bar to not follow the search settings on this point. Same as above for tab switching: this can be easily reverted.

Anyway, I think we could leave this issue open until Mousepad 0.5.2 is released, in particular for the workaround for the keybinding bug.

NB: the default value for wrap-around in GSettings is currently false, we could change it to true.

This search setting is hidden (no button on the search bar or entry in the menu). So, it is not obvious how to change the behavior.

It is present in the replace dialog, which acts as an "advanced search" dialog.

Is this case not similar to "Highlight All" then? This option was moved to the search menu and affects both replace dialog and search bar.

Well, all options (except those only related to replacement) affect both replace dialog and search bar. Also, I put highlight-all in the menubar to not overload even more the replace dialog, but also because it is quite a special "setting": not really a search setting actually, it only influences the rendering of the search, not the result.

wrap-around on the other hand is a real search setting, and I find that the location we gave it in commit bfaa6a22 is quite suitable (and justified in #15 (closed)).

Personally, I do not see the benefit of having the search bar be affected by wrap-around. Firefox and Gedit have it always enabled for their search widget while displaying the total amount of matches.

Gedit:
1 of 2

Firefox:
1 of 2 matches Reached end of page, continued from top

Ok to revert this, and change the default value to true by the way.

Done: 049cf3ad.

reopened

mentioned in commit 049cf3ad

Closing: Mousepad 0.5.2 has been released.

closed

mentioned in issue #99 (closed)

marked this issue as related to #99 (closed)

mentioned in commit 7397c8ac

mentioned in merge request !102 (merged)

changed milestone to %0.5.2

assigned to @Tamaranch