Use GMutex instead of gint for lock_menu_updates

Submitted by Ricardo Biehl Pasquali

Assigned to Matthew Brush @matt

Link to original bug (#14654)

Description

File: mousepad-window.c

Perhaps it's racy!

I have not dive into the code, though.

Cheers!

Version: Unspecified

Andre Miranda @andreldm said:

But have you experienced any deadlock, or you just read the source and thought this could be improved?

Ricardo Biehl Pasquali said:

(In reply to Andre Miranda from comment 1)

But have you experienced any deadlock, or you just read the source and thought this could be improved?

The latter.

Matthew Brush @matt said:

It's not multi-threaded code, why use a mutex?

That said, I don't see any obvious reason why it's using a global variable when the MousepadWindow seems to be passed around everywhere.

The variable is transverse to the different windows, like the other global variables for clipboard history and last save location, although in this case I don't think it makes much difference in practice.

Another issue that could be closed in my opinion.

Agreed.

closed