Skip to content
Snippets Groups Projects
  1. Aug 13, 2009
  2. Jul 07, 2009
    • Jerome Guelfucci's avatar
      Fix ZimageZ login with UTF-8 characters. · 901e3227
      Jerome Guelfucci authored
      g_strreverse should not be used with UTF-8 strings! Also fix the error
      checking for the logout method, which is by the way broken (upstream
      has been contacted for this).
      
      
      (Old svn revision: 7691)
      901e3227
    • Jerome Guelfucci's avatar
      Use libsoup instead of XMLRPC-C. · d3c68171
      Jerome Guelfucci authored
      Add libsoup as a dependency, remove the XMLRPC-C stuff. Factorize the
      xmlrpc calls in lib/screenshooter-zimagez.c and add some additional
      error checking.
      
      
      (Old svn revision: 7690)
      d3c68171
  3. Jul 06, 2009
  4. Jul 05, 2009
  5. Jun 06, 2009
  6. Jun 05, 2009
    • Jerome Guelfucci's avatar
      Reimplement an old workaround to fix screenshots without delay. · a82191e7
      Jerome Guelfucci authored
      If the delay is NULL, and under some vague conditions, there is
      no active window detected. Waiting 1 second before doing anything is a
      lame hack which fixes this issue.
      
      
      
      (Old svn revision: 7462)
      a82191e7
    • Jerome Guelfucci's avatar
      Try to fix bug #5424. · 1132298e
      Jerome Guelfucci authored
      Destroy the main dialog before doing anything else. Normally, this will
      prevent this dialog from remaining displayed on the screen and being
      captured instead of the active window.
      
      
      
      (Old svn revision: 7461)
      1132298e
  7. May 31, 2009
  8. May 29, 2009
    • Jerome Guelfucci's avatar
      Fix a crash in the panel plugin. · 73c546ef
      Jerome Guelfucci authored
      Use sd->cli and sd->close correctly so that it does not exit the main
      loop when running the panel plugin which makes it crash. Simplify the 
      code a bit and set the members of the structure correctly when 
      initializing the application and the plugin.
      
      
      
      (Old svn revision: 7437)
      73c546ef
  9. May 28, 2009
  10. May 24, 2009
  11. May 23, 2009
  12. May 21, 2009
    • Jerome Guelfucci's avatar
      * lib/sexy-url-label.{c,h}: mark some strings as translatable and · c72245e9
      Jerome Guelfucci authored
      	  include the libxfce4util header to have the "_" translation
      		function.
      	* po/POTFILES.in: add the new translatable files. 
      
      
      (Old svn revision: 7384)
      c72245e9
    • Jerome Guelfucci's avatar
      * lib/screenshooter-zimagez.c: · 08cf214c
      Jerome Guelfucci authored
      	  - remove (open_zimagez_link) and use (open_url_hook) in all
      		  cases.
      		- (cb_image_uploaded) improve the dialog by using SexyUrl labels
      		  instead of link buttons and by showing two usage examples, in
      			HTML and in BB code.
      		- (cb_image_uploaded) use constants for all strings.
      
      
      
      (Old svn revision: 7383)
      08cf214c
  13. May 18, 2009
    • Jerome Guelfucci's avatar
      * Improve the status dialog of the upload to ZimageZ. · 7b488ad0
      Jerome Guelfucci authored
      	* Remember the last ZimageZ user name and put it in the user field
      	  when displaying the dialog for the first time.
      
      
      (Old svn revision: 7367)
      7b488ad0
    • Jerome Guelfucci's avatar
      * lib/screenshooter-dialogs.c: · 79f20969
      Jerome Guelfucci authored
      	  - (screenshooter_dialog_new) add a radio button for uploading in the
      	    actions. Indent some comments correctly.
      	  - (cb_zimagez_toggled) add a callback for the radio button.
      	  - remove some useless comments.
      
      
      (Old svn revision: 7362)
      79f20969
    • Jerome Guelfucci's avatar
      * lib/screenshooter-global.h: add a cli gboolean to the ScreenshotData · 89d07586
      Jerome Guelfucci authored
      	  structure. Combined with the close member of the structure, this
      	  allows to close the application or not depending on how the
      	  executable is called.
      	* src/main.c, lib/screenshooter-actions.{c,h}: move the dialog
      	  stuff to (screenshooter_take_and_output_screenshot) which is
      	  from now on a GSourceFunc. It returns TRUE if we want to take
      	  another screenshot, else it quits the main loop and returns
      	  FALSE. It is called via g_idle_add in (main), which allows us
      	  to always have a main loop. The workaround consisting in
      	  sleep (1) before taking a screenshot seems useless now.
      	* lib/screenshooter-zimagez.c: don't start and exit a main
      	  loop here, run the dialog instead of showing it.
      	* panel-plugin/screenshooter-plugin.c: set the cli member of the
      	  structure to false when initializing the plugin.
      
      
      (Old svn revision: 7361)
      89d07586
    • Jerome Guelfucci's avatar
      * lib/screenshooter-utils.c (screenshooter_error), · f9d29e82
      Jerome Guelfucci authored
      	  lib/screenshooter-job.c (screenshooter_job_ask_info):
      	  do not initialize va_list to NULL, that's wrong and useless.
      	  Thanks to Enrico Tröger.
      
      
      (Old svn revision: 7360)
      f9d29e82
  14. May 17, 2009
    • Jerome Guelfucci's avatar
      * lib/screenshooter-zimagez.c: · aca1a435
      Jerome Guelfucci authored
      	  - (zimagez_upload_job) remove a useless cancel check before the loop.
      	  - (cb_ask_for_information) do not disconnect handlers before
      	    cancelling the job, only before destroying it.
      
      
      (Old svn revision: 7358)
      aca1a435
    • Jerome Guelfucci's avatar
      * lib/screenshooter-utils.{c,h}: use a constant in · 9515ffa6
      Jerome Guelfucci authored
      	  (screenshooter_read_rc_file) and (screenshooter_write_rc_file).
      	* src/main.c:
      	  - use a constant for the rc file.
      	  - don't save the preferences in the callback but in (main).
      
      
      (Old svn revision: 7356)
      9515ffa6
  15. May 16, 2009
    • Jerome Guelfucci's avatar
      * src/screenshooter-utils.{c,h}: add (screenshooter_error) which shows · 79f58112
      Jerome Guelfucci authored
      	  an error using a GtkMessageDialog.
      	* lib/*, panel-plugin/screenshooter-plugin.c, src/main.c:
      	  - use (screenshooter_error) instead of (xfce_err).
      	  - remove some trailing white spaces.
      	* lib/screenshooter-job.c (screenshooter_job_ask_info): add a missing return,
      	  when the job has been cancelled.
      	* TODO: updated.
      
      
      (Old svn revision: 7352)
      79f58112
  16. May 15, 2009
    • Jerome Guelfucci's avatar
      * src/main.c: · 19b447e2
      Jerome Guelfucci authored
      	  - add the glib and stdlib headers.
      	  - use RETURN_SUCCESS and RETURN_FAILURE instead of 0 and 1.
      	* lib/exo-simple-job.{c,h}, lib/exo-job.{c,h}: take the job framework
      	  from Exo written by Jannis Pohlmann. Thank you Jannis!
      	* lib/screenshooter-job.{c,h}, lib/screenshooter-simple-job.{c,h}:
      	  ScreenshooterJob is based on ExoJob, it provides to additional signals,
      	  ask and image-uploaded.
      	* lib/screenshooter-marshal.list: add some marshallers for the new
      	  signals.
      	* lib/screenshooter-zimagez.{c,h}: port the existing code to use a
      	  ScreenshooterJob. Thanks to Jannis for his great help! This fixes
      	  a bunch of problems that occured with the previous implementation.
      	  The dialogs still need to be polished.
      	* lib/screenshooter-actions.c: use the new function.
      	* lib/Makefile.am:
      	  - add some magic to generate the marshallers.
      	  - sort the source files by alphabetical order.
      	* configure.ac.in: bump the GThreads required version to 2.16.
      
      
      
      (Old svn revision: 7340)
      19b447e2
  17. May 05, 2009
  18. May 04, 2009
    • Jerome Guelfucci's avatar
      * lib/sexy-url-label.{c,h}: add the sexy_url_label taken from · 96c5c055
      Jerome Guelfucci authored
      	  libsexy.
      	* lib/screenshooter-zimagez.{c,h}:
      	  - add a link to ZimageZ so that users can create an account easily.
      	  - add tooltips for the different entries.
      	  - if one of the fiels is empty when the dialog is validated, show it
                  again and ask the user to fill all the fields.
      	  - plug some leaks and fix a double free issue.
      
      
      (Old svn revision: 7312)
      96c5c055
    • Jerome Guelfucci's avatar
      * lib/screenshooter-zimagez.c: · d85e9024
      Jerome Guelfucci authored
      	  - (screenshooter_upload_to_zimagez):
      	    + use a GtkTable to improve the layout.
      	    + add a cancel button to the dialog.
      	    + display a warning if the password/user name was not correct
      	      when respawning the dialog.
      	    + make the labels left aligned and vertically centered to
      	      improve the look of the dialog.
      	    + tweak the layout by adding an alignment.
      	  - (screenshooter_display_zimagez_links) document this function.
      
      
      (Old svn revision: 7311)
      d85e9024
    • Jerome Guelfucci's avatar
      * lib/screenshooter-zimagez.c: loop until the user has entered the · 84bfd019
      Jerome Guelfucci authored
      	  correct user/password couple.
      
      
      (Old svn revision: 7310)
      84bfd019
  19. May 02, 2009
    • Jerome Guelfucci's avatar
      * lib/screenshooter-zimagez.{c,h}: · a1ec7eb9
      Jerome Guelfucci authored
      	  - (warn_if_fault_occurred) should be static.
      	  - add some comments.
      	  - (screenshooter_upload_to_zimagez) now returns a gchar* containing
      	    the name of the uploaded image and NULL is the upload failed.
      	  - (screenshooter_display_zimagez_links) new function which shows a
      	    dialog to present the different links to the uploaded image. At
      	    the moment, plain GtkLinkButtons are used, this still needs to be
      	    improved.
      	  - (open_url_hook) hook to open the links using xdg-open.
      	* lib/screenshooter-actions.c:
      	  - use constants where possible.
      	  - use (screenshooter_display_zimagez_links) to display the result of
      	    the upload.
      	* lib/screenshooter-utils.{c,h}, lib/screenshooter-dialogs.{c,h}:
      	  use constants where possible.:wq
      
      
      
      (Old svn revision: 7308)
      a1ec7eb9
  20. May 01, 2009
    • Jerome Guelfucci's avatar
      2009-05-01 jeromeg · d5df895a
      Jerome Guelfucci authored
      	This still needs a lot of polishment, but let's make things public.
      
      	* src/Makefile.am, panel-plugin/Makefile.am: change the linking order.
      	* lib/screenshooter-zimagez.c:
      	  - (warn_if_fault_occurred) to warn if an error occured during the XML
      	    transaction.
      	  - (screenshooter_upload_to_zimagez) to upload the screenshot. Still needs
      	    a lot of polish, but at least it works.
      	* TODO: updated.
      
      2009-04-19 jeromeg
      
      	* src/main.c:
      	  - sort the CLI options by alphabetical order.
      	  - add an upload CLI option.
      	  - add some G_LIKELY and G_UNLIKELY macros.
      	* lib/screenshooter-actions.c:
      	  - add some G_LIKELY and G_UNLIKELY macros.
      	  - call the upload function when the user requested it.
      	* lib/screenshooter-utils.{c,h}: add a (rot13) function to encode the
      	  password before sending it.
      	* lib/screenshooter-zimagez.{c,h}: two new files to support the upload
      	  of screenshots to ZimageZ.com, a free Web hosting solution.
      	* lib/screenshooter-global.h: add the upload option.
      	* lib/Makefile.am: add the two new files to the source.
      	* configure.ac.in: check for xmlrpc-c, this is a bit uggly, but xmlrpc-c
      	  does not provide a .pc file...
      
      
      
      (Old svn revision: 7299)
      d5df895a
  21. Apr 18, 2009
  22. Apr 16, 2009
    • Jerome Guelfucci's avatar
      * lib/screenshooter-actions.c: minor indentation change. · 513f8a28
      Jerome Guelfucci authored
      	* lib/screenshooter-utils.c:
      	  - minor indentation improvements.
      	  - (screenshooter_read_rc_file) only get the home uri once.
      	* lib/screenshooter-capture.c:
      	  - minor indentation improvements.
      	  - correctly document (screenshooter_take_screenshot).
      
      
      (Old svn revision: 7218)
      513f8a28
Loading