From e6a32cf7d789ca3058f50fd630de8e518d310cf8 Mon Sep 17 00:00:00 2001
From: Michael Banack <bob5972@banack.net>
Date: Wed, 5 Aug 2020 07:11:17 -0700
Subject: [PATCH] Fix errorTrap leak in free_win_data
The function free_win_data() may generate X11 errors as the client
window may already be gone.
To avoid those, the entire function code is supposed to be enclosed
within an error trap/push.
A typo in the code would however push twice instead of a balanced
push/pop which causes the list of event sequences in GDK to grow
indefinitely, leading to slowdowns as the list grows over time.
Fix the leak by balancing the error push with an error pop at the end
of the function.
https://gitlab.xfce.org/xfce/xfwm4/-/issues/351
---
src/compositor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compositor.c b/src/compositor.c
index 5b4e0487c..b86d5adb6 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -857,7 +857,7 @@ free_win_data (CWindow *cw, gboolean delete)
cw->saved_picture = cw->picture;
cw->picture = None;
}
- myDisplayErrorTrapPush (display_info);
+ myDisplayErrorTrapPopIgnored (display_info);
}
static Picture
--
GitLab