settings: Duplicate string gvalues

The gvalues strings were considered statics, hence not duplicated.

As the caller frees the strings after setting the gvalue, the actual
content would end up pointing at free data.

Consider string gvalues as regular strings, meaning that the given
string value is duplicated as a gvalue.
Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
Closes: #406

src/parserc.c

@@ -211,7 +211,7 @@ setStringValue (const gchar * lvalue, const gchar *value, Settings *rc)
 {
     GValue tmp_val = {0, };
     g_value_init(&tmp_val, G_TYPE_STRING);
-    g_value_set_static_string(&tmp_val, value);
+    g_value_set_string(&tmp_val, value);
     return setGValue (lvalue, &tmp_val, rc);
 }
 

[Tomasz Kłoczko]

Is it any chance to make new release?

it is almost year since last release. Really it would be good to make a bit more frequent releases.

[Olivier Fourdan]

Is it any chance to make new release?

Yes, I plan to backport the fix to stable.

it is almost year since last release. Really it would be good to make a bit more frequent releases.

That is simply not true, xfwm4 4.14.2 was release on January 2020.