Critical warning (possible crash) in xfdesktop_x11_set_compat_properties
Issue Description
I had this SIGABRT in my logs yesterday because I run Xfce components with G_DEBUG=fatal-criticals by default. I don't know how it happened, but obviously it could have been a crash (dangling pointer).
Steps to Reproduce Issue
No idea.
Expected Behavior
No warning, no crash.
Additional Information
gtk_widget_get_screen: assertion 'GTK_IS_WIDGET (widget)' failed
Program terminated with signal SIGABRT, Aborted.
#0 0x00007fcadbe9890c in ?? () from /opt/bin/../../lib/libc.so.6
[Current thread is 1 (Thread 0x7fcadac96a80 (LWP 1054))]
(gdb) bt
#0 0x00007fcadbe9890c in ??? () at /opt/bin/../../lib/libc.so.6
#1 0x00007fcadbe3e3a0 in raise () at /opt/bin/../../lib/libc.so.6
#2 0x00007fcadbe2557a in abort () at /opt/bin/../../lib/libc.so.6
#3 0x00007fcadd0560f9 in _g_log_abort (breakpoint=breakpoint@entry=1) at ../glib/glib/gmessages.c:454
#4 0x00007fcadd09d694 in g_logv (log_domain=0x7fcadcda8014 "Gtk", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=<optimized out>) at ../glib/glib/gmessages.c:1313
#5 0x00007fcadd09d964 in g_log (log_domain=log_domain@entry=0x7fcadcda8014 "Gtk", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7fcadd164708 "%s: assertion '%s' failed")
at ../glib/glib/gmessages.c:1355
#6 0x00007fcadd09e9ee in g_return_if_fail_warning
(log_domain=log_domain@entry=0x7fcadcda8014 "Gtk", pretty_function=pretty_function@entry=0x7fcadce2ead0 <__func__.127> "gtk_widget_get_screen", expression=expression@entry=0x7fcadcdae42b "GTK_IS_WIDGET (widget)") at ../glib/glib/gmessages.c:3197
#7 0x00007fcadcce77bb in gtk_widget_get_screen (widget=<optimized out>) at ../gtk/gtk/gtkwidget.c:10912
#8 0x00005569b6395f40 in xfdesktop_x11_set_compat_properties (desktop=0x41e, desktop@entry=0x5569dfd71b50) at ../src/xfdesktop-x11.c:187
#9 0x00005569b638f218 in backdrop_loaded (bmedia=<optimized out>, region=0x7ffc10655408, image_file=0x0, error=<optimized out>, user_data=0x5569dfd71b50) at ../src/xfce-desktop.c:367
#10 0x00005569b63931c4 in notify_complete
(bmedia=bmedia@entry=0x5569dfd8a140 [XfdesktopBackdropMedia], monitor=<optimized out>, is_spanning=<optimized out>, image_file=<optimized out>, callback=<optimized out>, callback_user_data=<optimized out>)
at ../src/xfdesktop-backdrop-manager.c:731
#11 0x00005569b6393395 in render_finished (bmedia=0x5569dfd8a140 [XfdesktopBackdropMedia], width=-1, height=<optimized out>, error=0x5569dffed410, user_data=0x5569dff03f40)
at ../src/xfdesktop-backdrop-manager.c:836
#12 0x00005569b639470b in image_data_error (image_data=<optimized out>, error=0x5569dffed410) at ../src/xfdesktop-backdrop-renderer.c:97
#13 0x00005569b6394807 in file_ready_cb (source_object=<optimized out>, res=<optimized out>, user_data=0x5569dffebd20) at ../src/xfdesktop-backdrop-renderer.c:593
#14 0x00007fcadd297b8c in g_task_return_now (task=0x5569dfed2400 [GTask]) at ../glib/gio/gtask.c:1363
#15 0x00007fcadd297bd5 in complete_in_idle_cb (task=0x5569dfed2400) at ../glib/gio/gtask.c:1377
#16 0x00007fcadd096ecd in g_main_dispatch (context=0x5569dfbbaf90) at ../glib/glib/gmain.c:3565
#17 0x00007fcadd098587 in g_main_context_dispatch_unlocked (context=0x5569dfbbaf90) at ../glib/glib/gmain.c:4425
#18 g_main_context_iterate_unlocked (context=0x5569dfbbaf90, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/glib/gmain.c:4490
#19 0x00007fcadd098947 in g_main_loop_run (loop=0x5569dffb4ad0) at ../glib/glib/gmain.c:4695
#20 0x00007fcadcac3ff2 in gtk_dialog_run (dialog=dialog@entry=0x5569dfbeb270 [GtkDialog]) at ../gtk/gtk/gtkdialog.c:1399
#21 0x00005569b63a633d in create_icon_view (fmanager=0x5569dfd847f0 [XfdesktopFileIconManager], desktop=<optimized out>) at ../src/xfdesktop-file-icon-manager.c:1464
#22 xfdesktop_file_icon_manager_desktop_added (manager=0x5569dfd847f0 [XfdesktopFileIconManager], desktop=<optimized out>) at ../src/xfdesktop-file-icon-manager.c:1531
#23 0x00005569b63a0c31 in xfdesktop_icon_view_manager_desktop_added (manager=0x5569dfd847f0 [XfdesktopFileIconManager], desktop=desktop@entry=0x5569dfd71b50) at ../src/xfdesktop-icon-view-manager.c:428
#24 0x00005569b6390b3c in add_monitor_desktop (app=0x5569dfc759d0 [XfdesktopApplication], monitor=0x7fcabc014390 [XfwMonitorX11]) at ../src/xfdesktop-application.c:847
#25 handle_new_mirror_sets (app=<optimized out>, mirror_sets=<optimized out>) at ../src/xfdesktop-application.c:881
#26 handle_monitors_changed (app=0x5569dfc759d0 [XfdesktopApplication]) at ../src/xfdesktop-application.c:974
#30 0x00007fcadd1c311f in <emit signal 'monitor-removed or 0x7fcadc5d243f "monitor-removed"' on instance 0x7fcacc0179c0 [XfwScreenX11]>
(instance=instance@entry=0x7fcacc0179c0, detailed_signal=detailed_signal@entry=0x7fcadc5d243f "monitor-removed") at ../glib/gobject/gsignal.c:3665
#27 0x00007fcadd1a1a0c in g_closure_invoke (closure=0x5569dfdcf730, return_value=0x0, n_param_values=2, param_values=0x7ffc10655aa0, invocation_hint=0x7ffc106559f0) at ../glib/gobject/gclosure.c:916
#28 0x00007fcadd1c0b6b in signal_emit_unlocked_R
(node=node@entry=0x7ffc10655bd0, detail=detail@entry=0, instance=instance@entry=0x7fcacc0179c0, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffc10655aa0)
at ../glib/gobject/gsignal.c:3929
#29 0x00007fcadd1c2bcf in signal_emit_valist_unlocked (instance=instance@entry=0x7fcacc0179c0, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffc10655d20)
at ../glib/gobject/gsignal.c:3561
#31 0x00007fcadc5c40c9 in _xfw_screen_set_monitors (screen=0x7fcacc0179c0 [XfwScreenX11], monitors=monitors@entry=0x5569dfb75510 = {...}, added=added@entry=0x0, removed=removed@entry=0x5569dfcf5da0 = {...})
at ../libxfce4windowing/xfw-screen.c:680
#32 0x00007fcadc5c831e in refresh_monitors (manager=0x5569dfcf6670) at ../libxfce4windowing/xfw-monitor-x11.c:551
#33 0x00007fcadc5c836d in refresh_monitors_idled (data=<optimized out>) at ../libxfce4windowing/xfw-monitor-x11.c:561
#34 0x00007fcadd096ecd in g_main_dispatch (context=0x5569dfbbaf90) at ../glib/glib/gmain.c:3565
#35 0x00007fcadd098587 in g_main_context_dispatch_unlocked (context=0x5569dfbbaf90) at ../glib/glib/gmain.c:4425
#36 g_main_context_iterate_unlocked (context=context@entry=0x5569dfbbaf90, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/glib/gmain.c:4490
#37 0x00007fcadd098795 in g_main_context_iteration (context=context@entry=0x5569dfbbaf90, may_block=may_block@entry=1) at ../glib/glib/gmain.c:4556
#38 0x00007fcadd2d35d6 in g_application_run (application=application@entry=0x5569dfc759d0 [XfdesktopApplication], argc=<optimized out>, argv=<optimized out>) at ../glib/gio/gapplication.c:2742
#39 0x00005569b63873c3 in main (argc=<optimized out>, argv=<optimized out>) at ../src/main.c:67
Environment & Versions
- OS distribution and version: Arch Linux
- Overall Xfce version: 4.20
- xfdesktop version (git hash if not a release):
4.20.1-dev-f1468abc - thunar version (if issue related to file/launcher icons):
- Windowing system (X11/Wayland): X11
- Compositor and version (if Wayland):
- GTK Theme: Adwaita
- Icon Theme: elementary Xfce
- UI Scale Factor: 1