settings-editor search: If the matched item is not a leaf node then the tree below that item gets hidden
From: #157 (comment 46789)
Another issue with the current implementation is that if the text matches with the property which is a leaf node (For example in ristretto channel window/navigationbar/sort-type
) then the whole tree for that matching leaf node is displayed which is a good thing! This is the screencast:
But if the matched text is not the leaf node then the complete tree down that matched node get hidden. For e.g. user wants to disable thumbnails getting displayed in ristretto. So she selects ristretto channel and then starts to type "thumbnail". The search text correctly gets matched to window/thumbnails/show
but hides the show
which is what she needed. thumbnails
node does nothing by itself. It's the show
leaf node under thumbnails
node which controls the display of thumbnails. Screencast:
Another example is trying to see/tweak clipman settings. User searches for "clipman" in xfce4-panel
channel. The "clipman" node gets matched and the tree below the "clipman" node gets hidden. If "clipman" would have been a leaf node then search would have shown the tree correctly. Screencast:
I expected to see the complete tree: plugins/clipman/settings/show-qr-code
+ the leaf nodes at plugins/clipman/tweaks
.
I think we should display the full tree down the matched node. i.e. all the downstream middle nodes and leaf nodes from the matched node.