Merging style and icons tabs into a theme tab

Submitted by Yousuf Philips @philipzae

Assigned to Xfce Bug Triage

Link to original bug (#16500)

Description

Created attachment 9532 how it will look

Rather than users having to jump between tabs to finalize tweaking of their theme, we merge the style and icon tabs into a theme tab.

Attachment 9532, "how it will look":

Version: 4.15.0

added 5. Appearance Settings label

Yousuf Philips @philipzae submitted a patch:

Assume there maybe some small adjustments that are needed

Patch 9533, "the patch":
0001-Merge-style-and-icon-tabs-into-theme-tab-bug-16500.patch

Simon Steinbeiß @ochosi said:

This doesn't look great to be honest.

While it brings the benefit of having the theme and the icons on one page, you end up with tiny scrolledwindows that don't show much of their content. So from an a11y pov this is really --

Also, what would be the argument of merging those two tabs and not "Icons" and "Fonts"? or "Style" and "Icons" and "Fonts"?

Yousuf Philips @philipzae said:

(In reply to Simon Steinbeiss from comment 2)

This doesn't look great to be honest.

Definitely could look better if the icon listbox showed a single line rather than 2 lines, like the style listbox.

While it brings the benefit of having the theme and the icons on one page, you end up with tiny scrolledwindows that don't show much of their content. So from an a11y pov this is really --

From a UX perspective, users will want to change both of these when they are changing the theme and it isnt a good experience for them to have to constantly jump between the tabs to find the right icon and style combination they are looking for.

Also, what would be the argument of merging those two tabs and not "Icons" and "Fonts"? or "Style" and "Icons" and "Fonts"?

Fonts has anti-aliasing and dpi settings which aren't theme related.

Yousuf Philips @philipzae uploaded an attachment:

I've seen the phrase 'UI Controls' and 'UI Elements' used which would be better than 'Window Internal Decorations'.

In order to make it easier to see more entries in the Icons list, each entry should be reduced from 2 lines to a single line.

Attachment 9611, "icon list with 2 and 1 line per entry":

Yousuf Philips @philipzae said:

Mate uses 'Controls' as the tab name in its theme customization dialog. http://askcaty.com/wp-content/uploads/2019/03/Mate-Desktop-Controls.png

Yousuf Philips @philipzae said:

'User Interface' might be a good alternative, when looking at the theme docs. https://wiki.xfce.org/howto/install_new_themes#gtk_interfaces

Dmitry uploaded an attachment:

Attachment 9731, "new appearance":

Simon Steinbeiß @ochosi closed a related bug:

*** Bug 16699 has been marked as a duplicate of this bug. ***

added 2. Enhancement label