GitLab

(Bug #16476)

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

The button is shown/hidden based on the availability of gcm-viewer.

The icon-button for the command is used to be consistent with
xfce4-session's add autostart entry dialog.

While this is a rather big commit, at the core it's simply replacing a
misguided call to xfce_randr_new. This led to xfsettingsd asking X for
the default/preferred mode etc. of the connected displays, essentially
resetting all saved settings (i.e. the "Default" profile in xfconf).
The correct approach is to get all necessary display_infos from the xfce
display helper (aka displays.c).

Other, unrelated, changes are the replacement of the completely
unnecessary "buf" variable and correctly freeing the GList
"channel_contents".

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

Unfortunately there is no standard icon for this type of settings dialog
and gnome's icon (preferences-color) has been sort of retired
upstream in favor of a symbolic-only icon.
So we add our own icon name (booh!) and hope icon themes will quickly
pick it up.

The translation wouldn't make sense anyway plus the text in the glade
file is only a placeholder which will be replaced by the code.

This should help with identifying displays in multihead setups. The
numbering is shown in:
 - the display widget
 - the display combobox
 - the identity popups
if there are >1 displays connected.