Critical warning in xfce4-session/sm-layer.c:sm_set_properties()

This happened to me shortly after my session started, and since I run xfce4-session itself with G_DEBUG=fatal-criticals, it caused it to crash and logged me out.

xfsm_client_merge_properties: assertion 'XFSM_IS_CLIENT (client)' failed

Program terminated with signal SIGABRT, Aborted.
#0  0x00007fea6649a11c in ?? () from /opt/bin/../../lib/libc.so.6
[Current thread is 1 (Thread 0x7fea64efbc40 (LWP 741))]
(gdb) bt
#0  0x00007fea6649a11c in ??? () at /opt/bin/../../lib/libc.so.6
#1  0x00007fea6643e5d0 in raise () at /opt/bin/../../lib/libc.so.6
#2  0x00007fea66425685 in abort () at /opt/bin/../../lib/libc.so.6
#3  0x00007fea673800fc in _g_log_abort (breakpoint=breakpoint@entry=1) at ../glib/glib/gmessages.c:454
#4  0x00007fea673cacce in g_logv (log_domain=0x56186315b020 "xfce4-session", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=<optimized out>) at ../glib/glib/gmessages.c:1313
#5  0x00007fea673caf84 in g_log (log_domain=<optimized out>, log_level=<optimized out>, format=<optimized out>) at ../glib/glib/gmessages.c:1355
#6  0x0000561863158811 in sm_set_properties (sms_conn=<optimized out>, client_data=0x56188d4d5a20, num_props=1, props=0x56188d497b30) at ../xfce4-session/sm-layer.c:382
#7  0x00007fea6681dea9 in _SmsProcessMessage (iceConn=0x56188d4d7870, clientData=0x56188d3a3c60, opcode=<optimized out>, length=8, swap=0) at /usr/src/debug/libsm/libSM-1.2.6/src/sm_process.c:929
#8  0x00007fea66834895 in IceProcessMessages (iceConn=0x56188d4d7870, replyWait=replyWait@entry=0x0, replyReadyRet=replyReadyRet@entry=0x0) at /usr/src/debug/libice/libICE-1.1.2/src/process.c:378
#9  0x0000561863157fde in ice_process_messages (channel=<optimized out>, condition=<optimized out>, user_data=0x56188d49f7b0) at ../xfce4-session/ice-layer.c:109
#10 0x00007fea673c375e in g_main_dispatch (context=0x56188d190af0) at ../glib/glib/gmain.c:3734
#11 0x00007fea673ccc50 in g_main_context_dispatch_unlocked (context=0x56188d190af0) at ../glib/glib/gmain.c:4603
#12 g_main_context_iterate_unlocked (context=0x56188d190af0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/glib/gmain.c:4672
#13 0x00007fea673ccf77 in g_main_loop_run (loop=0x56188d33a210) at ../glib/glib/gmain.c:4877
#14 0x00007fea66dfac1f in gtk_main () at ../gtk/gtk/gtkmain.c:1332
#15 0x00005618631449fe in main (argc=<optimized out>, argv=<optimized out>) at ../xfce4-session/main.c:413

@kelnos, this has never happened to me before, so I’m wondering if it might be related to the recent changes you made? (Even though it doesn’t seem obvious at first glance.) Does this ring a bell? Do you think we should attach a GWeakNotify to the client to disconnect the callbacks when it’s disposed, or something like that?


Version: 4.21.2-dev-4fd53d6b

Edited by Gaël Bonithon