xfce4-session issueshttps://gitlab.xfce.org/xfce/xfce4-session/-/issues2023-05-22T15:37:32Zhttps://gitlab.xfce.org/xfce/xfce4-session/-/issues/60xscreensaver desktop file has same name as xfce4-screensaver2023-05-22T15:37:32ZBugzilla Migrationxscreensaver desktop file has same name as xfce4-screensaver## Submitted by Guido Falsi
Assigned to **Xfce Bug Triage**
**[Link to original bug (#15999)](https://bugzilla.xfce.org/show_bug.cgi?id=15999)**
## Description
Hi,
In FreeBSD after updating xfce to 4.14 It has been noticed that x...## Submitted by Guido Falsi
Assigned to **Xfce Bug Triage**
**[Link to original bug (#15999)](https://bugzilla.xfce.org/show_bug.cgi?id=15999)**
## Description
Hi,
In FreeBSD after updating xfce to 4.14 It has been noticed that xfce4-session installs a .desktop startup file for xscreensaver, enabled by default.
At the same time xfce4-screensaver installs it's own .desktop file, also enabled by default.
The two .desktop files happen to have the same exact content in the Name and comment fields. This is problematic because in the Application Autostart interface of the Session and Startup configuration tool the two entries appear identical and cannot be distinguished.
Another issue is that if both are installed, being both enabled by default, they end up conflicting. This can manifest it when the screen is locked as one of the two screensavers showing it's unlock UI while the other grabs the keyboard, preventing the user from properly unlocking the screen.
This has been reported in FreeBSD in these bug reports:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240804
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240810
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240811
In the FreeBSD ports we have a metaport (that is a port which installs nothing, but depends on other ports to force their installation) for xfce which by default also installs xfce4-screensaver. Due to this I have implemented two workarounds:
- Install the xscreensaver.desktop file with the line Hidden=true which disables it
- Change the Name field of xfce4-screensaver, so the lines can be distinguished in the Application Autostart UI
I'm attaching a patch including the first change and also changes the .desktop file name field. I have already filed a bug report for xfce4-screensaver with a similar change.
I understand that switching to disabled by default could not be the best choice for you. I also think a better name and description can be chosen.
I'm attaching the patch as an example of what can be done, and to start discussion.
Version: 4.14.0
### See also
* https://bugzilla.xfce.org/show_bug.cgi?id=15991
* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240804
* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240810
* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=2408114.19.1Gaël BonithonGaël Bonithonhttps://gitlab.xfce.org/xfce/xfce4-session/-/issues/151xfsm-shutdown-fallback.c doesn't compile on Solaris2023-05-22T14:32:43Zrorthxfsm-shutdown-fallback.c doesn't compile on SolarisWhen trying to compile `xfce-4.18pre1` on Solaris 11.4/amd64, there was a single compile failure in `xfce-session-4.17.1`:
```
/vol/xfce/src/xfce-4.18/xfce4-session-4.17.1/xfce4-session/xfsm-shutdown-fallback.c: In function ‘xfsm_shutdow...When trying to compile `xfce-4.18pre1` on Solaris 11.4/amd64, there was a single compile failure in `xfce-session-4.17.1`:
```
/vol/xfce/src/xfce-4.18/xfce4-session-4.17.1/xfce4-session/xfsm-shutdown-fallback.c: In function ‘xfsm_shutdown_fallback_try_action’:
/vol/xfce/src/xfce-4.18/xfce4-session-4.17.1/xfce4-session/xfsm-shutdown-fallback.c:395:13: error: ‘UP_BACKEND_SUSPEND_COMMAND’ undeclared (first use in this function)
395 | cmd = UP_BACKEND_SUSPEND_COMMAND;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
/vol/xfce/src/xfce-4.18/xfce4-session-4.17.1/xfce4-session/xfsm-shutdown-fallback.c:395:13: note: each undeclared identifier is reported only once for each function it appears in
/vol/xfce/src/xfce-4.18/xfce4-session-4.17.1/xfce4-session/xfsm-shutdown-fallback.c:402:13: error: ‘UP_BACKEND_HIBERNATE_COMMAND’ undeclared (first use in this function)
402 | cmd = UP_BACKEND_HIBERNATE_COMMAND;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
which is no wonder since there's no Solaris support for `UP_BACKEND_*_COMMAND` yet, neither there's support for systems that lack suspend/hibernate functionality.
This issue has existed for a long time, and equally long have I been carrying a patch around to fix this, which introduces support for a `--with-backend=solaris` option.[xfce4-session-4.17.1.patch](/uploads/c5cc6e4db4275957aa31e7524be6d9b4/xfce4-session-4.17.1.patch)4.18.3Gaël BonithonGaël Bonithonhttps://gitlab.xfce.org/xfce/xfce4-session/-/issues/147Blank screen while starting Xorg session from startxfce4 w/ argument :DISPLAY...2023-05-18T15:46:37ZcyrantBlank screen while starting Xorg session from startxfce4 w/ argument :DISPLAY > 0# How to reproduce.
0. System: Arch Linux 5.19.13, xorg-xinit 1.4.1, xfce4-session 4.16.0
1. Remove a Display Manager.
2. Remove a `~/.xinitrc` and `~/.xserverrc`.
3. Run `exec startxfce4 -- :1` on VT console login.
# Solution.
The wr...# How to reproduce.
0. System: Arch Linux 5.19.13, xorg-xinit 1.4.1, xfce4-session 4.16.0
1. Remove a Display Manager.
2. Remove a `~/.xinitrc` and `~/.xserverrc`.
3. Run `exec startxfce4 -- :1` on VT console login.
# Solution.
The wrong order for `xinit` arguments in `scripts/startxfce4.in`:
`SERVERRC="vt$XDG_VTNR $SERVERRC"` **must be** `SERVERRC="$SERVERRC vt$XDG_VTNR"`
Because of, `SERVERRC` may contain DISPLAY argument, and [xinit](https://gitlab.freedesktop.org/xorg/app/xinit/-/blob/master/xinit.c) requires this one in very strict position:
> xinit [ [ client ] options ... ] [ -- [ server ] [ display ] options ... ]4.18.3Gaël BonithonGaël Bonithonhttps://gitlab.xfce.org/xfce/xfce4-session/-/issues/97Logout window focusses "Cancel" by default AND/OR add reaction time delay for...2023-05-08T18:46:40ZBugzilla MigrationLogout window focusses "Cancel" by default AND/OR add reaction time delay for usage## Submitted by DarkTrick
Assigned to **Alexander Schwinn `@alexxcons`**
**[Link to original bug (#15158)](https://bugzilla.xfce.org/show_bug.cgi?id=15158)**
## Description
### Suggestion
Logout window ( xfce4-session-logout ) foc...## Submitted by DarkTrick
Assigned to **Alexander Schwinn `@alexxcons`**
**[Link to original bug (#15158)](https://bugzilla.xfce.org/show_bug.cgi?id=15158)**
## Description
### Suggestion
Logout window ( xfce4-session-logout ) focusses "Cancel"-button by default.
OR
Add reaction time delay for window usage.
### Current behaviour
When logout window appears "Logout" button is focussed by default. All buttons can be pressed / used immediately.
### Reason for Suggestion
Logout window might be triggered automatically. This happens on battery using devices when battery is too low.
If this happens while writing text where the space bar is in heavy usage, the system will log the user out against the actual will of the user.
In rare cases the user might want to click somewhere right in the moment, when the xfce4-session-logout screen pops up, he/she might accidentally click one of the buttons inside the logout window.
Version: githttps://gitlab.xfce.org/xfce/xfce4-session/-/issues/15Suspend + lock screen works a bit insecure2023-05-07T15:04:52ZBugzilla MigrationSuspend + lock screen works a bit insecure## Submitted by siu..@..il.com
Assigned to **Xfce Bug Triage**
**[Link to original bug (#10089)](https://bugzilla.xfce.org/show_bug.cgi?id=10089)**
## Description
Running XFCE on Xubuntu 13.04 and noticed that suspend + lock scree...## Submitted by siu..@..il.com
Assigned to **Xfce Bug Triage**
**[Link to original bug (#10089)](https://bugzilla.xfce.org/show_bug.cgi?id=10089)**
## Description
Running XFCE on Xubuntu 13.04 and noticed that suspend + lock screen doesn't always work as expected. When I'm suspending the system and the option "Lock screen when going for suspend/hibernate" is used, the system seeems to suspend normally. However, when waking up the system yet again, I see a short glance of the desktop that was on when suspending. Only after that I get the lock screen password prompt. This happens randomly, not always.
Version: 4.10.0https://gitlab.xfce.org/xfce/xfce4-session/-/issues/54crash in xfsm_manager_get_shutdown_type2023-04-28T21:01:46ZBugzilla Migrationcrash in xfsm_manager_get_shutdown_type## Submitted by O H `@olh`
Assigned to **Xfce Bug Triage**
**[Link to original bug (#15404)](https://bugzilla.xfce.org/show_bug.cgi?id=15404)**
## Description
xfce4-session-20190509T183109.1c49c2cd
Unclear what I did. I think it...## Submitted by O H `@olh`
Assigned to **Xfce Bug Triage**
**[Link to original bug (#15404)](https://bugzilla.xfce.org/show_bug.cgi?id=15404)**
## Description
xfce4-session-20190509T183109.1c49c2cd
Unclear what I did. I think it was an accidental "switch user" instead of "lock screen", the icons are just too close together. From the timestamps it was apparently the relogin or whatever happens if one comes back from sddm.
Core was generated by `xfce4-session'.
Program terminated with signal SIGSEGV, Segmentation fault.
```
#0 xfsm_manager_get_shutdown_type (manager=0x0) at xfsm-manager.c:1942
1942 return manager->shutdown_type;
[Current thread is 1 (Thread 0x7f86e6791a80 (LWP 27467))]
(gdb) bt
#0 xfsm_manager_get_shutdown_type (manager=0x0) at xfsm-manager.c:1942
#1 name_lost (connection=<optimized out>, name=<optimized out>, user_data=0x0) at main.c:228
#2 do_call (client=0x5644d61d5c40, call_type=CALL_TYPE_NAME_LOST) at gdbusnameowning.c:215
#3 request_name_cb (source_object=<optimized out>, res=<optimized out>, user_data=0x5644d61d5c40) at gdbusnameowning.c:341
#4 g_task_return_now (task=0x5644d6130200 [GTask]) at gtask.c:1145
#5 g_task_return (task=0x5644d6130200 [GTask], type=<optimized out>) at gtask.c:1203
#6 g_dbus_connection_call_done (source=<optimized out>, result=0x5644d6130130, user_data=0x5644d6130200) at gdbusconnection.c:5722
#7 g_task_return_now (task=0x5644d6130130 [GTask]) at gtask.c:1145
#8 complete_in_idle_cb (task=task@entry=0x5644d6130130) at gtask.c:1159
#9 g_idle_dispatch (source=0x7f86c800fbb0, callback=0x7f86e38be210 <complete_in_idle_cb>, user_data=0x5644d6130130) at gmain.c:5486
#10 g_main_dispatch (context=0x5644d60f35e0) at gmain.c:3142
#11 g_main_context_dispatch (context=context@entry=0x5644d60f35e0) at gmain.c:3795
#12 g_main_context_iterate (context=0x5644d60f35e0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3868
#13 g_main_loop_run (loop=0x5644d621f750) at gmain.c:4064
#14 gtk_main () at gtkmain.c:1323
#15 main (argc=<optimized out>, argv=<optimized out>) at main.c:363
```
so for some reason user_data==NULL is not handled. Not sure if that is supposed to happen, and the bug is elsewhere.
Version: Unspecified4.18.1Gaël BonithonGaël Bonithonhttps://gitlab.xfce.org/xfce/xfce4-session/-/issues/37[PATCH] suspend/hibernate (sleep) for darwin2023-04-26T11:33:50ZBugzilla Migration[PATCH] suspend/hibernate (sleep) for darwin## Submitted by Anders F Björklund
Assigned to **Xfce Bug Triage**
**[Link to original bug (#12387)](https://bugzilla.xfce.org/show_bug.cgi?id=12387)**
## Description
Created attachment 6574
pmset sleepnow
Quick and dirty variant...## Submitted by Anders F Björklund
Assigned to **Xfce Bug Triage**
**[Link to original bug (#12387)](https://bugzilla.xfce.org/show_bug.cgi?id=12387)**
## Description
Created attachment 6574
pmset sleepnow
Quick and dirty variant for suspend/hibernate support, using sleep.
Don't bother changing the defaults, so map both of them to "sleep".
Let the defaults/user decide, whether to suspend to memory or disk
(default on laptops is to write to disk but keep the memory powered)
**Attachment 6574**, "pmset sleepnow":
[xfce4-session-4.12.0-sleep.patch](/uploads/6416b9bf8e5162821f38b0d249239fda/xfce4-session-4.12.0-sleep.patch)
Version: 4.12.0https://gitlab.xfce.org/xfce/xfce4-session/-/issues/111[PATCH] Avoid duplicating directories in the tail of $XDG_* envs2023-02-06T15:40:20Zmikhailnov[PATCH] Avoid duplicating directories in the tail of $XDG_* envsExample input: `XDG_CONFIG_DIRS="/etc/xdg/rosa-xfce-config:/etc/xdg"`
Output before this patch: `XDG_CONFIG_DIRS="/etc/xdg/rosa-xfce-config:/etc/xdg:/etc/xdg"`
But there is no need to duplicate `/etc/xdg` in the tail.
Output after thi...Example input: `XDG_CONFIG_DIRS="/etc/xdg/rosa-xfce-config:/etc/xdg"`
Output before this patch: `XDG_CONFIG_DIRS="/etc/xdg/rosa-xfce-config:/etc/xdg:/etc/xdg"`
But there is no need to duplicate `/etc/xdg` in the tail.
Output after this patch: `XDG_CONFIG_DIRS="/etc/xdg/rosa-xfce-config:/etc/xdg"`
The scripts that sets XDG_CONFIG_DIRS: https://abf.io/soft/rosa-xfce-config/blob/04b69c389d/profile.d/10-rosa-xfce-config-xdg.sh
Tests for that script: https://abf.io/soft/rosa-xfce-config/blob/04b69c389d/profile.d/test_10-rosa-xfce-config-xdg.sh
I do not see why that my script must not append "/etc/xdg", so fixing startxfce4.
This case-esac code is compatible with POSIX shell (https://stackoverflow.com/a/2830416), but tested it only with bash.
Diff is bellow, `git am`-able patch is attached.
[0001-Avoid-duplicating-directories-in-the-tail-of-XDG_-en.patch](/uploads/0bc30b33b3dcd9b7387cec7d1fb77beb/0001-Avoid-duplicating-directories-in-the-tail-of-XDG_-en.patch)
```diff
diff --git a/scripts/startxfce4.in b/scripts/startxfce4.in
index bf3201b6..b20a9cf4 100644
--- a/scripts/startxfce4.in
+++ b/scripts/startxfce4.in
@@ -72,7 +72,11 @@ then
XDG_DATA_DIRS="@_datadir_@:/usr/local/share:/usr/share"
fi
else
- XDG_DATA_DIRS="$XDG_DATA_DIRS:@_datadir_@"
+ # avoid duplicating @_datadir_@ if $XDG_DATA_DIRS already contains it
+ case "$XDG_DATA_DIRS" in
+ *:@_datadir_@ | @_datadir_@ ) : ;;
+ * ) XDG_DATA_DIRS="$XDG_DATA_DIRS:@_datadir_@" ;;
+ esac
fi
export XDG_DATA_DIRS
@@ -84,7 +88,11 @@ then
XDG_CONFIG_DIRS="/etc/xdg:@_sysconfdir_@/xdg"
fi
else
- XDG_CONFIG_DIRS="$XDG_CONFIG_DIRS:@_sysconfdir_@/xdg"
+ # avoid duplicating @_sysconfdir_@/xdg if $XDG_CONFIG_DIRS already contains it
+ case "$XDG_CONFIG_DIRS" in
+ *:@_sysconfdir_@/xdg | @_sysconfdir_@/xdg ) : ;;
+ * ) XDG_CONFIG_DIRS="$XDG_CONFIG_DIRS:@_sysconfdir_@/xdg" ;;
+ esac
fi
export XDG_CONFIG_DIRS
```4.18.1mikhailnovmikhailnovhttps://gitlab.xfce.org/xfce/xfce4-session/-/issues/50"/usr/share" appears two times in XDG_DATA_DIRS; "/etc/xdg" appears two times...2023-02-06T15:26:28ZBugzilla Migration"/usr/share" appears two times in XDG_DATA_DIRS; "/etc/xdg" appears two times in XDG_CONFIG_DIRS.## Submitted by ngh..@..box.eu
Assigned to **Xfce Bug Triage**
**[Link to original bug (#14546)](https://bugzilla.xfce.org/show_bug.cgi?id=14546)**
## Description
$ uname -a
Linux xx 4.15.0-23-generic #25-Ubuntu SMP Wed May 23 18:...## Submitted by ngh..@..box.eu
Assigned to **Xfce Bug Triage**
**[Link to original bug (#14546)](https://bugzilla.xfce.org/show_bug.cgi?id=14546)**
## Description
$ uname -a
Linux xx 4.15.0-23-generic #25-Ubuntu SMP Wed May 23 18:02:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
```sh
$ echo $XDG_DATA_DIRS |tr : '\n'
/usr/share/xubuntu
/usr/share/xfce4
/usr/local/share
/usr/share
/var/lib/snapd/desktop
/usr/share <<<<< SECOND TIME
```
```sh
$ echo $XDG_CONFIG_DIRS |tr : '\n'
/etc/xdg/xdg-xubuntu
/etc/xdg
/etc/xdg <<<<< SECOND TIME
```
I have tried to repair startxfce4:
```diff
$ diff -u /usr/bin/startxfce4 ~/temp/startxfce4
--- /usr/bin/startxfce4 2018-07-20 19:07:26.000000000 +0200
+++ /home/x/temp/startxfce4 2018-07-20 19:12:33.000000000 +0200
@@ -64,28 +64,12 @@
BASEDIR="$XDG_CONFIG_HOME/xfce4"
fi
-if test "x$XDG_DATA_DIRS" = "x"
-then
- if test "x/usr/share" = "x/usr/local/share" -o "x/usr/share" = "x/usr/share"; then
- XDG_DATA_DIRS="/usr/local/share:/usr/share"
- else
- XDG_DATA_DIRS="/usr/share:/usr/local/share:/usr/share"
- fi
-else
- XDG_DATA_DIRS="$XDG_DATA_DIRS:/usr/share"
-fi
+test -z "$XDG_DATA_DIRS" && XDG_DATA_DIRS=/usr/local/share:/usr/share
+x=":$XDG_DATA_DIRS:" && test "${x##*:/usr/share:*}" && XDG_DATA_DIRS="$XDG_DATA_DIRS:/usr/share"
export XDG_DATA_DIRS
-if test "x$XDG_CONFIG_DIRS" = "x"
-then
- if test "x/etc" = "x/etc"; then
- XDG_CONFIG_DIRS="/etc/xdg"
- else
- XDG_CONFIG_DIRS="/etc/xdg:/etc/xdg"
- fi
-else
- XDG_CONFIG_DIRS="$XDG_CONFIG_DIRS:/etc/xdg"
-fi
+test -z "$XDG_CONFIG_DIRS" && XDG_CONFIG_DIRS="/etc/xdg"
+x=":$XDG_CONFIG_DIRS:" && test "${x##*:/etc/xdg:*}" && XDG_CONFIG_DIRS="$XDG_CONFIG_DIRS:/etc/xdg"
export XDG_CONFIG_DIRS
if test "x$DISPLAY" = "x"
```
`$ sudo cp ~/temp/startxfce4 /usr/bin/startxfce4`
--rebooting--
O.K.:
```sh
$ echo $XDG_DATA_DIRS |tr : '\n'
/usr/share/xubuntu
/usr/share/xfce4
/usr/local/share
/usr/share
/var/lib/snapd/desktop
$ echo $XDG_CONFIG_DIRS |tr : '\n'
/etc/xdg/xdg-xubuntu
/etc/xdg
```
Version: Unspecifiedhttps://gitlab.xfce.org/xfce/xfce4-session/-/issues/17Xflock4 doesn't know about proper lockers2023-01-27T18:51:10ZBugzilla MigrationXflock4 doesn't know about proper lockers## Submitted by sor..@..owr.ru
Assigned to **Steve Dodier-Lazaro**
**[Link to original bug (#10217)](https://bugzilla.xfce.org/show_bug.cgi?id=10217)**
## Description
Created attachment 5088
Removes gnome-screensaver, adds mate-sc...## Submitted by sor..@..owr.ru
Assigned to **Steve Dodier-Lazaro**
**[Link to original bug (#10217)](https://bugzilla.xfce.org/show_bug.cgi?id=10217)**
## Description
Created attachment 5088
Removes gnome-screensaver, adds mate-screensaver, cinnamon-screensaver, i3lock
Xflock4 knows about gnome-screensaver which is dead after GNOME 3.8 but doesn't about forks: mate-screensaver and cinnamon-screensaver.
**Patch 5088**, "Removes gnome-screensaver, adds mate-screensaver, cinnamon-screensaver, i3lock":
[xflock4-lockers-update.patch](/uploads/902a79976682792a8e4c4aee4f1dee92/xflock4-lockers-update.patch)
Version: 4.12.0
### See also
* https://bugzilla.xfce.org/show_bug.cgi?id=8993Jarno SuniJarno Sunihttps://gitlab.xfce.org/xfce/xfce4-session/-/issues/134Potential null deref (crash) in xfsm-shutdown-fallback.c:2512022-05-17T19:56:08ZLandry BreuilPotential null deref (crash) in xfsm-shutdown-fallback.c:251Found by a user testing upcoming OpenBSD 7.1 release, with a new user and a botched /etc/groups file (eg no group matching the user gid).
```
Core was generated by `xfce4-session'.
Program terminated with signal SIGSEGV, Segmentation fa...Found by a user testing upcoming OpenBSD 7.1 release, with a new user and a botched /etc/groups file (eg no group matching the user gid).
```
Core was generated by `xfce4-session'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 xfsm_shutdown_fallback_user_is_operator () at xfsm-shutdown-fallback.c:251
251 xfsm-shutdown-fallback.c: No such file or directory.
[Current thread is 1 (process 538027)]
(gdb) bt
#0 xfsm_shutdown_fallback_user_is_operator () at xfsm-shutdown-fallback.c:251
#1 xfsm_shutdown_fallback_bsd_check_auth (shutdown_type=<optimized out>) at xfsm-shutdown-fallback.c:275
#2 0x000002bf12db942c in xfsm_shutdown_fallback_auth_shutdown () at xfsm-shutdown-fallback.c:522
#3 0x000002bf12dba31b in xfsm_shutdown_can_shutdown (shutdown=0x2c1e6e7cd60, can_shutdown=0x7f7fffff5d2c, error=<optimized out>) at xfsm-shutdown.c:459
#4 0x000002bf12db5fc4 in xfsm_manager_dbus_can_shutdown (object=0x2c1f9bf8290, invocation=0x2c1c23d52d0) at xfsm-manager.c:2360
#5 0x000002c1c1325fbd in ffi_call_unix64 () from /usr/local/lib/libffi.so.1.2
#6 0x000002c1c1325352 in ffi_call_int () from /usr/local/lib/libffi.so.1.2
#7 0x000002c174ed72e5 in g_cclosure_marshal_generic (closure=<optimized out>, return_gvalue=0x7f7fffff5fc0, n_param_values=<optimized out>, param_values=<optimized out>,
invocation_hint=<optimized out>, marshal_data=0x2bf12db5f10 <xfsm_manager_dbus_can_shutdown>) at ../glib-2.70.5/gobject/gclosure.c:1534
#8 0x000002c174ed63e5 in g_closure_invoke (closure=0x2c17248d620, return_value=0x7f7fffff5fc0, n_param_values=<optimized out>, param_values=0x2c16ba91440, invocation_hint=<optimized out>)
at ../glib-2.70.5/gobject/gclosure.c:830
#9 0x000002c174eef308 in signal_emit_unlocked_R (node=<optimized out>, detail=0, instance=<optimized out>, emission_return=0x7f7fffff61c0, instance_and_params=0x2c16ba91440)
at ../glib-2.70.5/gobject/gsignal.c:3781
#10 0x000002c174eeea39 in g_signal_emitv (instance_and_params=0x2c16ba91440, signal_id=<optimized out>, detail=3850508617, return_value=0x7f7fffff61c0)
at ../glib-2.70.5/gobject/gsignal.c:3227
#11 0x000002bf12da75be in _xfsm_dbus_manager_skeleton_handle_method_call (connection=<optimized out>, sender=<optimized out>, object_path=<optimized out>,
interface_name=0x2c1a8a2e6c0 "org.xfce.Session.Manager", method_name=0x2c1902f4e00 "CanShutdown", parameters=<optimized out>, invocation=0x2c1c23d52d0, user_data=0x2c1f9bf8290)
at xfsm-manager-dbus.c:3982
#12 0x000002c21028878f in g_dbus_interface_method_dispatch_helper (interface=<optimized out>, method_call_func=0x325c8c716db890e7, invocation=0x2c1c23d52d0)
at ../glib-2.70.5/gio/gdbusinterfaceskeleton.c:613
#13 0x000002c21026b873 in call_in_idle_cb (user_data=<optimized out>) at ../glib-2.70.5/gio/gdbusconnection.c:5010
#14 0x000002c1e4a6c91f in g_main_dispatch (context=<optimized out>) at ../glib-2.70.5/glib/gmain.c:3381
#15 g_main_context_dispatch (context=<optimized out>) at ../glib-2.70.5/glib/gmain.c:4099
#16 0x000002c1e4a6ccda in g_main_context_iterate (context=<optimized out>, block=<optimized out>, dispatch=1, self=<optimized out>) at ../glib-2.70.5/glib/gmain.c:4175
#17 0x000002c1e4a6d11a in g_main_loop_run (loop=0x2c17d8dea80) at ../glib-2.70.5/glib/gmain.c:4373
#18 0x000002c1fff16ae8 in gtk_main () from /usr/local/lib/libgtk-3.so.2201.0
#19 0x000002bf12da87be in main (argc=1, argv=0x7f7fffff6508) at main.c:358
```
the return value for `getgrgid` isnt checked before accessing it in https://gitlab.xfce.org/xfce/xfce4-session/-/blob/master/xfce4-session/xfsm-shutdown-fallback.c#L250, added in bugzilla bug #14722
patch below (if someone is faster than me at doing a PR):
```
struct group *gr;
gr = getgrgid (groups[i]);
- if (strncmp(gr->gr_name, "operator", 8) == 0)
+ if (gr != NULL && strncmp(gr->gr_name, "operator", 8) == 0)
{
is_operator = TRUE;
break;
```https://gitlab.xfce.org/xfce/xfce4-session/-/issues/29xflock4 does not turn off screen due to lack of sleep2022-03-05T18:59:46ZBugzilla Migrationxflock4 does not turn off screen due to lack of sleep## Submitted by Chris Bainbridge
Assigned to **Simon Steinbeiß `@ochosi`**
**[Link to original bug (#11491)](https://bugzilla.xfce.org/show_bug.cgi?id=11491)**
## Description
As noted at http://www.shallowsky.com/linux/x-screen-bl...## Submitted by Chris Bainbridge
Assigned to **Simon Steinbeiß `@ochosi`**
**[Link to original bug (#11491)](https://bugzilla.xfce.org/show_bug.cgi?id=11491)**
## Description
As noted at http://www.shallowsky.com/linux/x-screen-blanking.html calls to "xset dpms" need to be prefixed with "sleep 1":
will blank the screen (or activate the screensaver program, if you're using
one) after a delay of one second. You need the delay because X gets a little
confused about the order of events; it will blank the screen but immediate
un-blank it, thinking the activity of your typing the command happened
recently enough to come out of screensaver mode.
sleep 1; xset dpms force off
will turn the screen OFF after a delay of one second. You can also use
standby, suspend, or on instead of off.
Downstream bug report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776674
Version: 4.10.1Simon SteinbeißSimon Steinbeiß