How to reproduce:
Expected result:
Actual result:
Note that the setting xfce4-session "SaveOnExit" is correctly set to "Boolean" and empty.
Check on Manjaro, Xfce 4.16.
Gaël Bonithon (da19807f) at 29 Mar 07:10
logout-dialog: Remove save session checkbox
It seems that the purpose of this SaveOnExit checkbox was to offer on-demand saving (in which case it should have been volatile, with no xfconf setting, and unchecked by default). As for AutoSave, it actually means AlwaysSave. And so, rather than adding ShowSave, it might have been better to change the AutoSave checkbox into a "Never, On-demand, Always" combo box, showing the logout dialog chekbox for On-demand only.
All in all, I find the whole thing rather complicated and overkill. Let's keep it simple, since that's the consensus: a single boolean setting (SaveOnExit), no more checkbox in the logout dialog.
Thank you all for your prompt replies ;)
It's also just kinda confusing how these settings interact with each other. It took a reading of the code for me to figure out, and even then I still wasn't immediately sure.
So +1 to removing the checkbox from the logout dialog entirely (so ShowSave
goes away too?). Then I guess AutoSave
and SaveOnExit
are the same thing? I would opt to get rid of AutoSave
and make SaveOnExit
determine what happens, since it's more descriptive.
Personally I always want my session saved, and I actually have a script that runs every 5 minutes to poke the DBus interface to save it, just in case my system crashes or something. Main thing I like is when I reboot, I want my terminal instances to all show up again, in the same directories they were before, on the right workspaces.
Actually AutoSave
to me sounds like it should do what I've implemented manually -- auto save the session periodically, heh.
(I do worry that if we remove the checkbox entirely, some people might complain.)
+1 ... let's remove the checkbox from the logout dialog and the ShowSave
setting ... should be sufficient to toggle the setting in the preferences.
I as well have it disabled, since at least in the past it was a known source of corrupt sessions. So if that is still a problem, I suppose having it disabled by default is a good idea.
If automatic session saving is desired, I suppose the user always wants both, "autoSave" (is that saving in periodic intervals?) and save on logout ... so both could be merged from my pov.
Maybe you already know, some time ago (commit)
ShowSave
was introduced exactly to allowing hiding that checkbox in logout dialog.
Phew, I guess I must have seen that at one time or another, but I couldn't remember. I think we'd benefit from getting rid of it all frankly.
Hi, I never needed saved sessions, to me it's kind of annoying when it saves and restores one, here I have both AutoSave
and SaveOnExit
set to FALSE
, but sessions are still saved when I logout via optimus-manager to toggle gpus.
Maybe you already know, some time ago (commit) ShowSave
was introduced exactly to allowing hiding that checkbox in logout dialog.
All in all, I'm ok with your idea of having just one setting, disabled by default. Optionally, we could also drop ShowSave
and the checkbox in logout dialog all together, users that need this feature can enable it in Session and Startup.
@alexxcons @andreldm @kelnos I'd like to get some opinions here, as I don't usually use session backup. What do you think about removing the /general/SaveOnExit
setting? I don't quite see the point of having this in addition to /general/AutoSave
, which is the only one to appear in the settings dialog, making /general/SaveOnExit
a more or less hidden setting (what's more, set to TRUE
by default).
Personally, I'd be in favor of simply removing the checkbox from the logout dialog. But we could also bind it to /general/AutoSave
for convenience (with immediate application of changes, unlike now where the change only applies if you actually leave the session).
Thanks, I will report about this there.
So that would be the Xorg_syslog_stacktrace you've already attached, looking at htat backtrace, that seems to be a bug in the Radeon driver, not Xorg itself.
The core files are useless for us, as we may not be using the same distribution as you, what's more interesting is the actual backtrace from these corefiles.
Please note that if Xorg crashes, then it's a bug in Xorg that should be reported in https://gitlab.freedesktop.org/xorg/xserver/-/issues/, X11 clients should not be able to crash the Xsever.
Hello. Utility xfce4-session-logout crash the xfce4-session when running in from start menu (or without arguments from terminal emulator). Logout window don't show - all running programs closes without prompting.
Bug occurs with all tested versions:
Attached xfce4-session 4.19.1-1 in GDB
(gdb) break xfsm-fadeout.c:138
Breakpoint 1 at 0x5631726dfa78: file ./xfce4-session/xfsm-fadeout.c, line 138.
(gdb) continue
Continuing.
Thread 1 "xfce4-session" hit Breakpoint 1, xfsm_x11_fadeout_new_window (
screen=<optimized out>, display=0x56317272a6f0)
at ./xfce4-session/xfsm-fadeout.c:138
138 gdk_display_flush (display);
(gdb) bt
#0 xfsm_x11_fadeout_new_window (screen=<optimized out>, display=0x55bebfd8a6f0)
at ./xfce4-session/xfsm-fadeout.c:138
#1 xfsm_fadeout_new (display=0x55bebfd8a6f0)
at ./xfce4-session/xfsm-fadeout.c:158
#2 0x000055bebf044b3d in xfsm_logout_dialog (
session_name=0x55bebfe0e880 "Default",
return_type=return_type@entry=0x55bebfdfd77c,
return_save_session=return_save_session@entry=0x7ffe11ad3b7c,
accessibility=<optimized out>) at ./xfce4-session/xfsm-logout-dialog.c:789
#3 0x000055bebf046451 in xfsm_manager_save_yourself_global (
manager=0x55bebfdfd750, save_type=save_type@entry=2,
shutdown=shutdown@entry=1, interact_style=interact_style@entry=2,
fast=fast@entry=0, shutdown_type=XFSM_SHUTDOWN_ASK, allow_shutdown_save=1)
at ./xfce4-session/xfsm-manager.c:1234
#4 0x000055bebf0465d9 in xfsm_manager_dbus_shutdown_idled (
data=<optimized out>) at ./xfce4-session/xfsm-manager.c:2278
#5 0x00007f1bbcb600d9 in g_main_dispatch (context=context@entry=0x55bebfda9680)
at ../../../glib/gmain.c:3476
#6 0x00007f1bbcb63317 in g_main_context_dispatch_unlocked (
context=0x55bebfda9680) at ../../../glib/gmain.c:4284
#7 g_main_context_iterate_unlocked (context=0x55bebfda9680,
block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>)
at ../../../glib/gmain.c:4349
#8 0x00007f1bbcb63c1f in g_main_loop_run (loop=loop@entry=0x55bebfdf9810)
at ../../../glib/gmain.c:4551
#9 0x00007f1bbd3ca65d in gtk_main () at ../../../gtk/gtkmain.c:1329
#10 0x000055bebf037472 in main (argc=<optimized out>, argv=<optimized out>)
at ./xfce4-session/main.c:368
After call gdk_display_flush (display) in ./xfce4-session/xfsm-fadeout.c:138 Xorg crashes.
From file .xfce4-session.verbose-log before crash:
TRACE[xfsm-manager.c:2317] xfsm_manager_dbus_logout(): entering
TRACE[xfsm-manager.c:1226] xfsm_manager_save_yourself_global(): entering
Attachments:
Or rather do this:
xfconf-query -c xfce4-session -p /general/SaveOnExit -s false
because the change made in the logout dialog doesn't apply immediately, you have to quit the session for it to apply. That's really not great...
You have to unchek the checkbox in the logout dialog too, it's a bit silly.
I saved a session once, and decided I didn't want a saved session. In Session & Startup, I unchecked save session on logout and deleted all sessions. XFCE continues autosaving the session on logout, and auto-starting it on login.
I know I can hack ~/.cache/sessions/ to be read-only, but that is a workaround. I might want to save a session in the future, so this is not a solution.
BTW, I found that after deleting all sessions, ~/.cache/sessions/ still existed and contained a thumbnails folder. Doing rm -rf ~/.cache/sessions got rid of it, and now it doesn't load. But a manual step mucking around on the command line should not be required. And how was it loading a session from thumbnails? I didn't look inside the thumbnails folder before deleting it so can't offer any more insight on this odd behavior.
I saved a session once, and decided I didn't want a saved session. In Session & Startup, I unchecked save session on logout and deleted all sessions. XFCE continues autosaving the session on logout, and auto-starting it on login.
I know I can hack ~/.cache/sessions/ to be read-only, but that is a workaround. I might want to save a session in the future, so this is not a solution.
BTW, I found that after deleting all sessions, ~/.cache/sessions/ still existed and contained a thumbnails folder. Doing rm -rf ~/.cache/sessions got rid of it, and now it doesn't load. But a manual step mucking around on the command line should not be required. And how was it loading a session from thumbnails? I didn't look inside the thumbnails folder before deleting it so can't offer any more insight on this odd behavior.
GitBot (5ff1303f) at 25 Mar 11:48
I18n: Update translation pt_BR (100%).
this error occurs in kali nethunter and termux proot
device: Xiaomi 11 lite 5G NE (Lisa)
ROM: PixelOS 14 Feburary OFFICAL
kernel: 5.4.242-Hentail_kernel-9b433a4c (With NetHunter support)
NetHunter: 2024.1 Lite (installed with Magisk)
log:
┌──(root㉿kali)-[~]
└─# startxfce4
/usr/bin/startxfce4: X server already running on display :1
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.150: Failed to spawn ssh-agent: Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.152: failed to call dbus-update-activation-environment. Output was (null), error was Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.157: Failed to spawn gpg-agent: Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.166: Unable to launch "xfwm4": Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.168: Unable to launch "xfsettingsd": Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.170: Unable to launch "xfce4-panel": Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.172: Unable to launch "Thunar": Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.174: Unable to launch "xfdesktop": Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.184: Unable to launch "xcape -e 'Super_L=Control_L|Escape'" (specified by autostart/xcape-super-key-bind.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.187: Unable to launch "/usr/share/xscreensaver/xscreensaver-wrapper.sh -no-splash" (specified by autostart/xscreensaver.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.191: Unable to launch "xset b off" (specified by autostart/xfce-disable-motherboard-beep.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.194: Unable to launch "xdg-user-dirs-update" (specified by autostart/xdg-user-dirs.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.196: Unable to launch "/usr/libexec/polkit-mate-authentication-agent-1" (specified by autostart/polkit-mate-authentication-agent-1.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.200: Unable to launch "light-locker" (specified by autostart/light-locker.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.202: Unable to launch "/usr/share/kali-defaults/setup-noautomount" (specified by autostart/kali-noautomount.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.206: Unable to launch "xdg-user-dirs-gtk-update" (specified by autostart/user-dirs-update-gtk.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.210: Unable to launch "nm-applet" (specified by autostart/nm-applet.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.214: Unable to launch "/usr/lib/policykit-1-gnome/polkit-gnome-authentication-agent-1" (specified by autostart/polkit-gnome-authentication-agent-1.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.218: Unable to launch "xfsettingsd" (specified by autostart/xfsettingsd.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.222: Unable to launch "/usr/bin/pkcs11-register" (specified by autostart/pkcs11-register.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.225: Unable to launch "xiccd" (specified by autostart/xiccd.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.229: Unable to launch "xdg-user-dirs-update" (specified by autostart/xdg-user-dirs-kde.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.234: Unable to launch "start-pulseaudio-x11" (specified by autostart/pulseaudio.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.239: Unable to launch "blueman-applet" (specified by autostart/blueman.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.243: Unable to launch "/bin/sh -c "cp -rnT /etc/skel/ ~"" (specified by autostart/kali-sync-skel.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.256: Unable to launch "/usr/libexec/evolution-data-server/evolution-alarm-notify" (specified by autostart/org.gnome.Evolution-alarm-notify.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.264: Unable to launch "/usr/libexec/tracker-miner-fs-3" (specified by autostart/tracker-miner-fs-3.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.269: Unable to launch "sh -c 'IM_CONFIG_CHECK_ENV=1 im-launch true'" (specified by autostart/im-launch.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.277: Unable to launch "system-config-printer-applet" (specified by autostart/print-applet.desktop): Failed to close file descriptor for child process (Invalid argument)
(xfce4-session:22652): xfce4-session-WARNING **: 17:44:54.283: Unable to launch "/usr/libexec/geoclue-2.0/demos/agent" (specified by autostart/geoclue-demo-agent.desktop): Failed to close file descriptor for child process (Invalid argument)
if it can help: config.gz
┌──(root㉿kali)-[~]
└─# inxi -G
Graphics:
Device-1: msm-dai-q6-hdmi driver: msm_dai_q6_hdmi v: N/A
Display: server: X.Org v: 21.1.99 with: Xwayland v: 23.2.4 driver: X:
loaded: modesetting unloaded: fbdev dri: swrast gpu: msm_dai_q6_hdmi
resolution: 2184x1024~90Hz
API: EGL v: 1.5 drivers: kms_swrast,swrast
platforms: gbm,x11,surfaceless,device
API: OpenGL v: 4.5 vendor: mesa v: 24.0.3 renderer: llvmpipe (LLVM 17.0.6
128 bits)
API: Vulkan v: 1.3.275 drivers: N/A surfaces: xcb,xlib
┌──(root㉿kali)-[~]
└─# uname -a
Linux kali 5.4.242-Hentail_kernel-9b433a4c #1 SMP PREEMPT Sun Mar 17 07:28:03 +10 2024 aarch64 GNU/Linux
Gaël Bonithon (29791035) at 24 Mar 10:43
Explicitly depend on gio-unix-2.0
Thanks!