Urgency blinking does not raise panels with autohide enabled
Submitted by Fedor Sinev
Description
Created attachment 4755 Fixes a bug where panels with autohide would not raise when a window had an urgency hint
The issue: When the urgency blinking status is enabled on windows, the component does not automatically raise or open the XFCE panel from its hidden state.
The fix: To fix this, I've created a patch which prevents the panel from autohiding and raises it by calling the panel's plugin interface to block autohide while the blinking state is activated.
According to Nick Schermer on #xfce-dev, if I'm interpreting this correctly, a cleaner and internal way could be done to correct this problem such as using events and signaling or even raising the panel in libxfce4panel's xfce_arrow_button_set_blinking call, but there's certain concerns it might break plugin compatibility.
Anyways, I'm not sure what the best course of action is, but it works and only depends on the plugin. If anyone is opposed to this patch or its mechanism, naturally, please comment.
Rationale: In Windows, an urgency notification of a window would automatically raise your panel or "taskbar." I feel if some one is running tasklist (Windows Buttons), they are expecting similar behavior.
How to test for this bug:
- Enter the "Panel Preferences" interface.
- Under Display, make sure "Automatically show and hide the panel" is checked.
- Use an application to send you an urgency hint (e.g: Skype chat, nickname highlighting in XChat, or just send yourself a message on any IRC server by typing in /msg {NICK} message and then rapidly unfocus the window)
- Raise the panel by moving the mouse to the very bottom
- If you see an urgency hint and your panel has not been raised automatically, you have experienced this bug.
Patch 4755, "Fixes a bug where panels with autohide would not raise when a window had an urgency hint":
task_fix.patch
Version: Unspecified