Honor “Show icons in menu” setting regardless of GTK-wide menu icons setting

Submitted by Raffaello D. Di Napoli

Assigned to Nick Schermer

Description

Created attachment 4652 Honor "Show icons in menu" preference even when menu icons are off for all GTK+ apps

I’ve been debating for a while whether to submit this trivial patch, because I’m not sure how it will be received. But I made my mind up now, so here it is.

I find the effect of the “Show icons in menu” checkbox to be not intuitive. I don’t like icons all over the place in each program’s menu, but I do like icons in my Application Menu, so I thought that the intuitive thing to do was to disable menu icons for all GTK+ programs (via Settings Manager > Appearance) while keeping turned on the icons in the app menu only. But that didn’t work, because the GTK+ option overrides the app menu-specific option.

To scratch my own itch, I wrote this small patch, that gives full power to the “Show icons in menu” option. Users who do NOT want the icons in the app menu will still have an option to turn them off (just uncheck the box), while users who, like me, want icons to show up in that menu only, will now have a way.

Would you please consider this patch? It’s easy, clean, user-fiendly(er) and whatnot :)

Patch 4652, "Honor "Show icons in menu" preference even when menu icons are off for all GTK+ apps":
xfce4-panel-4.10.0-honor-menu-icons-pref.patch

Version: 4.10.0