Incorrect icon shown in window buttons

Submitted by Yousuf Philips @philipzae

Assigned to Xfce Bug Triage

Link to original bug (#16538)

Description

Created attachment 9580 screenshot

When appfinder is open, the icon for it in window buttons isnt the same icon set in its .desktop file, which is edit-find.

Attachment 9580, "screenshot":

Version: Unspecified

See also

• https://bugzilla.xfce.org/show_bug.cgi?id=16492

Andre Miranda @andreldm said:

App's window and xfce4-run.desktop icon is "system-run". xfce4-appfinder.desktop icon is "edit-find".

What do you suggest? Change icons according to selected mode? Patch?

Yousuf Philips @philipzae said:

Yes i would suggest changing the icon based on the current state of the window, as it can be opened and closed whether its started in its open or closed state. Same case as for the title bar (bug 16492).

Works in the proposed manner with the attached patch: dynamic-icon.patch

Your patch doesn't apply, are you sure you wrote it against current git master?

This patch accomplishes what's requested, but when !2 (closed) get merged this won't make sense anymore.

Ah my bad. Well, try this if you want: dynamic-icon.patch

No problem, however it does pretty much the same thing as mine

@philipzae please take look at !2 (closed) and let us know if having different icons for each mode still makes sense.

Hah, what a mix-up. Anyways, I guess this can be closed now... or at least when the merge occurs.

Yes different icons for each mode still makes sense.

In that case, why not just change the XFCE_APPFINDER_STOCK_EXECUTE and XFCE_APPFINDER_STOCK_FIND macros to different icons? Then, you can incorporate my modifications and still have the new icons.

mentioned in merge request !2 (closed)

@m4u9 I'd appreciate if you could evaluate this request and perhaps design a nice icon

great more work... :P

Kidding I think it's better to have a separate icon I will probably suggest something once we are done with the other icons. It will likely be a variation of the appfinder main icon or something like that

@m4u9: Any suggestion now.

Not yet. However I welcome ideas

For run, maybe a single gear with a play button in it. I've seen a few like that. The three gears idea works fine if its a large icon, but when its small, it doesn't.

For application finder, a magnifying glass like elementary xfce seems good.

Since #18 (closed) was closed as won't fix, this request should be handled the same way.

added 5. Icons label

added Patch label

closed