Embedded image thumbnails don't all zoom to max

Hi folks,

Thanks again for sorting the max thumbnail image size issue - much appreciated. I've found a weird thing which I can't see a reason for:

Some images' thumbnails don't expand to max. Some need a F5 refresh to do so, but some don't at all. Today, I found 3 formats of photos I've taken, presumably with 3 different smartphone cameras, some of which size to max, and some of which don't:

pic1, 2014, 3200x2368px, aspect 1.35, doesn't max. pic2, 2018, 4032x3024, 1.33, does max. pic3, 2020, 4618x3464, 1.33, doesn't max.

Aspect ratio doesn't seem to be the reason since 2018 & 2020 are both the same. Filesize doesn't seem to be the reason since the mid-size files work and the smaller and larger don't.

Any thoughts? Happy to share metadata info on the files if y'all have any ideas.

Cheers!

Thanks for reporting !

Most likely a tumbler issue, which does not generate thumbnails for these pictures for some reason.

1. Please attach some pictures for which large thumbnails are missing.
2. Please check if large thumbnails are generated for these pictures in ~/.cache/thumbnails/large, in order to see if thunar or tumbler is to blame. (Best first clean the thumbnails folder to simplify testing)

added 3. Need Info 5. Thumbnails in thunar labels

Hi Alex, sorry for delay. Photos & tumbler large thumbnails here. Cheers!

Thanks ! Humm, works fine here:

Tried with/without frame, seems to make no difference.

Which version of thunar did you use for testing ?

Does it always happen for these pictures ? Same if you use detailed view ? What happens if you remove ~/.cache/thumbnails .. same again ?

Would you mind attaching the images directly to the issue ? (not sure how long google will offer them)

I have the same issue with the images. I think it depends on the zoom level. Max zoom level triggers it for me.

Also, for me the zoom keyboard shortcuts doesn't work on my system. Does they work for you?
I use thunar 4.16.2

The bug appears to be in tumbler-jpeg-thumbnailer. Using tumbler-pixbuf-thumbnailer instead gives the expected result.

https://gitlab.xfce.org/xfce/tumbler/-/blob/master/tumblerd/tumbler.rc#L25

Alex this is stock install xubuntu20.10, Thunar 1.8.15.

Thanks Theo. I'm new to lots of this, does that link to the merge branch suggest a fix to tumbler-jpeg-thumbnailer has been merged and so will be pushed to users automatically? Or will require a manual build from source?

Re: using tumbler-pixbuf-thumbnailer, jpeg may be due for depreciation in favour of pixbuf ("Is that plugin still needed ? Pixbuf-thumbnailer as well supports jpeg. Is this plugin faster ?"); is it simply a case of switching 'disabled' to 'true' at L30 of tumbler.rc?

Cheers!

I'm new to lots of this, does that link to the merge branch suggest a fix...

No, that is just the current tumbler configuration which gives tumbler-jpeg-thumbnailer the highest priority.

using tumbler-pixbuf-thumbnailer, jpeg may be due for depreciation in favour of pixbuf

However, it processes Exif data which can be used to improve (photo) thumbnails.

is it simply a case of switching 'disabled' to 'true' at L30 of tumbler.rc?

I would think so. You may need to clear the cache and also terminate the tumblerd process.

Cheers fella. That does indeed fix it. I'll leave it up to you chaps as to whether to close this or if there's something that Thunar could/should do. Have a good weekend all.

Nice findings @lastonestanding !

However there seems to be as well some other criteria needed to trigger that bug.

I have Priority=3 for JPEGThumbnailer and Priority=2 for PixbufThumbnailer, but I cannot trigger it with the photos above.

Anyhow, moving issue to tumbler.

moved from thunar#504 (moved)

So, the two photos contain embedded thumbnails (Exif data). Those are loaded and shown without any upscaling.

removed 3. Need Info label

Attaching pictures directly to issue, to make sure they are still available when somebody wants to reproduce later.

P_20200201_130440

IMG_20180621_092835

IMG_20140426_122708

@SimonDedman : If you want me to remove them, just let me know !

Can we close this report or do you have any suggestions?

Kind of related: thunar#59

changed title from Image thumbnails don't all zoom to max to Embedded image thumbnails don't all zoom to max

Not sure if just closing it, is the right thing to do.

Maybe tumbler should just generate "large" thumbnails in such a case from the pic, even if there is an embedded thumbnail (in case the quality of embedded thumbnail to low).

Seems sensible to me

closed with commit afb365a2

The images linked in this issue did not have embedded thumbnails, but I think that's where the problem must have come from originally. Anyway, I was able to reproduce it with an image of my own containing an embedded thumbnail of lower quality than 256x256. Now fixed.

assigned to @Tamaranch

mentioned in commit 76d30746

changed milestone to %4.17.0