Skip to content

Make request management safer

Submitted by Markus Elfring @elfring

Assigned to Ali Abdallah @ali

Link to original bug (#16842)

Description

A change was integrated for the topic “Fix handles starting from zero (Bug #16814)”. f8e6f17d

The variable “handle” became an unsigned integer in the function “tumbler_scheduler_request_new”. This data type provides support for the computation functionality “wraparound”. I find that this design choice contains a risk as long as it is not checked if previous request identifiers became reusable again. (The concrete life time of managed data processing objects is unknown.)

Thus I suggest to consider additional software design options.

  1. Terminate the program after the zero handle was detected again so that duplicate assignments of request identifiers can generally not happen.

  2. Introduce a dynamic tracking for assigned requests by configurable data structures according to system preferences in a run time environment.

Version: 0.2.8