Gaël Bonithon (3389bc5e) at 27 Mar 12:54
xdg-cache: Fix and optimize xdg_cache_cache_is_thumbnail()
Thanks, that makes sense.
This is perhaps a bit silly, but I figure it shouldn't be too hard to implement:
When viewing one of the thumbnail cache folders like $XDG_CACHE_HOME/thumbnails/normal
, thumbnails are not generated for obvious circularity reasons. However, we could treat those files as their own thumbnails: when the normal
sized thumbnail is requested for $XDG_CACHE_HOME/thumbnails/normal/hash.png
, tumbler could simply return $XDG_CACHE_HOME/thumbnails/normal/hash.png
.
That's not how it works :) Client and server share the same thumbnail specification, which specifies where and under what name a thumbnail for a file should be saved. Tumbler doesn't return a thumbnail, it sends a Ready signal over D-Bus when it has successfully created a thumbnail, then the client fetches it from the location specified by the specification.
So, to sum up, the recursive nature of thumbs-of-thumbs is in the specification, there's nothing we can do about it. It's up to the client to load the image directly when it's in a thumbnail directory, as indicated by the specification:
You must not create/save thumbnails for any files you will find in these directories. Instead load and use these files directly.
So I'm closing this, but it could be valid enhancement requests for thunar and/or ristretto (feel free to create them if you like).
This is perhaps a bit silly, but I figure it shouldn't be too hard to implement:
When viewing one of the thumbnail cache folders like $XDG_CACHE_HOME/thumbnails/normal
, thumbnails are not generated for obvious circularity reasons. However, we could treat those files as their own thumbnails: when the normal
sized thumbnail is requested for $XDG_CACHE_HOME/thumbnails/normal/hash.png
, tumbler could simply return $XDG_CACHE_HOME/thumbnails/normal/hash.png
.
Gaël Bonithon (7d9c18e4) at 25 Feb 12:33
Do not use g_log_set_always_fatal()
Gaël Bonithon (b6b6e0df) at 25 Feb 12:33
Do not use g_log_set_always_fatal()
Gaël Bonithon (86d8f2b2) at 05 Feb 18:58
Back to development
Gaël Bonithon (a043b8db) at 05 Feb 18:57
Updates for release
Gaël Bonithon (025ecfab) at 05 Feb 18:57
Updates for release
Gaël Bonithon (997bb3f4) at 05 Feb 18:47
Update copyright year
Gaël Bonithon (e6fd2043) at 05 Feb 18:45
Update copyright year
Gaël Bonithon (5fd80360) at 18 Jan 13:33
gepub-thumbnailer: Return if GBytes buffer is NULL
Gaël Bonithon (6ad93792) at 18 Jan 13:32
gepub-thumbnailer: Return if GBytes buffer is NULL
Gaël Bonithon (dbf63b99) at 11 Jan 17:37
build: Search for bind_textdomain_codeset in libintl too
Gaël Bonithon (230e62f9) at 11 Jan 17:34
build: Search for bind_textdomain_codeset in libintl too
Gaël Bonithon (e3205200) at 30 Nov 15:32
Updates for release
Gaël Bonithon (068b7d40) at 30 Nov 15:32
Updates for release