Thunar 4.17.10 fails to build w/ --disable-notifications

When configured with --disable-notifications, the new version fails to build due to undefined functions:

make[3]: Entering directory '/tmp/thunar-4.17.10/thunar'
gcc -DHAVE_CONFIG_H -I. -I..  -I.. -I.. -DBINDIR=\"/usr/local/bin\" -DDATADIR=\"/usr/local/share\" -DEXO_DISABLE_DEPRECATED -DG_LOG_DOMAIN=\"thunar\" -DLIBDIR=\"/usr/local/lib\" -DHELPERDIR=\"/usr/local/lib\" -DPACKAGE_LOCALE_DIR=\"/usr/local/share/locale\" -DTHUNAR_VERSION_API=\"\" -DSN_API_NOT_YET_FROZEN -DG_UDEV_API_IS_SUBJECT_TO_CHANGE  -DNDEBUG -I/usr/include/exo-2 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -pthread -I/usr/include/xfce4  -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -pthread -I/usr/include/libmount -I/usr/include/blkid  -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  -I/usr/include/gudev-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include    -I/usr/include/xfce4/libxfce4ui-2 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -pthread -I/usr/include/xfce4  -I/usr/include/xfce4 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  -I/usr/include/xfce4/libxfce4kbd-private-3 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/xfce4 -I/usr/include/xfce4/xfconf-0 -I/usr/include/xfce4/libxfce4ui-2 -pthread  -I/usr/include/xfce4/xfconf-0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -pthread -I/usr/include/libmount -I/usr/include/blkid  -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16   -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -pthread -I/usr/include/libmount -I/usr/include/blkid  -g -O2 -MT thunar-thunar-notify.o -MD -MP -MF .deps/thunar-thunar-notify.Tpo -c -o thunar-thunar-notify.o `test -f 'thunar-notify.c' || echo './'`thunar-notify.c
thunar-notify.c: In function ‘thunar_notify_undo’:
thunar-notify.c:310:8: warning: implicit declaration of function ‘thunar_notify_init’; did you mean ‘thunar_notify_uninit’? [-Wimplicit-function-declaration]
  310 |   if (!thunar_notify_init ())
      |        ^~~~~~~~~~~~~~~~~~
      |        thunar_notify_uninit
thunar-notify.c:313:3: warning: implicit declaration of function ‘thunar_notify_undo_or_redo’; did you mean ‘thunar_notify_redo’? [-Wimplicit-function-declaration]
  313 |   thunar_notify_undo_or_redo (operation, TRUE);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |   thunar_notify_redo
thunar-notify.c: At top level:
thunar-notify.c:327:1: warning: conflicting types for ‘thunar_notify_undo_or_redo’; have ‘void(ThunarJobOperation *, gboolean)’ {aka ‘void(struct _ThunarJobOperation *, int)’}
  327 | thunar_notify_undo_or_redo (ThunarJobOperation *operation,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
thunar-notify.c:327:1: error: static declaration of ‘thunar_notify_undo_or_redo’ follows non-static declaration
thunar-notify.c:313:3: note: previous implicit declaration of ‘thunar_notify_undo_or_redo’ with type ‘void(ThunarJobOperation *, gboolean)’ {aka ‘void(struct _ThunarJobOperation *, int)’}
  313 |   thunar_notify_undo_or_redo (operation, TRUE);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:1961: thunar-thunar-notify.o] Error 1

mentioned in commit 697e188d

Thank you for reporting and sorry for the inconveniance, I forgot to test that use-case. Fixed with above commit.

Do you need a new thunar release with that bugfix in the near term, or would it be fine for you to wait until 01.11, on which anyhow a new release will happen ? (xfce4.18 pre 1 release)

closed

I would prefer a new release since I'm pretty sure more Gentoo users will hit this, and the patch is a bit large to carry in our repo. However, I'm not going to insist if that's a lot of work.

Scratch that. It just occurred to me that I can just be fetching the patch straight from GitLab with minimum overhead on our end. Just confirmed that this works, so no need for new release for us. Thanks again!

Great, thanks as well for fetching the patch !