Last opened tabs get opened in reverse order

Hello!

The last opened tabs get opened in reverse order.

I'm working on this. I'll send MR later in the evening.

mentioned in merge request !131 (merged)

changed title from last opened tabs get opened in reverse order to Last opened tabs get opened in reverse order

Sorry for asking that late: Actually first time I try to reproduce .. possibly I fail to understand what this bug is about.

Using thunar master I create folders A, B and C and open each of them as tab in order A,B,C. Closing and restarting thunar opens them in the same order than before.

So is that bug possibly about something else ?

added 3. Need Info 5. Tabs labels

Just took a try for your fix from !131 (b3010fd3) .. actually that reverses the order of the tabs for me, each time I open thunar :/ So to be checked why you face that bug.

Using thunar master I create folders A, B and C and open each of them as tab in order A,B,C. Closing and restarting thunar opens them in the same order than before.

Can you please try twice in succession? Since each time the tab order gets reversed, it alternates between the correct original order and reverse order in consecutive executions.

Here's the screencast:

I'm not sure if this matters but I have installed thunar from master (thunar 4.17.3git-b3739cb8 (Xfce 4.16)) at custom location and I also have distro provided thunar (thunar 1.8.14 (Xfce 4.14)) installed.

I think I figured it out. Do you have misc-switch-to-new-tab set? Disable it and then you can reproduce the issue.

But this also means I need to revert to my original approach of passing TRUE for force_switch_to_new_tab. i.e.

thunar_window_notebook_add_new_tab (window, directory, TRUE);

Yep this is it.

Indeed misc-switch-to-new-tab makes the difference.

I would suggest, in order to reduce confusion, best rename !131 (merged) to "After restoring tabs set focus on the last focused tab" and fix this bug in a separate MR.

Done!

mentioned in merge request !135 (merged)

closed with merge request !135 (merged)

Thanks alot! To be released in thunar 4.17.4