Zoom related keyboard shortcuts do not work

Hi!

Noticed that keyboard shortcuts to zoom in Ctrl-+, zoom out Ctrl-- and reset zoom level Ctrl-0 are not working. Thunar version 4.16.3. No idea in which version this regression appeared.

Running Xfce4 4.16 on Manjaro GNU/Linux.

Works fine here. With master / 4.16.3.

Can you please upload your ~/.config/Thunar/accels.scm to the issue.

Try as well to quit thunar (thunar -q), move the file to to ~/.config/Thunar/accels.scm.old and restart, to see if it is a config problem.

added 3. Need Info 5. Keyboard Shortcuts labels

Hmmmm .. this is interesting. I can reproduce this on 2 computers. One being Manjaro and another Arch. For the sake of clean experiment I created a new user to have a fresh Xfce, still I can reproduce the issue.

I am attaching accels.scm as per your request (from a fresh session of Xfce). Also I am wondering if this can somehow be related to keyboard layout(s) and locale configuration? This is what I currently have:

$ locale
LANG=en_GB.UTF-8
LC_CTYPE="en_GB.UTF-8"
LC_NUMERIC="en_GB.UTF-8"
LC_TIME="en_GB.UTF-8"
LC_COLLATE="en_GB.UTF-8"
LC_MONETARY="en_GB.UTF-8"
LC_MESSAGES="en_GB.UTF-8"
LC_PAPER="en_GB.UTF-8"
LC_NAME="en_GB.UTF-8"
LC_ADDRESS="en_GB.UTF-8"
LC_TELEPHONE="en_GB.UTF-8"
LC_MEASUREMENT="en_GB.UTF-8"
LC_IDENTIFICATION="en_GB.UTF-8"
LC_ALL=

And

$ localectl
   System Locale: LANG=en_GB.UTF-8
       VC Keymap: n/a
      X11 Layout: us,lv
       X11 Model: pc105
     X11 Variant: ,apostrophe
     X11 Options: ctrl:nocaps,grp:shifts_toggle

And I also tried renaming accels.scm -> accels.scm.old and restarting thunar. Still the same issue. For the sake of completeness here is accels.scm.old

Is there any way to start Thunar with debug/logging?

I think that you have to use the keypad keys:

<Primary>KP_Add
<Primary>KP_Subtract
<Primary>KP_0

Right, keypad "+" and "-" works. Though I have never used those to zoom in/out previously. So, I this is the change of default behavior?

Hah, interesting, did not know that it ever was possible, and just assumed you are talking about the keypad keys :)

So yes, now I can reproduce, it's a regression. I'll look into it, should not be hard to recover.

@alexxcons For me it is other way around, most of my keyboards do not hane numpads, so I would not even consider using those numpad keys ;)

Any suggestion how to configure regular "+" and "-" keys to work? Currently poking at accels.scm file with no luck.

Same here, using <Primary>+ / <Primary>+ / <Primary>0 does not work for unknown reason :/

As well using multiple, like it should be possible according to gtk doc does not work.

.. need to debug that.

Seems I got it working in accels.scm:

(gtk_accel_path "<Actions>/ThunarWindow/zoom-in" "<Primary>equal")
(gtk_accel_path "<Actions>/ThunarWindow/zoom-out" "<Primary>minus")
(gtk_accel_path "<Actions>/ThunarWindow/zoom-reset" "<Primary>0")

Nice, thank you for finding the proper shortcuts ! (Think I forgot to uncomment the line while testing <Primary>0 )

Though "Ctrl-+" is <Primary>plus for me, that is not the case for you ?

I dont know why it is not possible to specific multiple shortcuts in the same line. Though like done for other shortcuts, it is possible to workaround that:

0001-Reintroduce-alternative-zoom-shortcuts-Issue-514.patch

Though "Ctrl-+" is <Primary>plus for me, that is not the case for you ?

See apps/xfce4-terminal#55 (comment 15387).

(since en_US keyboards have + as the shifted =)

Phew, that is a bit special. I hope there will not show more weird keyboard layout discrepancies. :| ... Ok, I suppose we should support at least what we did before, so yet another alternative accel path:

0001-Reintroduce-alternative-zoom-shortcuts-Issue-514.patch

Would be fine for you like that ?

removed 3. Need Info label

mentioned in commit 7c9de2db

mentioned in commit c13a9190

Fixed for master and 4.16 branch. To be released in 4.16.4 and 4.17.1

closed