Not possible to grab scrollbar on the very right pixels when Thunar is maximized

Submitted by Yury Martynov

Assigned to Xfce Bug Triage

Link to original bug (#16050)

Description

Created attachment 9120 screen record

Hi! I have a problem in the latest 1.8.9 version of the Thunar and I need help

by default, the Thunar always open maximized (Alt+F10/Alt+F11) and I often need to quickly scroll down using mouse cursor. It worked for me in 1.6 when i enabled it by gtk-primary-button-warps-slider = 1 param in ~/.config/gtk-*/settings.ini file. But now in 1.8.9 version, it doesn't work as if have an invisible border in the right side and I constantly have to be distracted by this so that the scroll bar appears

Thank you!

Attachment 9120, "screen record":
simplescreenrecorder1-2019-10-15_01.32.55

Version: 1.8.9

Adam Purkrt said:

You mean you can not scroll the maximized window with the mouse pointer on the right edge of the screen? I find that a drawback (too). But perhaps you are writing about something else.

Alexander Schwinn @alexxcons said:

Thanks for reporting !

Interesting .. I use two monitors, where I almost always use thunar on the left one .. so until now I never noticed that the scrollbar has some "dead pixels" on the right :)

I have no idea about "gtk-primary-button-warps-slider" .. though IMO it should not be required at all to run some specific settings, just to be able to use all pixels of the scrollbar on fullscreen.

Though the provided "gtk-primary-button-warps-slider" may help to figure out what is needed to get it to work.

The used theme seems not to matter.

Alexander Schwinn @alexxcons said:

Happens as well for mousepad, though xfce4-terminal seems not to be affected.

Possibly related to that "auto enlarge" feature of the scrollbar, which is not used by xfce4-terminal.

No time to work on this currently, busy with some other bug .. patches would be very welcome !

Theo Linkspfeifer said:

No patch, but a workaround:

.thunar .standard-view.frame { border-right: 0px; }

This CSS snippet can be added to ~/.config/gtk-3.0/gtk.css .

Yury Martynov said:

You mean you can not scroll the maximized window with the mouse pointer on the right edge of the screen

yes. Sorry for my English!

This CSS snippet can be added to...

wow!! Thank you very much!

P.S. It works too for me using this patch

diff -ur a/thunar/thunar-application.c b/thunar/thunar-application.c --- a/thunar/thunar-application.c 2019-08-11 03:33:53.000000000 +0300 +++ b/thunar/thunar-application.c 2019-10-16 13:17:12.097528291 +0300 @@ -593,7 +593,7 @@ /* add missing top border to side pane / ".shortcuts-pane { border-top-style: solid; }" / make border thicker during DnD */

• ".standard-view { border-left-width: 0px; }"

• ".standard-view { border-left-width: 0px; border-right: 0px; }" ".standard-view:drop(active) { border-width: 2px; }", -1, NULL); screen = gdk_screen_get_default (); gtk_style_context_add_provider_for_screen (screen, GTK_STYLE_PROVIDER (css_provider), GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);

Yury Martynov submitted a patch:

fix_scrollbar_in_standart_view.patch

Please, review this patch before using

Patch 9123, "fix_scrollbar_in_standart_view.patch":
fix_scrollbar_in_standart_view.patch

Theo Linkspfeifer said:

Ideally, you should rename "border-right" to "border-right-width" and use git format-patch to create the patch file.

Yury Martynov submitted a patch:

rename "border-right" to "border-right-width"

i can create a pull request on the github mirror

Patch 9124, "fix_scrollbar_in_standart_view-r1.patch":
fix_scrollbar_in_standart_view-r1.patch

Yury Martynov submitted a patch:

Patch 9125, "fix_scrollbar_in_standart_view-r2.patch":
fix_scrollbar_in_standart_view-r2.patch

GitBot @GitBot said:

Yury Martynov referenced this bugreport in commit b486e473

Not possible to grab scrollbar on the very right pixels when Thunar is maximized (Bug #16050)

https://git.xfce.org/xfce/thunar/commit?id=b486e473eb947f4ba96e4ac370c8669553ead5a2

GitBot @GitBot said:

Yury Martynov referenced this bugreport in commit a87c890d

Not possible to grab scrollbar on the very right pixels when Thunar is maximized (Bug #16050)

https://git.xfce.org/xfce/thunar/commit?id=a87c890d78d749cc69125bf744913d9ea6576617

Alexander Schwinn @alexxcons said:

Works fine! Patch applied to master and 4.14 branch, to be released in 1.8.10

Thanks alot for your contribution !

Alexander Schwinn @alexxcons said:

I opened Bug #16056 for the same issue with mousepad .... would be great if you could take a look as well.

In addition, there is a overall bug, which possibly can be closed: Bug #15911

Alexander Schwinn @alexxcons said:

Keep in mind that there will be an additional border when multiple tabs are open (see comment 2).

Meh, same problem than for mousepad .. fix works for single tab, but not for multitab.

Adam Purkrt said:

As I have written over irc, I do not see any problem with multitab, the patch still works. I can scroll on the right edge with more than one tab in the patched version.

Alexander Schwinn @alexxcons said:

Just took another try. This time I as well checked different themes: Bug with multitab occurs with greybird / bluebird Bug does not occur with blackbird, adwaita, adwaita-dark, high-contrast

If its only greybird / bluebird, probably it should be fixed there ... though when more themes are buggy, possibly it is worth fixng it in thunar.

I'll ask someone with better theming knowledge what would be preferred.

mentioned in issue apps/mousepad#34 (closed)

Overview bug: xfwm4#346 (closed)

added 5. Scrolling label

added 5. Tabs label