heap-use-after-free when quickly closing properties dialog on the desktop
Version information
a62b3ebf compiled on Arch Linux
Steps to reproduce
thunar -qmkdir ~/Desktop/props- On the desktop, right-click on the props directory and select "Properties..."
- Press the Esc key rapidly to dismiss the dialog before it fully appears
- You might need to repeat steps 3 and 4 a few times to trigger the crash
Current behavior
A crash when using an ASan build
Expected outcome
No crash or memory errors
Backtrace
ERROR: AddressSanitizer: heap-use-after-free on address 0x7c215bb99710
READ of size 8 at 0x7c215bb99710 thread T0
#0 0x7fe167793ede in g_type_check_instance glib/gobject/gtype.c:4008:26
#1 0x7fe167767d65 in g_signal_handlers_disconnect_matched glib/gobject/gsignal.c:3034:25
#2 0x557b951d0ac7 in thunar_properties_dialog_finalize thunar/thunar/thunar-properties-dialog.c:994:3
#3 0x7fe16771940f in g_object_unref glib/gobject/gobject.c:4910:3
#4 0x7fe165ccafb3 in propagate_event gtk3/gtk/gtkmain.c:2686:11
#5 0x7fe165cc9ddd in gtk_propagate_event gtk3/gtk/gtkmain.c:2728:3
#6 0x7fe165cc8081 in gtk_main_do_event gtk3/gtk/gtkmain.c:1924:9
#7 0x7fe16429cd29 in _gdk_event_emit gtk3/gdk/gdkevents.c:73:5
#8 0x7fe1644303bb in gdk_event_source_dispatch gtk3/gdk/x11/gdkeventsource.c:367:7
#9 0x7fe16717927f in g_main_dispatch glib/glib/gmain.c:3734:27
#10 0x7fe16717927f in g_main_context_dispatch_unlocked glib/glib/gmain.c:4603:7
#11 0x7fe16717a461 in g_main_context_iterate_unlocked glib/glib/gmain.c:4672:5
#12 0x7fe16717a7eb in g_main_context_iteration glib/glib/gmain.c:4738:12
#13 0x7fe168114b2e in g_application_run glib/gio/gapplication.c:2743:7
#14 0x557b95088ac7 in main thunar/thunar/main.c:81:3
0x7c215bb99710 is located 0 bytes inside of 40-byte region [0x7c215bb99710,0x7c215bb99738)
freed by thread T0 here:
#0 0x7fe16871d27d in free_sized /usr/src/debug/llvm/llvm-project-23.1.4.src/compiler-rt/lib/asan/asan_malloc_linux.cpp:70:3
#1 0x7fe1671a07c8 in g_free_sized glib/glib/gmem.c:236:3
#2 0x7fe16777edfe in g_type_free_instance glib/gobject/gtype.c:1979:5
#3 0x7fe1677194e2 in g_object_unref glib/gobject/gobject.c:4926:3
#4 0x557b9512b9b4 in thunar_emblem_chooser_dispose thunar/thunar/thunar-emblem-chooser.c:189:3
#5 0x7fe167718f72 in g_object_unref glib/gobject/gobject.c:4839:3
#6 0x7fe16771830e in g_object_run_dispose glib/gobject/gobject.c:1928:3
#7 0x7fe1662c16f1 in gtk_widget_destroy gtk3/gtk/gtkwidget.c:4787:5
#8 0x7fe165d7b2a8 in gtk_notebook_forall gtk3/gtk/gtknotebook.c:4609:7
#9 0x7fe1658a08a8 in gtk_container_foreach gtk3/gtk/gtkcontainer.c:2479:5
#10 0x7fe1658a643c in gtk_container_destroy gtk3/gtk/gtkcontainer.c:1702:3
#11 0x7fe165d70ada in gtk_notebook_destroy gtk3/gtk/gtknotebook.c:1864:3
#12 0x7fe16770a93c in g_cclosure_marshal_VOID__VOID glib/gobject/gmarshal.c:117:3
#13 0x7fe1676ff327 in g_type_class_meta_marshal glib/gobject/gclosure.c:1342:5
#14 0x7fe1676fdbeb in g_closure_invoke glib/gobject/gclosure.c:1140:7
#15 0x7fe167770558 in signal_emit_unlocked_R glib/gobject/gsignal.c:4049:7
#16 0x7fe16776b7ad in signal_emit_valist_unlocked glib/gobject/gsignal.c:3561:7
#17 0x7fe16776cc57 in g_signal_emit_valist glib/gobject/gsignal.c:3304:7
#18 0x7fe16776cc57 in g_signal_emit glib/gobject/gsignal.c:3624:3
#19 0x7fe166302c02 in gtk_widget_dispose gtk3/gtk/gtkwidget.c:12184:7
#20 0x7fe167718276 in g_object_run_dispose glib/gobject/gobject.c:1917:3
#21 0x7fe1662c16f1 in gtk_widget_destroy gtk3/gtk/gtkwidget.c:4787:5
#22 0x7fe16573f081 in gtk_box_forall gtk3/gtk/gtkbox.c:2678:2
#23 0x7fe1658a08a8 in gtk_container_foreach gtk3/gtk/gtkcontainer.c:2479:5
#24 0x7fe1658a643c in gtk_container_destroy gtk3/gtk/gtkcontainer.c:1702:3
#25 0x7fe16770a93c in g_cclosure_marshal_VOID__VOID glib/gobject/gmarshal.c:117:3
#26 0x7fe1676ff327 in g_type_class_meta_marshal glib/gobject/gclosure.c:1342:5
#27 0x7fe1676fdbeb in g_closure_invoke glib/gobject/gclosure.c:1140:7
#28 0x7fe167770558 in signal_emit_unlocked_R glib/gobject/gsignal.c:4049:7
#29 0x7fe16776b7ad in signal_emit_valist_unlocked glib/gobject/gsignal.c:3561:7
#30 0x7fe16776cc57 in g_signal_emit_valist glib/gobject/gsignal.c:3304:7
#31 0x7fe16776cc57 in g_signal_emit glib/gobject/gsignal.c:3624:3
#32 0x7fe166302c02 in gtk_widget_dispose gtk3/gtk/gtkwidget.c:12184:7
#33 0x7fe16573e37a in gtk_box_dispose gtk3/gtk/gtkbox.c:240:3
#34 0x7fe167718276 in g_object_run_dispose glib/gobject/gobject.c:1917:3
#35 0x7fe1662c16f1 in gtk_widget_destroy gtk3/gtk/gtkwidget.c:4787:5
#36 0x7fe16636ad5c in gtk_window_forall gtk3/gtk/gtkwindow.c:8645:5
#37 0x7fe1658a08a8 in gtk_container_foreach gtk3/gtk/gtkcontainer.c:2479:5
#38 0x7fe1658a643c in gtk_container_destroy gtk3/gtk/gtkcontainer.c:1702:3
#39 0x7fe166360454 in gtk_window_destroy gtk3/gtk/gtkwindow.c:6010:3
#40 0x7fe16770a93c in g_cclosure_marshal_VOID__VOID glib/gobject/gmarshal.c:117:3
#41 0x7fe1676ff327 in g_type_class_meta_marshal glib/gobject/gclosure.c:1342:5
#42 0x7fe1676fdbd9 in g_closure_invoke glib/gobject/gclosure.c:1140:7
#43 0x7fe167770558 in signal_emit_unlocked_R glib/gobject/gsignal.c:4049:7
#44 0x7fe16776b7ad in signal_emit_valist_unlocked glib/gobject/gsignal.c:3561:7
#45 0x7fe16776cc57 in g_signal_emit_valist glib/gobject/gsignal.c:3304:7
#46 0x7fe16776cc57 in g_signal_emit glib/gobject/gsignal.c:3624:3
#47 0x7fe166302c02 in gtk_widget_dispose gtk3/gtk/gtkwidget.c:12184:7
#48 0x7fe16635e3fa in gtk_window_dispose gtk3/gtk/gtkwindow.c:3198:3
#49 0x557b951d09f4 in thunar_properties_dialog_dispose thunar/thunar/thunar-properties-dialog.c:981:3
#50 0x7fe167718276 in g_object_run_dispose glib/gobject/gobject.c:1917:3
#51 0x7fe1662c16f1 in gtk_widget_destroy gtk3/gtk/gtkwidget.c:4787:5
#52 0x7fe165cc8591 in gtk_main_do_event gtk3/gtk/gtkmain.c
#53 0x557b950a9a05 in thunar_abstract_dialog_close thunar/thunar/thunar-abstract-dialog.c:71:7
[...snip...]
previously allocated by thread T0 here:
#0 0x7fe16871d75e in calloc
#1 0x7fe1671a070a in g_malloc0 glib/glib/gmem.c:133:13
#2 0x7fe16777cf40 in g_type_create_instance glib/gobject/gtype.c:1882:17
#3 0x7fe16771d974 in g_object_new_internal glib/gobject/gobject.c:2671:24
#4 0x7fe16771b11b in g_object_new_with_properties glib/gobject/gobject.c:2833:14
#5 0x7fe16771b11b in g_object_new glib/gobject/gobject.c:2481:12
#6 0x557b951c042e in thunar_preferences_get thunar/thunar/thunar-preferences.c:1944:21
#7 0x557b951d0662 in thunar_properties_dialog_init thunar/thunar/thunar-properties-dialog.c:305:25
#8 0x7fe16777d652 in g_type_create_instance glib/gobject/gtype.c:1900:5
#9 0x7fe16771d974 in g_object_new_internal glib/gobject/gobject.c:2671:24
#10 0x7fe16771cc1f in g_object_new_valist glib/gobject/gobject.c:3009:16
#11 0x7fe16771b0db in g_object_new glib/gobject/gobject.c:2484:12
#12 0x557b951ccb10 in thunar_properties_dialog_new thunar/thunar/thunar-properties-dialog.c:1889:10
#13 0x557b9510649c in thunar_dbus_service_display_file_properties thunar/thunar/thunar-dbus-service.c:612:12
#14 0x557b95094c1b in _g_dbus_codegen_marshal_BOOLEAN__OBJECT_STRING_STRING_STRING thunar/builddir/thunar/thunar-dbus-service-infos.c:292:5
#15 0x557b95093f9b in thunar_dbus_file_manager_method_marshal_display_file_properties thunar/builddir/thunar/thunar-dbus-service-infos.c:1939:3
#16 0x7fe1676fdbd9 in g_closure_invoke glib/gobject/gclosure.c:1140:7
#17 0x7fe16776f9b7 in signal_emit_unlocked_R glib/gobject/gsignal.c:3929:15
#18 0x7fe167768b3d in signal_emitv_unlocked glib/gobject/gsignal.c:3253:3
#19 0x7fe167768b3d in g_signal_emitv glib/gobject/gsignal.c:3153:3
#20 0x557b95098132 in _thunar_dbus_file_manager_skeleton_handle_method_call thunar/builddir/thunar/thunar-dbus-service-infos.c:5120:3
#21 0x7fe168245d40 in g_dbus_interface_skeleton_method_dispatch_real glib/gio/gdbusinterfaceskeleton.c:616:7
#22 0x7fe168247af3 in skeleton_intercept_handle_method_call glib/gio/gdbusinterfaceskeleton.c:663:3
#23 0x7fe1681d7a2d in call_in_idle_cb glib/gio/gdbusconnection.c:5470:3
#24 0x7fe1671648af in g_idle_dispatch glib/glib/gmain.c:6711:15
#25 0x7fe16717927f in g_main_dispatch glib/glib/gmain.c:3734:27
#26 0x7fe16717927f in g_main_context_dispatch_unlocked glib/glib/gmain.c:4603:7
#27 0x7fe16717a461 in g_main_context_iterate_unlocked glib/glib/gmain.c:4672:5
#28 0x7fe16717a7eb in g_main_context_iteration glib/glib/gmain.c:4738:12
#29 0x7fe168114b2e in g_application_run glib/gio/gapplication.c:2743:7
#30 0x557b95088ac7 in main thunar/thunar/main.c:81:3Additional information
There is a similar crash when performing these steps within Thunar instead of xfdesktop, but it requires closing the Thunar window afterward.