Need case insensitive search

Submitted by Bill West

Link to original bug (#13842)

Description

"Select by Pattern" does not offer option for case insensitive search. Seems to be available for sort, but not search/selection

Version: 1.6.11

added 2. Feature 5. Searching labels

added 2. Enhancement label and removed 2. Feature label

mentioned in issue #480 (closed)

added 5. Dialogs label

When I tried the 'Select by pattern' dialog, I presumed that it was case insensitive by default, similar to when you type a name in the file pane or search in catfish, but as it is not I would suggest that it be made case insensitive always or alternatively have a checkbox in the dialog to notify the user of this option.

Code reference (thunar_standard_view_select_by_pattern())
https://gitlab.xfce.org/xfce/thunar/-/blob/master/thunar/thunar-standard-view.c#L2214

changed the description

I looked at the code, and found out something interesting : thunar_list_model_get_paths_for_pattern(), responsible for filtering files with wildcards, calls Glob style pattern matching. It uses strcmp inside, so it's not that flexible.

I think it would be better to replace glob with PCRE and add full regex, rather than patching only for case insensitivity.

On second thought, using PCRE would cause confusion for most use cases... It should be a separate feature, and so it's an separate issue. I should only patch for case insensitivity then.

mentioned in merge request !89 (merged)

closed with commit fec9ed46

Fixed by !89 (merged) thanksto @MShrimp4 , to be released in thunar 4.17.2

added 8. GSoC 2021 label

I tested this out and the checkbox is always enabled when I open it, even after I disable it.

From a UI point of view, I think the checkbox should be positioned underneath the field, like so.

the checkbox is always enabled when I open it, even after I disable it.

I dont think it is worth to have xfconf setting for it. Wait until someone actually asks for it ... (YAGNI).

From a UI point of view, I think the checkbox should be positioned underneath the field, like so.

IMO a matter of taste. No need to invest more time into such small details.

I dont think it is worth to have xfconf setting for it. Wait until someone actually asks for it ...

I am asking for it, as I would like to use it always with it disabled.

IMO a matter of taste. No need to invest more time into such small details.

Not of a matter of taste but something that would be described in HIG. Even the 'examples: ...' should be removed and be put as a tooltip or something else as it also isn't good design.

Uff, you come up with all that now, after all the discussion in this MR was resolved. :/

@MShrimp4 , in case your are still motivated to work on this topic and follow @philipzae's proposals, I would be ok with them.

• Case sensitivity should be turned off by default, no one cares if the file is named "log-??.txt" or "LOG-??.TXT". No idea why I turned it on :(
• Adding new xfconf for this would be unnecessary, and it probably would cause confusion with already existing prop "case-sensitive".

mentioned in merge request !98 (merged)

mentioned in commit 35ae38b1