Skip to content

Small memory leak in thunar_path_entry_get_search_query

Version information

12d0f1eb compiled on Arch Linux

Steps to reproduce

  1. thunar -q
  2. mkdir -p test-search/nested
  3. thunar test-search/
  4. Press Ctrl + f to activate search
  5. Double-click on the nested folder to exit search mode
  6. thunar -q

Current behavior

Small memory leak

Expected outcome

No memory leak

Backtrace

Direct leak of 1 byte(s) in 1 object(s) allocated from:
    #0 0x7b7fa6320e15 in malloc /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:67
    #1 0x7b7fa3fb66a1 in g_malloc glib/gmem.c:100
    #2 0x584844cc0463 in g_strdup_inline glib/gstrfuncs.h:317
    #3 0x584844cc0463 in thunar_path_entry_get_search_query thunar/thunar-path-entry.c:1536
    #4 0x584844cb5b84 in thunar_location_entry_get_search_query thunar/thunar-location-entry.c:532
    #5 0x584844cb5dc3 in thunar_location_entry_emit_edit_done thunar/thunar-location-entry.c:493
    #6 0x584844cb61a7 in thunar_location_entry_cancel_search thunar/thunar-location-entry.c:512
    #7 0x584844ca6ab6 in thunar_location_bar_cancel_search thunar/thunar-location-bar.c:408
    #8 0x584844db49d8 in thunar_window_cancel_search thunar/thunar-window.c:3678
    #9 0x584844dba2f0 in thunar_window_set_current_directory thunar/thunar-window.c:5527
    #10 0x7b7fa471b780 in g_cclosure_marshal_VOID__OBJECT gobject/gmarshal.c:1852
    #11 0x7b7fa470eeb6 in g_closure_invoke gobject/gclosure.c:916
    #12 0x7b7fa475690f in signal_emit_unlocked_R gobject/gsignal.c:3902
    #13 0x7b7fa475adb4 in signal_emit_valist_unlocked gobject/gsignal.c:3534
    #14 0x7b7fa4767a59 in g_signal_emit_valist gobject/gsignal.c:3277
    #15 0x7b7fa4767b80 in g_signal_emit gobject/gsignal.c:3597
    #16 0x584844cb86d7 in thunar_navigator_change_directory thunar/thunar-navigator.c:224
    #17 0x584844bd7864 in thunar_action_manager_poke_files_finish thunar/thunar-action-manager.c:1288
    #18 0x584844bfbb32 in thunar_browser_poke_file_internal thunar/thunar-browser.c:498
    #19 0x584844bfdc7f in thunar_browser_poke_file thunar/thunar-browser.c:537
    #20 0x584844bdd4b3 in thunar_action_manager_poke thunar/thunar-action-manager.c:1130
    #21 0x584844be07b9 in thunar_action_manager_activate_selected_files thunar/thunar-action-manager.c:829
[...snip...]

Additional information

There was a bunch of changes in this area recently, so I thought I'd report the leak first instead of attempting a fix :).