File selection with Shift or Ctrl + Up/Down don't work when Expandable folders are enabled

Version information

• 4.19.4
• Debian 12

Steps to reproduce

1. Enable Expandable Folders in List view
2. Try to select files with keyboard, with either Shift+Up/Down or Ctrl+Up/Down then Space
3. The focus just follow the Up/Down key press, no selection happens.

I don't think it is intended, because selecting files is still possible the other ways: with Ctrl+A, with Shift/Ctrl+clic.

If Expandable folders are disabled, selection with the keyboard works fine, like in Thunar 4.18.

Expected outcome

Selecting files with the keyboard should work the same whether Expandable folders are enabled or not.

Many thanks.

Thanks for reporting!

Indeed, seems like expandable folders broke keyboard selection, I can reproduce the problem on master.

Looks like expandable folders for list-view was only introduced in 4.19.x ... I actually thought we already had it for 4.18, though seems not to be the case

Edit: The feature was introduced as part of !352 (merged)

The added functions thunar_details_view_key_up_set_cursor and thunar_details_view_key_down_set_cursor handle the vertical keyboard navigation, but without them the default handler seems to do the correct job too while also allowing file selection with Shift.

First as well thought it should be fine to just use the default handler for these, though then I opened one of my testing folders with 100k files inside. Pressing the "down" arrow after opening it, will now crash thunar.

@Elessar1802 , would you be interested in looking into this one? I don't have time to look into it myself currently, though could do so after the 4.20 release.

added 5. Keyboard Shortcuts 5. List View (Detailed View) labels

assigned to @Elessar1802

Hmm, this seems still a bug in 4.20.0 final. (local build on ubuntu jammy)

unassigned @Elessar1802