transmission (copy/move) queue broken
When using the transmission queue by setting simultaneous transmissions to "local files only on the same devices", then starting 3 separate copy jobs, #2 and #3 are initially delayed, so far so good, but after #1 finishes, #2 and #3 start simultaneously copying even though they share a source / destination HDD. In fact, when #1 finishes, all other jobs that waited for #1 are started.
Activity
Thank you for reporting !
#2 and #3 start simultaneously copying even though they share a source / destination HDD.
Umm, I might misunderstand your usecase .. though if you select
"Parallel File transfer"="local files only on the same device", then, considering #2 and #3 are local, they are supposed to be transferred in parallel.added 3. Need Info 5. File Operations labels
My use case: Many HDDs, copying large amounts of data between each other.
If two copy jobs were to simultaneously start from drive A to drive B and C, the heads of drive A need to repeatedly skip between file 1 and file 2. This takes time (lower total speed, not just divided by 2) and increases mechanical wear on drive A as reading data in a linear fashion, where possible, is least taxing.
Hence the need for a queue that, if A and B are busy transferring already (job #1) and a new file transfer between A and C is added, that job #2 is held back until all previous jobs of drive A (busy) and C (idle) are done. Currently, set to
"Parallel File transfer"="local files only on the same device", it only waits for the one current job that is running on drive A and when that finishes it starts all the others simultaneously. I can't imagine a usecase for "wait for one job but then start all the others at once", which is what that option currently does.The behavior that would make most sense would be
"Parallel File transfer"="local files only but never on the same devices". Because as you add a fourth HDD, transfers between A and B shouldn't delay a transfer between C and D, but should delay between A and C or B and D. And they should start in sequence when both concerned drives have no more queued / active jobs.I've now switched to
"Parallel File transfer"="never"but that means that the queue also holds back jobs between drives when neither have a copy job (both idle).Does that make more sense?
-
Yes, thank you for all the details, now I understand the use-case and will try to look into it !
Few more questions:
- Which version of thunar do you use ?
- Did
local files only on the same deviceswork fine for you in the past, or was that bug always present for you ?
Edited by Alexander Schwinn great to hear! 4.18.3 is latest on Manjaro.
Ever since I've been using it (about a year), every time I looked at that option it was greyed-out with a note that it will be fixed / added in a later version. Then recently it became enabled and I wanted to use it but it appears broken to me.
-
Finally, found time to look in detail into this. So the first draft is this one: alexxcons/thunar@bf5d28f6
So far I did not test it. I am as well not a very good tester for this, since I only have a single SSD on my system. So if you can build thunar from source, testing would be very welcome !
After thinking a bit more about it, I am not sure any more if it is a good idea to replace
THUNAR_PARALLEL_COPY_MODE_ONLY_LOCAL_SAME_DEVICES, withTHUNAR_PARALLEL_COPY_MODE_ONLY_LOCAL_IDLE_DEVICEbecause there might be people which just want to always copy in parallel on local devices ... I suppose for SSD's it does not matter too much.I am as well not sure about copy operations from a SSD to the same SSD … possibly there are optimizations in place which make parallel copy desirable/faster in that case ?
Any drive has its command queue, for parallel tasks in the end it comes down to the latency of working through that queue. For HDDs it's the main limiting factor for parallel throughput, additionally you get file fragmentation (non-contiguous writes). For SSDs it's not as much of an issue, but still parallel tasks will never be exactly as fast as sequential transfers. Maybe transfers between multiple HDDs and an SSD, that scenario would benefit but you can always start a queued copy job if you know there is "bandwidth" left.
I just managed to compile (total noob here), I'll leave the commands here so it's easier (and you can see whether I messed up):
- git clone https://gitlab.xfce.org/alexxcons/thunar
- cd thunar
- git checkout bf5d28f6cc13e7ef9f3fb9baedfb2cd087ad458b
- https://wiki.xfce.org/thunar/dev/build_and_run
- install xfce4-dev-tools-devel from AUR
- ./autogen.sh
- make
- nvim launcher.sh
#!/bin/bash # Quit any running thunar instance and start a new thunar from source. Enable debug messages THUNAR_TEST_FOLDER=/path/to/thunar/testing/folder echo "./thunar/thunar -q;./thunar/thunar $THUNAR_TEST_FOLDER" ./thunar/thunar -q;G_MESSAGES_DEBUG=all ./thunar/thunar $THUNAR_TEST_FOLDER- chmod +x launcher.sh
- ./launcher.sh
It works and I found a bug (again as the other option had this behavior too):
- start copy job 1 A -> B
- start copy job 2 B -> A: gets queued like it should
- start copy job 3 B -> A: gets queued like it should
- job 1 finishes: job 2 and 3 start simultaneously, heads now making angry noises
A useful command I found to clear all caches (ever seen a 4TB 5400rpm HDD copy at 500MB/s so the transfer is "finished" before you can start the other ones?):
- su
- free && sync && echo 3 > /proc/sys/vm/drop_caches && free
Also, a related "nice-to-have": currently, thunar seems to queue jobs by the drive labels. But if there are two partitions on a HDD and you start to copy to both, the second job doesn't get queued, causing disk thrashing. And yes, partitions still are a thing, the outer part of a disk is about 30-50% faster. So the detection could be switched to fetch /dev/sdXY for target and source where Y is the partition and X is the disk it's on. Then decide by X if a disk is already busy, and queue the job.
Edited by recallmenotmentioned in commit 6cb11baa
mentioned in commit d0b7c16a
-
Thanks a lot for testing !
It works and I found a bug (again as the other option had this behavior too): * start copy job 1 A -> B * start copy job 2 B -> A: gets queued like it should * start copy job 3 B -> A: gets queued like it should * job 1 finishes: job 2 and 3 start simultaneously, heads now making angry noisesI could reproduce the bug on my local ssd. Fixed it (See commits for master and 4.18 above) ... actually the list of active jobs contained not jobs, but only views … so comparing them with jobs never could give a match
Using
THUNAR_PARALLEL_COPY_MODE_ONLY_LOCAL_IDLE_DEVICEthat use-case now works fine for me.For
THUNAR_PARALLEL_COPY_MODE_ONLY_LOCAL_SAME_DEVICESit would be great if you could do another test. Since I only have a single SSD, for me it is expected and correct that all jobs start simultaneously in that mode.Also, a related "nice-to-have": currently, thunar seems to queue jobs by the drive labels. ...
I suppose the problem could be fixed by the commit above (thunar uses a
device_fs_idwhich sounds promising, though I did not look yet where that comes from) Ah, so it took a while until I understood that you made the commit on thunar main, not your own branch. git kept barking at me "fatal: reference is not a tree"
So I did
- git checkout bf5d28f6cc13e7ef9f3fb9baedfb2cd087ad458b
- nvim thunar/thunar-progress-dialog.c
- then replaced the line 238 manually from here
then compiled like before with autogen.sh, then make errored out at:
CCLD libthunarx-3.la make[2]: *** No rule to make targetThunarx-3.0.typelib', needed by `all-am'. Stop.
Even if I delete the thunar dir, do a fresh clone, checkout to the bf5d commit and then don't manually modify thunar-progress-dialog.c, same error. As-is I can't test it, what am I doing wrong? OS is Manjaro, fully updated. I already reinstalled gcc-libs, gcc, llvm, llvm-libs, lldb, lld, make, clang, compiler-rt and xfce4-dev-tools-devel.
-
I pushed these commits to the official4.18 and master branch. In order to checkout, you don't need to touch the code. Here how to clone the official repo:
git clone https://gitlab.xfce.org/xfce/thunar.git(You can as well pull from different repos at once viagit remote add... though starting from scratch probably is the most simple way)Per default, you will have the
masterbranch … if you prefer using the4.18branch, dogit checkout xfce-4.18, (currently there is not that much difference between them)./autogen.sh make -j4 ./thunar/thunar (or re-use the launcher you wrote)No rule to make targetusually means, that some makefile was not generated by autogen.sh. If it still happens, maybeautogen.shshowed some error ? thank you for hand-holding me through this!
autogen seems to run fine:
Click to expand
$ ./autogen.sh Preparing package directory /home/CENSOREDNOTHING/temp/thunar_Test/thunar... Running intltoolize --automake --copy --force Running gtkdocize --copy... grep: Warnung: überzähliges \ vor , grep: Warnung: überzähliges \ vor einem Leerzeichen Running autoreconf... autoreconf: export WARNINGS= autoreconf: Entering directory '.' autoreconf: configure.ac: not using Gettext autoreconf: running: aclocal --force -I m4 ${ACLOCAL_FLAGS} autoreconf: configure.ac: tracing autoreconf: running: libtoolize --copy --force libtoolize: putting auxiliary files in '.'. libtoolize: copying file './ltmain.sh' libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'. libtoolize: copying file 'm4/libtool.m4' libtoolize: copying file 'm4/ltoptions.m4' libtoolize: copying file 'm4/ltsugar.m4' libtoolize: copying file 'm4/ltversion.m4' libtoolize: copying file 'm4/lt~obsolete.m4' autoreconf: running: intltoolize --copy --force autoreconf: running: gtkdocize --copy grep: Warnung: überzähliges \ vor , grep: Warnung: überzähliges \ vor einem Leerzeichen autoreconf: running: aclocal --force -I m4 ${ACLOCAL_FLAGS} autoreconf: running: /usr/bin/autoconf --force autoreconf: running: /usr/bin/autoheader --force autoreconf: running: automake --add-missing --copy --force-missing configure.ac:66: installing './compile' configure.ac:52: installing './config.guess' configure.ac:52: installing './config.sub' configure.ac:58: installing './install-sh' configure.ac:58: installing './missing' examples/tex-open-terminal/Makefile.am: installing './depcomp' thunar/Makefile.am:214: error: 'thunar.a' is not a standard library name thunar/Makefile.am:214: did you mean 'libthunar.a'? parallel-tests: installing './test-driver' autoreconf: Leaving directory '.' Running /home/CENSOREDNOTHING/temp/thunar_Test/thunar/configure --enable-maintainer-mode ... checking build system type... x86_64-pc-linux-gnu checking host system type... x86_64-pc-linux-gnu checking target system type... x86_64-pc-linux-gnu checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a race-free mkdir -p... /usr/bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking whether UID '1000' is supported by ustar format... yes checking whether GID '1000' is supported by ustar format... yes checking how to create a ustar tar archive... gnutar checking whether to enable maintainer-specific portions of Makefiles... yes checking whether make supports nested variables... (cached) yes checking whether make supports the include directive... yes (GNU style) checking for gcc... gcc checking whether the C compiler works... yes checking for C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether the compiler supports GNU C... yes checking whether gcc accepts -g... yes checking for gcc option to enable C11 features... none needed checking whether gcc understands -c and -o together... yes checking dependency style of gcc... gcc3 checking for stdio.h... yes checking for stdlib.h... yes checking for string.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for strings.h... yes checking for sys/stat.h... yes checking for sys/types.h... yes checking for unistd.h... yes checking for wchar.h... yes checking for minix/config.h... no checking for sys/param.h... yes checking whether it is safe to define __EXTENSIONS__... yes checking whether _XOPEN_SOURCE should be defined... no checking for library containing strerror... none required checking for gcc... (cached) gcc checking whether the compiler supports GNU C... (cached) yes checking whether gcc accepts -g... (cached) yes checking for gcc option to enable C11 features... (cached) none needed checking whether gcc understands -c and -o together... (cached) yes checking dependency style of gcc... (cached) gcc3 checking for a sed that does not truncate output... /usr/bin/sed checking for grep that handles long lines and -e... /usr/bin/grep checking for egrep... /usr/bin/grep -E checking for fgrep... /usr/bin/grep -F checking how to print strings... printf checking for ld used by gcc... /usr/bin/ld checking if the linker (/usr/bin/ld) is GNU ld... yes checking whether NLS is requested... yes checking for intltool-update... /usr/bin/intltool-update checking for intltool-merge... /usr/bin/intltool-merge checking for intltool-extract... /usr/bin/intltool-extract checking for xgettext... /usr/bin/xgettext checking for msgmerge... /usr/bin/msgmerge checking for msgfmt... /usr/bin/msgfmt checking for gmsgfmt... /usr/bin/msgfmt checking for perl... /usr/bin/perl checking for perl >= 5.8.1... 5.36.0 checking for XML::Parser... ok checking for perl5... no checking for perl... perl checking for a sed that does not truncate output... (cached) /usr/bin/sed checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B checking the name lister (/usr/bin/nm -B) interface... BSD nm checking whether ln -s works... yes checking the maximum length of command line arguments... 1572864 checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop checking for /usr/bin/ld option to reload object files... -r checking for file... file checking for objdump... objdump checking how to recognize dependent libraries... pass_all checking for dlltool... no checking how to associate runtime and link libraries... printf %s\n checking for ar... ar checking for archiver @FILE support... @ checking for strip... strip checking for ranlib... ranlib checking command to parse /usr/bin/nm -B output from gcc object... ok checking for sysroot... no checking for a working dd... /usr/bin/dd checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1 checking for mt... no checking if : is a manifest tool... no checking for dlfcn.h... yes checking for objdir... .libs checking if gcc supports -fno-rtti -fno-exceptions... no checking for gcc option to produce PIC... -fPIC -DPIC checking if gcc PIC flag -fPIC -DPIC works... yes checking if gcc static flag -static works... yes checking if gcc supports -c -o file.o... yes checking if gcc supports -c -o file.o... (cached) yes checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes checking whether -lc should be explicitly linked in... no checking dynamic linker characteristics... GNU/Linux ld.so checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes checking if libtool supports shared libraries... yes checking whether to build shared libraries... yes checking whether to build static libraries... no checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... no checking for ctype.h... yes checking for errno.h... yes checking for fcntl.h... yes checking for grp.h... yes checking for limits.h... yes checking for locale.h... yes checking for memory.h... yes checking for paths.h... yes checking for pwd.h... yes checking for sched.h... yes checking for signal.h... yes checking for stdarg.h... yes checking for stdlib.h... (cached) yes checking for string.h... (cached) yes checking for sys/mman.h... yes checking for sys/param.h... (cached) yes checking for sys/stat.h... (cached) yes checking for sys/time.h... yes checking for sys/types.h... (cached) yes checking for sys/uio.h... yes checking for sys/wait.h... yes checking for time.h... yes checking for getpagesize... yes checking for working mmap... yes checking for localeconv... yes checking for mkdtemp... yes checking for pread... yes checking for pwrite... yes checking for sched_yield... yes checking for setgroupent... no checking for setpassent... no checking for strcoll... yes checking for strlcpy... no checking for strptime... yes checking for symlink... yes checking for atexit... yes checking for realpath... yes checking for bind_textdomain_codeset... yes checking for locales directory... ${prefix}/share/locale checking how to run the C preprocessor... gcc -E checking for X... libraries , headers checking for gethostbyname... yes checking for connect... yes checking for remove... yes checking for shmat... yes checking for IceConnectionNumber in -lICE... yes checking for main in -lX11... yes checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for gtk-doc... yes checking for gtkdoc-check... gtkdoc-check.test checking for gtkdoc-check... /usr/bin/gtkdoc-check checking for gtkdoc-rebase... /usr/bin/gtkdoc-rebase checking for gtkdoc-mkpdf... /usr/bin/gtkdoc-mkpdf checking whether to build gtk-doc documentation... no checking for GTKDOC_DEPS... yes checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for exo-2 >= 4.17.0... 4.18.0 checking EXO_CFLAGS... -I/usr/include/exo-2 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/xfce4 -pthread checking EXO_LIBS... -lexo-2 -lgtk-3 -lgdk-3 -lz -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lxfce4util -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for glib-2.0 >= 2.66.0... 2.76.1 checking GLIB_CFLAGS... -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -pthread checking GLIB_LIBS... -lglib-2.0 configure: setting GLIB_VERSION_MAX_ALLOWED and GLIB_VERSION_MIN_REQUIRED according to 2.66.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for gio-2.0 >= 2.66.0... 2.76.1 checking GIO_CFLAGS... -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/libmount -I/usr/include/blkid -pthread checking GIO_LIBS... -lgio-2.0 -lgobject-2.0 -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for gthread-2.0 >= 2.66.0... 2.76.1 checking GTHREAD_CFLAGS... -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -pthread checking GTHREAD_LIBS... -lgthread-2.0 -pthread -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for gmodule-2.0 >= 2.66.0... 2.76.1 checking GMODULE_CFLAGS... -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -pthread checking GMODULE_LIBS... -Wl,--export-dynamic -lgmodule-2.0 -pthread -lglib-2.0 -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for gtk+-3.0 >= 3.24.0... 3.24.37 checking GTK_CFLAGS... -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -pthread checking GTK_LIBS... -lgtk-3 -lgdk-3 -lz -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for gdk-pixbuf-2.0 >= 2.40.0... 2.42.10 checking GDK_PIXBUF_CFLAGS... -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -pthread checking GDK_PIXBUF_LIBS... -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for libxfce4util-1.0 >= 4.17.2... 4.18.1 checking LIBXFCE4UTIL_CFLAGS... -I/usr/include/xfce4 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -pthread checking LIBXFCE4UTIL_LIBS... -lxfce4util -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for libxfce4ui-2 >= 4.17.6... 4.18.2 checking LIBXFCE4UI_CFLAGS... -I/usr/include/xfce4/libxfce4ui-2 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/xfce4 -pthread checking LIBXFCE4UI_LIBS... -lxfce4ui-2 -lgtk-3 -lgdk-3 -lz -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lxfce4util -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for libxfce4kbd-private-3 >= 4.17.2... 4.18.2 checking LIBXFCE4KBD_PRIVATE_CFLAGS... -I/usr/include/xfce4/libxfce4kbd-private-3 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/xfce4 -I/usr/include/xfce4/xfconf-0 -I/usr/include/xfce4/libxfce4ui-2 -pthread checking LIBXFCE4KBD_PRIVATE_LIBS... -lxfce4kbd-private-3 -lxfconf-0 -lxfce4ui-2 -lgtk-3 -lgdk-3 -lz -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lxfce4util -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for libxfconf-0 >= 4.12.0... 4.18.0 checking XFCONF_CFLAGS... -I/usr/include/xfce4/xfconf-0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/libmount -I/usr/include/blkid -pthread checking XFCONF_LIBS... -lxfconf-0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for pango >= 1.38.0... 1.50.14 checking PANGO_CFLAGS... -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -pthread -I/usr/include/pixman-1 checking PANGO_LIBS... -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lharfbuzz checking for gobject-introspection... yes checking for SmcSaveYourselfDone in -lSM... yes checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for gio-unix-2.0 >= 2.66.0... 2.76.1 checking GIO_UNIX_CFLAGS... -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/libmount -I/usr/include/blkid -pthread checking GIO_UNIX_LIBS... -lgio-2.0 -lgobject-2.0 -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for gudev-1.0 >= 145... 237 checking GUDEV_CFLAGS... -I/usr/include/gudev-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -pthread checking GUDEV_LIBS... -lgudev-1.0 -lgobject-2.0 -lglib-2.0 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for libnotify >= 0.4.0... 0.8.2 checking LIBNOTIFY_CFLAGS... -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -pthread checking LIBNOTIFY_LIBS... -lnotify -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 checking whether to build with debugging support... yes checking if gcc supports -Wall... yes checking if gcc supports -Wextra... yes checking if gcc supports -Wno-missing-field-initializers... yes checking if gcc supports -Wno-unused-parameter... yes checking if gcc supports -Wmissing-declarations... yes checking if gcc supports -Wmissing-noreturn... yes checking if gcc supports -Wpointer-arith... yes checking if gcc supports -Wcast-align... yes checking if gcc supports -Wformat... yes checking if gcc supports -Wformat-security... yes checking if gcc supports -Wformat-y2k... yes checking if gcc supports -Winit-self... yes checking if gcc supports -Wmissing-include-dirs... yes checking if gcc supports -Wundef... yes checking if gcc supports -Wredundant-decls... yes checking if gcc supports -fstack-protector... yes checking if gcc supports -g... yes checking if gcc supports -Wshadow... yes checking if gcc supports -Wdeclaration-after-statement... yes checking if gcc supports -Wnested-externs... yes checking if gcc supports -Wold-style-definition... yes checking if gcc supports -Wall... yes checking if gcc supports -Wextra... yes checking if gcc supports -Wno-missing-field-initializers... yes checking if gcc supports -Wno-unused-parameter... yes checking if gcc supports -Wmissing-declarations... yes checking if gcc supports -Wmissing-noreturn... yes checking if gcc supports -Wpointer-arith... yes checking if gcc supports -Wcast-align... yes checking if gcc supports -Wformat... yes checking if gcc supports -Wformat-security... yes checking if gcc supports -Wformat-y2k... yes checking if gcc supports -Winit-self... yes checking if gcc supports -Wmissing-include-dirs... yes checking if gcc supports -Wundef... yes checking if gcc supports -Wredundant-decls... yes checking if gcc supports -fstack-protector... yes checking if gcc supports -g... yes checking if gcc supports -Wshadow... yes checking whether /usr/bin/ld -m elf_x86_64 accepts --as-needed... yes checking whether /usr/bin/ld -m elf_x86_64 accepts -O1... yes checking PLATFORM_CPPFLAGS... checking PLATFORM_CFLAGS... checking PLATFORM_LDFLAGS... checking whether to build the thunar-apr plugin... yes checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for libexif >= 0.6.0... 0.6.24 checking EXIF_CFLAGS... checking EXIF_LIBS... -lexif checking whether to build the thunar-sbr plugin... yes checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for libpcre2-8 >= 10.0... 10.42 checking PCRE2_CFLAGS... checking PCRE2_LIBS... -lpcre2-8 checking for pkg-config... (cached) /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for libxfce4panel-2.0 >= 4.12.0... 4.18.2 checking LIBXFCE4PANEL_CFLAGS... -I/usr/include/xfce4/libxfce4panel-2.0 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/xfce4 -pthread checking LIBXFCE4PANEL_LIBS... -lxfce4panel-2.0 -lgtk-3 -lgdk-3 -lz -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lglib-2.0 -lxfce4util -lglib-2.0 checking whether to build the thunar-tpa plugin... yes checking whether to build the thunar-uca plugin... yes checking whether to build the thunar-wallpaper plugin... yes checking for xfconf-query... yes checking that generated files are newer than configure... done configure: creating ./config.status config.status: creating Makefile config.status: creating docs/Makefile config.status: creating docs/design/Makefile config.status: creating docs/papers/Makefile config.status: creating docs/reference/Makefile config.status: creating docs/reference/thunarx/Makefile config.status: creating docs/reference/thunarx/version.xml config.status: creating docs/reference/thunar/Makefile config.status: creating docs/reference/thunar/version.xml config.status: creating examples/Makefile config.status: creating examples/tex-open-terminal/Makefile config.status: creating icons/Makefile config.status: creating icons/16x16/Makefile config.status: creating icons/24x24/Makefile config.status: creating icons/48x48/Makefile config.status: creating icons/128x128/Makefile config.status: creating icons/scalable/Makefile config.status: creating plugins/Makefile config.status: creating plugins/thunar-apr/Makefile config.status: creating plugins/thunar-sbr/Makefile config.status: creating plugins/thunar-sendto-email/Makefile config.status: creating plugins/thunar-tpa/Makefile config.status: creating plugins/thunar-uca/Makefile config.status: creating plugins/thunar-wallpaper/Makefile config.status: creating po/Makefile.in config.status: creating thunar/Makefile config.status: creating thunarx/Makefile config.status: creating thunarx/thunarx-3.pc config.status: creating thunarx/thunarx-config.h config.status: creating config.h config.status: executing depfiles commands config.status: executing libtool commands config.status: executing po/stamp-it commands Build Configuration: * GIO UNIX features: yes * GUDev (required for thunar-volman): yes * Mount notification support: yes * Debug Support: yes * GObject Instrospection support: yes Additional Plugins: * Advanced Properties: yes * Simple Builtin Renamers: yes * Trash Panel Applet: yes * User Customizable Actions: yes * Wallpaper support: yes Now type "make" to compile.but then make produces the same error
Edited by Alexander Schwinn-
Edited your answer to collapse the output, in order to keep the issue readable.
Hmm, not sure what is wrong for your build
-
make cleanto remove old stuff (or a fresh git clone in a new folder) - Make sure that you have the latest xfce-dev-tools installed (there were some changes on the Makefile recently which make use of new dev-tools makros .. though in theory the version of dev-tools should be checked in -/autogen.sh)
Edited by Alexander Schwinn -
Hi Alexander @alexxcons, sorry I took so long to respond, you're putting in effort and here I am, forgetting...
So today I made both your patches work with latest master on my own fork, they work flawlessly!
- start copy job 1 A -> B
- start copy job 2 C -> B: gets queued, starts when job 1 is done
- start copy job 3 B -> D: gets queued, starts when job 2 is done
Also, I added the only-when-idle mode instead of replacing it, so you get to keep only-same-device-mode.
But I had to use my launcher since the translations are missing, system laungae is not english for me and from what I can tell, they appear to be auto-generated.
Or would we need to add anything manually?
With the launcher it works fine.
Should I do the merge request or do you want to?
Of course the work was all done by you and I'd state that.The compile errors (Manjaro) werse solved by replacing
xfce4-dev-toolsandlibxfce4utilwithlibxfce4util-develandxfce4-dev-tools-develfrom AUR (version missmatch to thunar source).Edited by recallmenot-
Sorry for the late reply. Glad you got it to build, thanks a lot for testing!
Your changes look good to me! Please go ahead and open a MR with them!
But I had to use my launcher since the translations are missing, system laungae is not english for me and from what I can tell, they appear to be auto-generated.
There are translators for most languages which will do the translations, once the MR got merged into master. So there is nothing special we need to do about it. (Prefixing a string with underscore, e.g.
_("this will be translated")will trigger translations)Edited by Alexander Schwinn Fantastic!
I just started MR 371.
Thank you!
mentioned in merge request !371 (merged)
mentioned in commit 65d3f570
changed milestone to %4.19.0
mentioned in issue #467 (closed)
