[Wayland] Thunar crashes when using a custom action with startup notification enabled

Alexander Schwinn @alexxcons said:

Thanks for reporting !

I' ll have a look when I have time.

Alexander Schwinn @alexxcons said:

moved to libxfce4ui, since xfce_spawn_on_screen_with_child_watch is defined there

Alexander Schwinn @alexxcons submitted a patch:

The crashing "sn_display_new" is part of the optional library "libstartup-notification".

Theoretically it should be sufficient to just drop the dependency to "libstartup-notification", since gtk meanwhile seem to be able to handle that on its own: https://developer.gnome.org/integration-guide/stable/startup-notification.html.en https://developer.gnome.org/gdk3/stable/gdk3-General.html#gdk-notify-startup-complete

Practically as far as I can tell, this seems not to work for processes started via 'g_spawn_async'.

Theoretically "libstartup-notification" is optional, you can take a try to just uninstall the package ... practically it seems to be used by many other packages :/

Another possible fix is to just dont do startup notifications in wayland, and instead print a warning into console (if thunar runs from console) ... thats what I tried to do in the attached patch.

So far I did not try to run wayland at my own .. though afaik checking for "XDG_SESSION_TYPE" == "wayland" seems to work as a probe. See: https://git.xfce.org/xfce/thunar/commit/?id=660d9ceb8509ef82fe3a4a0287014010286bf12c

Please take a try for the attached patch if you can, and let me know if it worked ! (You will need to build libxfce4ui from source, install it, and restart thunar with thunar -q;thunar)

Patch 9814, "prevent crash by disable feature":
0001-disable-startup-notification-in-wayland-to-prevent-c.patch