2.0.0: compile time warnings
gcc 10.1.1
verve-env.c: In function 'verve_env_init':
verve-env.c:135:3: warning: 'g_thread_create_full' is deprecated: Use 'g_thread_new' instead [-Wdeprecated-declarations]
135 | env->load_thread = g_thread_create_full (verve_env_load_thread, env, 0, TRUE, FALSE, G_THREAD_PRIORITY_LOW, NULL);
| ^~~
In file included from /usr/include/glib-2.0/glib.h:111,
from /usr/include/glib-2.0/gobject/gbinding.h:28,
from /usr/include/glib-2.0/glib-object.h:22,
from verve-env.h:27,
from verve-env.c:28:
/usr/include/glib-2.0/glib/deprecated/gthread.h:106:10: note: declared here
106 | GThread *g_thread_create_full (GThreadFunc func,
| ^~~~~~~~~~~~~~~~~~~~
verve.c: In function 'verve_is_directory':
verve.c:365:16: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
365 | return to_return;
| ^~~~~~~~~
verve-plugin.c: In function 'verve_plugin_load_completion':
verve-plugin.c:117:5: warning: 'g_completion_add_items' is deprecated [-Wdeprecated-declarations]
117 | g_completion_add_items (verve->completion, items);
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/glib.h:108,
from verve-plugin.c:31:
/usr/include/glib-2.0/glib/deprecated/gcompletion.h:60:14: note: declared here
60 | void g_completion_add_items (GCompletion* cmp,
| ^~~~~~~~~~~~~~~~~~~~~~
verve-plugin.c: In function 'verve_plugin_focus_timeout':
verve-plugin.c:137:3: warning: 'gtk_widget_get_style' is deprecated: Use 'gtk_widget_get_style_context' instead [-Wdeprecated-declarations]
137 | style = gtk_widget_get_style (verve->input);
| ^~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:277,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkstyle.h:742:13: note: declared here
742 | GtkStyle * gtk_widget_get_style (GtkWidget *widget);
| ^~~~~~~~~~~~~~~~~~~~
verve-plugin.c:131:12: warning: unused variable 'c' [-Wunused-variable]
131 | GdkColor c;
| ^
verve-plugin.c:130:13: warning: variable 'style' set but not used [-Wunused-but-set-variable]
130 | GtkStyle *style;
| ^~~~~
verve-plugin.c: In function 'verve_plugin_focus_timeout_reset':
verve-plugin.c:148:12: warning: unused variable 'c' [-Wunused-variable]
148 | GdkColor c;
| ^
verve-plugin.c:147:13: warning: unused variable 'style' [-Wunused-variable]
147 | GtkStyle *style;
| ^~~~~
verve-plugin.c: In function 'verve_plugin_keypress_cb':
verve-plugin.c:439:9: warning: 'g_completion_complete' is deprecated [-Wdeprecated-declarations]
439 | similar = g_completion_complete (completion, prefix, NULL);
| ^~~~~~~
In file included from /usr/include/glib-2.0/glib.h:108,
from verve-plugin.c:31:
/usr/include/glib-2.0/glib/deprecated/gcompletion.h:68:14: note: declared here
68 | GList* g_completion_complete (GCompletion* cmp,
| ^~~~~~~~~~~~~~~~~~~~~
verve-plugin.c: In function 'verve_plugin_new':
verve-plugin.c:501:3: warning: 'g_completion_new' is deprecated [-Wdeprecated-declarations]
501 | verve->completion = g_completion_new (NULL);
| ^~~~~
In file included from /usr/include/glib-2.0/glib.h:108,
from verve-plugin.c:31:
/usr/include/glib-2.0/glib/deprecated/gcompletion.h:58:14: note: declared here
58 | GCompletion* g_completion_new (GCompletionFunc func);
| ^~~~~~~~~~~~~~~~
verve-plugin.c:529:3: warning: 'gtk_hbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
529 | GtkWidget *hbox = gtk_hbox_new (FALSE, 0);
| ^~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:262,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:63:13: note: declared here
63 | GtkWidget * gtk_hbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:545:85: warning: passing argument 2 of 'gtk_style_context_add_provider' from incompatible pointer type [-Wincompatible-pointer-types]
545 | gtk_style_context_add_provider (gtk_widget_get_style_context (verve->input), verve->input_css, GTK_STYLE_PROVIDER_PRIORITY_SETTINGS);
| ~~~~~^~~~~~~~~~~
| |
| GtkCssProvider * {aka struct _GtkCssProvider *}
In file included from /usr/include/gtk-3.0/gtk/gtkicontheme.h:27,
from /usr/include/gtk-3.0/gtk/gtk.h:127,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/gtkstylecontext.h:1034:59: note: expected 'GtkStyleProvider *' {aka 'struct _GtkStyleProvider *'} but argument is of type 'GtkCssProvider *' {aka 'struct _GtkCssProvider *'}
1034 | GtkStyleProvider *provider,
| ~~~~~~~~~~~~~~~~~~^~~~~~~~
verve-plugin.c: In function 'verve_plugin_free':
verve-plugin.c:578:3: warning: 'g_completion_free' is deprecated [-Wdeprecated-declarations]
578 | g_completion_free (verve->completion);
| ^~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/glib.h:108,
from verve-plugin.c:31:
/usr/include/glib-2.0/glib/deprecated/gcompletion.h:79:14: note: declared here
79 | void g_completion_free (GCompletion* cmp);
| ^~~~~~~~~~~~~~~~~
verve-plugin.c: In function 'verve_plugin_update_label':
verve-plugin.c:629:27: warning: passing argument 1 of 'gtk_label_set_text' from incompatible pointer type [-Wincompatible-pointer-types]
629 | gtk_label_set_text(verve->label, label);
| ~~~~~^~~~~~~
| |
| GtkWidget * {aka struct _GtkWidget *}
In file included from /usr/include/gtk-3.0/gtk/gtkaccellabel.h:35,
from /usr/include/gtk-3.0/gtk/gtk.h:33,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/gtklabel.h:95:67: note: expected 'GtkLabel *' {aka 'struct _GtkLabel *'} but argument is of type 'GtkWidget *' {aka 'struct _GtkWidget *'}
95 | void gtk_label_set_text (GtkLabel *label,
| ~~~~~~~~~~~~~~~^~~~~
verve-plugin.c: In function 'verve_plugin_update_colors':
verve-plugin.c:659:65: warning: passing argument 1 of 'g_io_stream_get_output_stream' from incompatible pointer type [-Wincompatible-pointer-types]
659 | GOutputStream *output_stream = g_io_stream_get_output_stream (tmp_file_stream);
| ^~~~~~~~~~~~~~~
| |
| GFileIOStream * {aka struct _GFileIOStream *}
In file included from /usr/include/glib-2.0/gio/gfileiostream.h:28,
from /usr/include/glib-2.0/gio/gio.h:83,
from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:28,
from /usr/include/gtk-3.0/gdk/gdk.h:32,
from /usr/include/gtk-3.0/gtk/gtk.h:30,
from verve-plugin.c:33:
/usr/include/glib-2.0/gio/giostream.h:92:69: note: expected 'GIOStream *' {aka 'struct _GIOStream *'} but argument is of type 'GFileIOStream *' {aka 'struct _GFileIOStream *'}
92 | GOutputStream *g_io_stream_get_output_stream (GIOStream *stream);
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
verve-plugin.c:686:22: warning: passing argument 1 of 'g_io_stream_close' from incompatible pointer type [-Wincompatible-pointer-types]
686 | g_io_stream_close (tmp_file_stream, NULL, NULL);
| ^~~~~~~~~~~~~~~
| |
| GFileIOStream * {aka struct _GFileIOStream *}
In file included from /usr/include/glib-2.0/gio/gfileiostream.h:28,
from /usr/include/glib-2.0/gio/gio.h:83,
from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:28,
from /usr/include/gtk-3.0/gdk/gdk.h:32,
from /usr/include/gtk-3.0/gtk/gtk.h:30,
from verve-plugin.c:33:
/usr/include/glib-2.0/gio/giostream.h:108:69: note: expected 'GIOStream *' {aka 'struct _GIOStream *'} but argument is of type 'GFileIOStream *' {aka 'struct _GFileIOStream *'}
108 | gboolean g_io_stream_close (GIOStream *stream,
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
verve-plugin.c: In function 'verve_plugin_read_rc_file':
verve-plugin.c:786:13: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
786 | label = xfce_rc_read_entry (rc, "label", label);
| ^
verve-plugin.c:789:20: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
789 | fg_color_str = xfce_rc_read_entry (rc, "foreground-color", fg_color_str);
| ^
verve-plugin.c:790:20: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
790 | bg_color_str = xfce_rc_read_entry (rc, "background-color", bg_color_str);
| ^
verve-plugin.c:791:22: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
791 | base_color_str = xfce_rc_read_entry (rc, "base-color", base_color_str);
| ^
verve-plugin.c:807:25: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
807 | smartbookmark_url = xfce_rc_read_entry (rc, "smartbookmark-url", smartbookmark_url);
| ^
verve-plugin.c: In function 'verve_plugin_write_rc_file':
verve-plugin.c:860:65: warning: passing argument 1 of 'gtk_label_get_text' from incompatible pointer type [-Wincompatible-pointer-types]
860 | xfce_rc_write_entry (rc, "label", gtk_label_get_text(verve->label));
| ~~~~~^~~~~~~
| |
| GtkWidget * {aka struct _GtkWidget *}
In file included from /usr/include/gtk-3.0/gtk/gtkaccellabel.h:35,
from /usr/include/gtk-3.0/gtk/gtk.h:33,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/gtklabel.h:98:67: note: expected 'GtkLabel *' {aka 'struct _GtkLabel *'} but argument is of type 'GtkWidget *' {aka 'struct _GtkWidget *'}
98 | const gchar* gtk_label_get_text (GtkLabel *label);
| ~~~~~~~~~~~~~~~^~~~~
verve-plugin.c: In function 'verve_plugin_properties':
verve-plugin.c:1132:49: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
1132 | GTK_STOCK_CLOSE, GTK_RESPONSE_OK,
| ^~~~~~~~~~~~~~~
verve-plugin.c:1151:3: warning: 'gtk_vbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
1151 | general_vbox = gtk_vbox_new (FALSE, 8);
| ^~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:286,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:61:13: note: declared here
61 | GtkWidget * gtk_vbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:1163:3: warning: 'gtk_vbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
1163 | vbox = gtk_vbox_new (FALSE, 8);
| ^~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:286,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:61:13: note: declared here
61 | GtkWidget * gtk_vbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:1168:3: warning: 'gtk_hbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
1168 | hbox = gtk_hbox_new (FALSE, 8);
| ^~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:262,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:63:13: note: declared here
63 | GtkWidget * gtk_hbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:1178:14: warning: assignment to 'GObject *' {aka 'struct _GObject *'} from incompatible pointer type 'GtkAdjustment *' {aka 'struct _GtkAdjustment *'} [-Wincompatible-pointer-types]
1178 | adjustment = gtk_adjustment_new (verve->size, 5, 300, 1, 5, 0);
| ^
verve-plugin.c:1193:3: warning: 'gtk_hbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
1193 | hbox = gtk_hbox_new (FALSE, 8);
| ^~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:262,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:63:13: note: declared here
63 | GtkWidget * gtk_hbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:1221:3: warning: 'gtk_vbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
1221 | vbox = gtk_vbox_new (FALSE, 8);
| ^~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:286,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:61:13: note: declared here
61 | GtkWidget * gtk_vbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:1226:3: warning: 'gtk_hbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
1226 | hbox = gtk_hbox_new (FALSE, 8);
| ^~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:262,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:63:13: note: declared here
63 | GtkWidget * gtk_hbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:1250:3: warning: 'gtk_hbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
1250 | hbox = gtk_hbox_new (FALSE, 8);
| ^~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:262,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:63:13: note: declared here
63 | GtkWidget * gtk_hbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:1280:3: warning: 'gtk_vbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
1280 | vbox = gtk_vbox_new (FALSE, 8);
| ^~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:286,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:61:13: note: declared here
61 | GtkWidget * gtk_vbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:1285:3: warning: 'gtk_hbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
1285 | hbox = gtk_hbox_new (FALSE, 8);
| ^~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:262,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:63:13: note: declared here
63 | GtkWidget * gtk_hbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:1295:14: warning: assignment to 'GObject *' {aka 'struct _GObject *'} from incompatible pointer type 'GtkAdjustment *' {aka 'struct _GtkAdjustment *'} [-Wincompatible-pointer-types]
1295 | adjustment = gtk_adjustment_new (verve->history_length, 0, 1000, 1, 5, 0);
| ^
verve-plugin.c:1318:3: warning: 'gtk_vbox_new' is deprecated: Use 'gtk_box_new' instead [-Wdeprecated-declarations]
1318 | command_types_vbox = gtk_vbox_new (FALSE, 0);
| ^~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:286,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:61:13: note: declared here
61 | GtkWidget * gtk_vbox_new (gboolean homogeneous,
| ^~~~~~~~~~~~
verve-plugin.c:1324:3: warning: 'gtk_misc_set_alignment' is deprecated [-Wdeprecated-declarations]
1324 | gtk_misc_set_alignment (GTK_MISC (command_types_label1), 0, 0.5);
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtklabel.h:32,
from /usr/include/gtk-3.0/gtk/gtkaccellabel.h:35,
from /usr/include/gtk-3.0/gtk/gtk.h:33,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:72:6: note: declared here
72 | void gtk_misc_set_alignment (GtkMisc *misc,
| ^~~~~~~~~~~~~~~~~~~~~~
verve-plugin.c:1353:3: warning: 'gtk_alignment_new' is deprecated [-Wdeprecated-declarations]
1353 | alignment = gtk_alignment_new (1, 1, 1, 1);
| ^~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:255,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:79:12: note: declared here
79 | GtkWidget* gtk_alignment_new (gfloat xalign,
| ^~~~~~~~~~~~~~~~~
verve-plugin.c:1354:3: warning: 'gtk_alignment_set_padding' is deprecated [-Wdeprecated-declarations]
1354 | gtk_alignment_set_padding (GTK_ALIGNMENT (alignment), 0, 0, 24, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:255,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:91:12: note: declared here
91 | void gtk_alignment_set_padding (GtkAlignment *alignment,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
verve-plugin.c:1385:3: warning: 'gtk_misc_set_alignment' is deprecated [-Wdeprecated-declarations]
1385 | gtk_misc_set_alignment (GTK_MISC (command_types_label2), 0, 0.5);
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtklabel.h:32,
from /usr/include/gtk-3.0/gtk/gtkaccellabel.h:35,
from /usr/include/gtk-3.0/gtk/gtk.h:33,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:72:6: note: declared here
72 | void gtk_misc_set_alignment (GtkMisc *misc,
| ^~~~~~~~~~~~~~~~~~~~~~
verve-plugin.c:1399:3: warning: 'gtk_alignment_new' is deprecated [-Wdeprecated-declarations]
1399 | alignment = gtk_alignment_new (1, 1, 1, 1);
| ^~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:255,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:79:12: note: declared here
79 | GtkWidget* gtk_alignment_new (gfloat xalign,
| ^~~~~~~~~~~~~~~~~
verve-plugin.c:1400:3: warning: 'gtk_alignment_set_padding' is deprecated [-Wdeprecated-declarations]
1400 | gtk_alignment_set_padding (GTK_ALIGNMENT (alignment), 8, 8, 24, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:255,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:91:12: note: declared here
91 | void gtk_alignment_set_padding (GtkAlignment *alignment,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
verve-plugin.c:1420:3: warning: 'gtk_alignment_new' is deprecated [-Wdeprecated-declarations]
1420 | alignment = gtk_alignment_new (1, 1, 1, 1);
| ^~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:255,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:79:12: note: declared here
79 | GtkWidget* gtk_alignment_new (gfloat xalign,
| ^~~~~~~~~~~~~~~~~
verve-plugin.c:1421:3: warning: 'gtk_alignment_set_padding' is deprecated [-Wdeprecated-declarations]
1421 | gtk_alignment_set_padding (GTK_ALIGNMENT (alignment), 0, 0, 24, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:255,
from verve-plugin.c:33:
/usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:91:12: note: declared here
91 | void gtk_alignment_set_padding (GtkAlignment *alignment,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
verve-plugin.c:1120:14: warning: unused variable 'color_str' [-Wunused-variable]
1120 | gchar *color_str;
| ^~~~~~~~~
verve-plugin.c: At top level:
verve-plugin.c:1468:1: warning: data definition has no type or storage class
1468 | XFCE_PANEL_PLUGIN_REGISTER (verve_plugin_construct);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
verve-plugin.c:1468:1: warning: type defaults to 'int' in declaration of 'XFCE_PANEL_PLUGIN_REGISTER' [-Wimplicit-int]
verve-plugin.c:1468:1: warning: parameter names (without types) in function declaration
verve-plugin.c:1440:1: warning: 'verve_plugin_construct' defined but not used [-Wunused-function]
1440 | verve_plugin_construct (XfcePanelPlugin *plugin)
| ^~~~~~~~~~~~~~~~~~~~~~
verve-plugin.c:128:1: warning: 'verve_plugin_focus_timeout' defined but not used [-Wunused-function]
128 | verve_plugin_focus_timeout (VervePlugin *verve)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~