No horizontal alignment in vertical panel

Submitted by rob..@..il.com

Assigned to Andrzej

Link to original bug (#15572)

Description

Created attachment 8622 Screenshot

Hi, since my xfce4-places-plugin has been updated from 1.7.0 to 1.8.0, it looks weird when placed in a vertical panel. It's not horizontally aligned as you can see in the screenshot. Thank you.

Attachment 8622, "Screenshot":

Version: 1.8.0

Andre Miranda @andreldm said:

I can reproduce with Adwaita, but not with greybird. git bisect reveals this issue was introduce by this commit: https://git.xfce.org/panel-plugins/xfce4-places-plugin/commit/?id=549855a

Andre Miranda @andreldm said:

I have added printfs to both ways of getting the image_size and removed the conditional macros. When using xfce_panel_plugin_get_icon_size the prefix is "size1", while border thickness is prefixed with "size2".

Output when using Greybird:

size1: 12
size2: 14
size1: 12
size2: 14
size1: 12
size2: 12
size1: 12
size2: 12
size1: 32
size2: 34

Output when using Adwaita:

size1: 12
size2: 14
size1: 12
size2: 14
size1: 12
size2: -4
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
size1: 12
size2: -4
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
(wrapper-2.0:21837): libxfce4panel-CRITICAL **: 10:12:21.685: IA__xfce_panel_pixbuf_from_source_at_size: assertion 'dest_width > 0' failed
size1: 32
size2: 18

mentioned in issue #31 (closed)

added 1. Regression label

added 5. Tray Icon / Label 5. Vertical / Deskbar Panel 5. Visual Appearance labels

mentioned in issue #38 (closed)

marked #38 (closed) as a duplicate of this issue

marked this issue as related to #38 (closed)

assigned to @Tamaranch

changed milestone to %1.8.4

closed with commit 83186362

marked #31 (closed) as a duplicate of this issue

marked this issue as related to #31 (closed)