[Suggestion] Separate icons for app and panel
Submitted by Spass
Assigned to Mike Massonnet
Description
Created attachment 7855 (just in case link from the post doesn't work)
Hello, currently xfce4-notes-plugin (1.8.1) uses the same icon as xfce4-notes application, so the icon named "xfce4-notes-plugin". This is in my opinion wrong behaviour and those icons should be separated. Many modern and popular icon themes are displaying those icons incorrectly, the only icon set I could find that managed to do it properly is Xubuntu's elementary-xfce, but ochosi used some "Kung Fu" workaround to achieve that ;) Most icon theme creators don't know how to handle that situation and I can't blame them. See this screen - https://ibb.co/nPXxrK
My suggestion:
- xfce4-notes application (entry visible in the Whisker Menu) should use icon named "xfce4-notes", with a fallback to "xfce4-notes-plugin" if possible
- xfce4-notes-plugin (so the icon visible on the panel) should use icon named "xfce4-notes-plugin" (so no changes here)
...so if I'm not mistaken, the only change needed is to change xfce4-notes.desktop "Icon=xfce4-notes-plugin" to "Icon=xfce4-notes" and inform about that in the changelog. https://git.xfce.org/panel-plugins/xfce4-notes-plugin/tree/src/xfce4-notes.desktop.in
The other option is (possibly? I'm not a dev...) to change - image = new Xfce.PanelImage.from_source ("xfce4-notes-plugin"); to something like - image = new Xfce.PanelImage.from_source ("xfce4-notes-plugin-panel","xfce4-notes-plugin"); here https://git.xfce.org/panel-plugins/xfce4-notes-plugin/tree/src/main-panel-plugin.vala to not break current themes, then the icon theme creators could just add new icon "xfce4-notes-plugin-panel" to change the panel icon.
That would make things much easier for theme creators. Many users (me included) want their tray icons to be monochrome and consistent.
Attachment 7855, "(just in case link from the post doesn't work)":
