GitBot (54bf79ba) at 08 Feb 23:52
I18n: Update translation it (100%).
GitBot (0a16581f) at 17 Oct 10:50
I18n: Update translation pt_BR (100%).
GitBot (4344c580) at 09 Jul 19:42
I18n: Update translation ca (100%).
No, you don't have to: contrary to its name, the warning doesn't tell you that the function is deprecated, but that you should bump the glib version if you want to use it (which I did in the patch). See the doc of GLIB_VERSION_MAX_ALLOWED
:)
and ofc, you are correct about g_binding_unbind
being deprecated. I shall look for alternatives.
My bad, I was looking into gtk_container_foreach_full
the other night... sorry for this.
I will do a complete patch and submit. Thanks again @Tamaranch
apart for the
g_object_set_data_full
which is deprecated.
No it isn't, but maybe you have a deprecation warning because of g_binding_unbind()
. I bumped glib in the patch but you have to reconfigure for it to take effect.
1st - thanks for the correct cpu = cpuFreq->cpus.size()
I've neglected. My bad.
Regarding your binding
patch - It's perfect, apart for the g_object_set_data_full
which is deprecated. I will look into the logic and adopt it to the sliders, and will push a patch later tonight.
Not sure I understand what you mean. This is what I would do for governors, the other settings don't show up for me or are grayed out, so I can't test them. This patch also fixes the occurrences of cpu = cpuFreq->cpus.size();
that you didn't fix and the GtkSwitch::state-set
signal handler prototype that causes the widget to be drawn incorrectly.
k, added change_all_cpus
persistent option.
as for refreshing the widgets - whats your preferred method?
Some other issues:
It goes a step too far if all == TRUE
:
cpufreq-service[23407]: Failed to write to /sys/devices/system/cpu/cpu2/cpufreq/scaling_governor: Failed to open file “/sys/devices/system/cpu/cpu2/cpufreq/scaling_governor”: No such file or directory
Maybe
if (all)
cpu = cpuFreq->cpus.size();
should be replaced with
if (all)
cpu = cpuFreq->cpus.size() - 1;
in xfce4-cpufreq-overview.cc
.
static void
And the prototypes above could be removed.
done with latest refactor.
GitBot (221c7522) at 01 May 23:00
I18n: Update translation en_GB (100%).
We can leave it like that, it can always be changed later if it is a problem. But you should use xfce_dialog_show_error()
instead (from libxfce4ui).
Since we're playing with this code for so long, I'm feeling more comfortable to make the appropriate changes. I need to think of a better UI since adding a slider to each CPU seems cumbersome, also need to take into account changing the All CPUs
to a simple on/off switch - so any change to any CPU should apply to All CPUs
. And finally, I've added energy_performance_preference
and it's accompanying energy_performance_available_preferences
, which just makes the UI even more bloated. All & All, I enjoy playing with the code atm while making this basic changes (hopefully) approved by mainstream
I understand. However, I rather separate the error handling from the low-level function and let the UI deal with it... Ofc moving it back to call_dbus_func
simplify things, but I dunno if that's the correct method. Just had to say my piece before letting you decide
If the error dialog is removed, warnings may be displayed above and the error released before returning FALSE
(unless it is no longer necessary to return a boolean).