Great, then I'll wait for that instead of updating OpenBSD's package to a git commit or cherry-picking the MR.
Klemens Nanni (a8e600e9) at 16 Nov 23:14
Fixed, thanks.
Klemens Nanni (a8e600e9) at 16 Nov 23:02
treat DICT server port property as string not integer
I run my own server, specified localhost
which resolves to ::1
and it failed to connect.
There is no helpful error message, so after a little tracing it showed xfce4-dict is still IPv4-only.
Fix that.
Klemens Nanni (cc2b2da0) at 12 Nov 18:39
treat DICT server port property as string not integer
... and 1 more commit
Sure, will do -- it was not immediately clear to me how to proceed, thanks.
Sure, thanks for looking into it.
I maintain the net/tdesktop port on OpenBSD and have never experienced such Telegram Desktop related crashes in any Xfce component.
I also don't see tdesktop crashing on close, regardless of the DE/WM.
Running on OpenBSD/amd64 7.2-current with tdesktop-4.5.8
and xfce-4.18
.
No, I still prefer the compile-time check.
As of today, afaict, there is no viable logind implementation ported to and running on BSDs.
Tested on OpenBSD where I noticed the following in ~/.xsession-errors
:
libclock-Message: 19:21:58.855: logind not active
If the primary selection changes after the dialogue window appears and before the paste action is confirmed, new/unknown data is pasted rather than what is presented in the dialogue's preview.
This seems like a classic TOCTOU issue: the dialogue inspects the selection/clipboard content once, displays it in the window and then rereads selection/clipboard contents again to actually paster.
Found by pausing work in one terminal, selecting text with the mouse in another window, then going back to the terminal and confirming the paste.
I'd argue that the "Unsafe Paste" dialogue should either abort pasting new/unknown data or save the initial data and paste that, regardless of selection/clipboard content at the time of confirmation.
Attached are two screenshots that illustrate the issue.
printf '%s\n' 1 2 | xclip -i
is used to fill the clipboard, middle-mouse click is used to paste in the same terminal.
The dialogue appears, I open another terminal and select something else (triple-click on the line), then confirm the paste.
Oops.
Feel free to mop them up (maintainers can edit this PR).