Done!
Window snapping on portrait-oriented monitors currently doesn't provide a good user experience: the snapping areas left and right are not really useful in practice. I suggest that we rotate the snapping areas for portrait mode: have the top and bottom snapping regions each tile to the top and bottom half, whereas left and right maximize the window. IMHO, this makes the snapping feature significantly more useful in practice.
Behavior for unrotated monitors remains unchanged. If you're not comfortable with changing the default here, we could also make this inversion opt-in via a setting. Personally I believe the new behavior to be the saner default, though.
Latest master (c32cdbba) currently fails to build with
xfwm4-settings.c:51:10: fatal error: xfwm4-dialog_ui.h: No such file or directory
51 | #include "xfwm4-dialog_ui.h"
| ^~~~~~~~~~~~~~~~~~~
when it was configured with --enable-compositor
.
Instruction for repro:
./autogen.sh
./configure --enable-compositor
make
It appears to be a problem with the build order. The file is present after running a regular build without enabling the compositor, but not after the (failed) build with the compositor.
Edit:
As a workaround, using the following instructions makes the build work:
./autogen.sh
make
make clean
./configure --enable-compositor
make