Skip to content

GitLab

xfce4-terminal
xfce4-terminal
Switch branch/tag
  1. 14 Jan, 2021 1 commit
  3. 04 Jan, 2021 1 commit
  5. 02 Jan, 2021 1 commit
  7. 01 Jan, 2021 1 commit
  9. 30 Dec, 2020 2 commits
  11. 29 Dec, 2020 1 commit
  13. 28 Dec, 2020 1 commit
  15. 27 Dec, 2020 2 commits
  17. 22 Dec, 2020 2 commits
  19. 19 Dec, 2020 1 commit
  21. 13 Dec, 2020 1 commit
    • Evangelos Foutras's avatar
      Stop using G_SPAWN_CHILD_INHERITS_STDIN spawn flag · 7a77c485
      Evangelos Foutras authored 
      When this flag gets passed to vte_terminal_spawn_async(), vte 0.62 warns
about it being part of the flag set returned by forbidden_spawn_flags().

Looking at the minimum required version, vte 0.38, vte itself used to
automatically add G_SPAWN_CHILD_INHERITS_STDIN to the spawn flags. It
stopped doing that in the 0.47.90 release and the commit message was:

  (GNOME/vte) commit b517d20379c7a665e897f925ca3ecb7b778364f2

  pty: Do not pass G_SPAWN_CHILD_INHERITS_STDIN

  This makes no sense at all, since we redirect stdin to the PTY anyway.
  Fixes a FIXME!

So, considering that:

  - vte used to add this flag automatically in past
  - vte dropped the flag as unnecessary in v0.47.90
  - vte 0.62 is warning about it and is ignoring it
  - the warning might be upgraded to a g_return_if_fail() in the future

It seems reasonable and safe to stop using the flag ourselves. :)

Fixes: #86
      7a77c485
  23. 11 Dec, 2020 1 commit
  25. 07 Dec, 2020 1 commit
  27. 04 Dec, 2020 1 commit
  29. 20 Nov, 2020 1 commit
  31. 18 Nov, 2020 1 commit
  33. 16 Nov, 2020 1 commit
  35. 09 Nov, 2020 1 commit
  37. 08 Nov, 2020 1 commit
  39. 01 Nov, 2020 1 commit
  41. 31 Oct, 2020 1 commit
  43. 29 Oct, 2020 2 commits
  45. 27 Oct, 2020 1 commit
  47. 26 Oct, 2020 1 commit
  49. 24 Oct, 2020 1 commit
  51. 23 Oct, 2020 1 commit
  53. 22 Oct, 2020 3 commits
  55. 21 Oct, 2020 6 commits
  57. 20 Oct, 2020 1 commit