Commit 0dbaa469 authored by Romain Bouvier's avatar Romain Bouvier

Do not require connexion to generate manpage

- Use local xml/dtd in docbook-xsl
parent 0842e114
Pipeline #267 passed with stages
in 1 minute and 26 seconds
...@@ -5,7 +5,7 @@ man_MANS = \ ...@@ -5,7 +5,7 @@ man_MANS = \
if MAINTAINER_MODE if MAINTAINER_MODE
%.1: %.xml %.1: %.xml
xsltproc http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl $< xsltproc --nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl $<
endif endif
EXTRA_DIST = \ EXTRA_DIST = \
......
  • Hey @skunnyk, this change seems to break the build. How is xsltproc supposed to get docbook.xsl if there's no connection?

    xsltproc --nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl xfce4-terminal.xml
    I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
    warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl"
    cannot parse http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
  • Because it should use what is provided in docbook-xsl package, which is (should?) a dependency of gtkdoc.

    And that was what was used previously: 125c9335 And what is used in thunar, libxfce4ui, exo etc :/

  • libxfce4ui and exo explicitly require gtk-doc in their configure.ac.in files while xfce4-terminal does not. Should it be added as a requirement? Otherwise, people might not be able to build the terminal from git.

  • gtk-doc itself is not mandatory to build terminal (xsltproc/docbook-xsl is)

    But gtk-doc is a requirement to build Xfce.

    But yes, since my change, you need xsltproc at build time with git version (before you needed to add --enable-gen-doc and have some old tools installed).

    As gtk-doc/xsltproc are already needed to build other parts of xfce, I think it's not a problem to add GTK_DOC_CHECK to terminal !

  • I've made this change, thanks!

Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment