I've updated two of my machines to fedora-34/xfce 4.16.0-2.fc34 and I'm having problems unlocking after screensave.
When trying to unlock, I see the unlock dialog, but typing has no effect - I don't see anything happening in the dialog box.
I've had to ssh in and kill the screensaver; I see the xfce4-screensaver-dialog process running.
It doesn't happen every time - but I've had it on both of my machines (that are quite different hardware and displays)
Interesting; I wonder how that's happened on both my machines (I did copy over the xfce config from one to the other a long time ago); and I don't know whether they were both running prior to the upgrade.
OK, I've taken xscreensaver out of my session; lets see for a few days if xfce4-screensaver by itself behaves.
Yep, disabling xscreensaver fixes this. So, lets close this.
(Still I'm curious what the change of behaviour on upgrade is; did something enable the other one, or did they start interacting differently; odd).
I suppose you disabled xscreensaver in 'Application Autostart' tab of 'Session and Startup' dialog.
xscreensaver-systemd that you seemed to have running is rather new thing in xscreensaver. (Integrated in XcreenSaver 5.43, and not present e.g. in my system Xubuntu 20.04.) If you have enabled xscreensaver, I think it will lock by it in case of suspend whem using systemd regardless of Xfce's 'Lock screen before' sleep setting.
I'm reopening that one because maybe we could do a better job when grabbing keyboard, or something. There's also xfce/xfce4-session#60 (closed) still open which is related, and whose resolution would make this problem less likely (xfce/libxfce4ui#64 (closed) must have already improved things in that respect).