Master switch for lock screen breaks xflock4
In Screensaver Preferences dialog there is Enable Lock Screen switch. If you toggle the switch off, running xflock4
or "Lock Screen" from a menu has no effect; the script just returns 0, if xfce4-screensaver
is running. This is wrong. If user runs xflock4
he/she expects it to lock screen and if it can not do that, it should return non-zero. I question the purpose of the master switch. Note that even if the switch is off, xflock4
may work, if /general/LockCommand
property is set in the xfce4-session
channel of Xfconf, because that is run before xfce4-screensaver-command --lock
in the current implementation of xflock4
. Is this because there may be desire to give user a possibility to use another utility for locking while xfce4-screensaver for screen saving? If that master switch is used, it should only affect to locking by Xfce4-screensaver i.e. xfce4-screensaver-command --lock
should exit with non-zero, but I think it is best to remove the switch altogether. If there is a need to disable locking in case of e.g. Guest session, it can be done by setting /general/LockCommand
property to 'true' or even better 'false' if xfce/xfce4-session!20 (closed) is approved. That does not affect to locking when screensaver becomes active, though, but it has a separate switch in screensaver settings anyway. Locking with system sleep can be configured in power manager settings, and that setting should affect to locking by any method used by xflock4.
Tested by xfce4-screensaver 0.1.10